[GitHub] [solr] dsmiley commented on pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-25 Thread GitBox
dsmiley commented on pull request #265: URL: https://github.com/apache/solr/pull/265#issuecomment-906001252 We could convert SolrDispatchFilter to a Servlet. And maybe we should ditch things that seem of suspicious value, like the "excludePatterns" thing. Really if someone wants a

[GitHub] [solr] dsmiley commented on pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-25 Thread GitBox
dsmiley commented on pull request #265: URL: https://github.com/apache/solr/pull/265#issuecomment-905995578 If the idea is to leverage the constructs in the servlet API more to our advantage, then perhaps both Tracing and Rate Limiting should be servlet Filters? FWIW I don't find

[GitHub] [solr-operator] HoustonPutman opened a new pull request #314: Update smoketest to use the Solr Helm chart.

2021-08-25 Thread GitBox
HoustonPutman opened a new pull request #314: URL: https://github.com/apache/solr-operator/pull/314 Related to #112 Ran through the full artifact build and smoke test, and it works very well. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [solr] madrob commented on a change in pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-25 Thread GitBox
madrob commented on a change in pull request #265: URL: https://github.com/apache/solr/pull/265#discussion_r695204142 ## File path: solr/core/src/java/org/apache/solr/servlet/CoreService.java ## @@ -0,0 +1,451 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] makosten commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-25 Thread GitBox
makosten commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r696144763 ## File path: solr/core/src/test/org/apache/solr/handler/component/MockSortSpecBuilder.java ## @@ -0,0 +1,36 @@ +package org.apache.solr.handler.component;

[GitHub] [solr] madrob commented on a change in pull request #267: SOLR-15595: Partial results from shard queries needlessly discarded for queries without sort fields

2021-08-25 Thread GitBox
madrob commented on a change in pull request #267: URL: https://github.com/apache/solr/pull/267#discussion_r696140459 ## File path: solr/core/src/test/org/apache/solr/handler/component/MockSortSpecBuilder.java ## @@ -0,0 +1,36 @@ +package org.apache.solr.handler.component;

[GitHub] [solr-operator] HoustonPutman commented on issue #307: Expose operator metrics

2021-08-25 Thread GitBox
HoustonPutman commented on issue #307: URL: https://github.com/apache/solr-operator/issues/307#issuecomment-905896784 I think this would be a wonderful addition. Let's target it for the next version (`v0.5.0`), that should come shortly after `v0.4.0`. A good start would just be

[jira] [Commented] (SOLR-15410) GC log is directed to console when starting Solr with Java 11 Open J9 on Windows

2021-08-25 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404729#comment-17404729 ] Colvin Cowie commented on SOLR-15410: - Okay sure, I'll do that tomorrow. Thanks > GC log is directed

[jira] [Commented] (SOLR-15410) GC log is directed to console when starting Solr with Java 11 Open J9 on Windows

2021-08-25 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404724#comment-17404724 ] David Eric Pugh commented on SOLR-15410: [~cjcowie]this is going to sound lame, but I struggle

[jira] [Comment Edited] (SOLR-11191) Shard Split doesn't work on indexes that have nested documents

2021-08-25 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404723#comment-17404723 ] Tomas Eduardo Fernandez Lobbe edited comment on SOLR-11191 at 8/25/21, 9:08 PM:

[jira] [Comment Edited] (SOLR-11191) Shard Split doesn't work on indexes that have nested documents

2021-08-25 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404723#comment-17404723 ] Tomas Eduardo Fernandez Lobbe edited comment on SOLR-11191 at 8/25/21, 9:08 PM:

[jira] [Commented] (SOLR-11191) Shard Split doesn't work on indexes that have nested documents

2021-08-25 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404723#comment-17404723 ] Tomas Eduardo Fernandez Lobbe commented on SOLR-11191: -- Was looking at this today

[jira] [Comment Edited] (SOLR-11191) Shard Split doesn't work on indexes that have nested documents

2021-08-25 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404723#comment-17404723 ] Tomas Eduardo Fernandez Lobbe edited comment on SOLR-11191 at 8/25/21, 9:08 PM:

[GitHub] [solr-operator] HoustonPutman opened a new pull request #313: Ability to schedule automatic restarts for SolrPrometheusExporters

2021-08-25 Thread GitBox
HoustonPutman opened a new pull request #313: URL: https://github.com/apache/solr-operator/pull/313 Resolves #310 Need to test manually, but it copies almost all of the logic from the SolrCloud controller. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [solr-operator] thelabdude opened a new pull request #312: Configuration options to support an additional client TLS cert in addition to the server certificate

2021-08-25 Thread GitBox
thelabdude opened a new pull request #312: URL: https://github.com/apache/solr-operator/pull/312 Solr supports using a different TLS certificate (keystore & truststore) for making client requests (to other Solr pods) than the server certificate. This PR enhances the TLS configuration

[GitHub] [solr] HoustonPutman commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r696012394 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3

[GitHub] [solr] athrog commented on pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on pull request #271: URL: https://github.com/apache/solr/pull/271#issuecomment-905759932 Regarding > One thing I couldn't find a similar setting for in the v2 client was: (not sure if this is actually an issue or not) > new

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695996885 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3 for a key

[GitHub] [solr] HoustonPutman commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695990891 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695989204 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695984569 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3 for a key

[GitHub] [solr] HoustonPutman commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695984443 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695980775 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695972996 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -253,17 +256,20 @@ void deleteDirectory(String path) throws

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695971805 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -194,55 +204,48 @@ void deleteDirectory(String path) throws

[GitHub] [solr] HoustonPutman commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695969485 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -129,17 +139,17 @@ void createDirectory(String path)

[jira] [Commented] (SOLR-15410) GC log is directed to console when starting Solr with Java 11 Open J9 on Windows

2021-08-25 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404627#comment-17404627 ] Colvin Cowie commented on SOLR-15410: - Can we get this merged into 8.10, assuming that's happening?

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695965067 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -129,17 +139,17 @@ void createDirectory(String path) throws

[jira] [Commented] (SOLR-15598) Push docker images to major public docker image registries

2021-08-25 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404555#comment-17404555 ] Houston Putman commented on SOLR-15598: --- I think this is a very good thing to think about. I'm not

[GitHub] [solr] HoustonPutman commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695851226 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3

[GitHub] [solr] HoustonPutman commented on pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman commented on pull request #271: URL: https://github.com/apache/solr/pull/271#issuecomment-905591597 @athrog Please critique to your hearts content. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] HoustonPutman opened a new pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
HoustonPutman opened a new pull request #271: URL: https://github.com/apache/solr/pull/271 https://issues.apache.org/jira/browse/SOLR-15599 So far the checklist: - [ ] The tests run and pass, with similar times (Had to change to use the http client in the tests, because https

[jira] [Commented] (SOLR-15296) Provide allowlisting mechanism in the auth plugin to ignore paths like login

2021-08-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404530#comment-17404530 ] Gus Heck commented on SOLR-15296: - Separating authentication into a servlet filter also would have the

[jira] [Commented] (SOLR-15296) Provide allowlisting mechanism in the auth plugin to ignore paths like login

2021-08-25 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404521#comment-17404521 ] Gus Heck commented on SOLR-15296: - 12.1 Use of URL Paths Upon receipt of a client request, the Web

[jira] [Updated] (SOLR-15296) Provide allowlisting mechanism in the auth plugin to ignore paths like login

2021-08-25 Thread Zhenxu Ke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenxu Ke updated SOLR-15296: - Summary: Provide allowlisting mechanism in the auth plugin to ignore paths like login (was: Provide

[jira] [Commented] (SOLR-15296) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404432#comment-17404432 ] Jan Høydahl commented on SOLR-15296: This also ties in with {{blockUnknown}} flag, I believe if

[GitHub] [solr] epugh edited a comment on pull request #43: SOLR-15278: allow the flush parameter to be passed when doing a DELETE

2021-08-25 Thread GitBox
epugh edited a comment on pull request #43: URL: https://github.com/apache/solr/pull/43#issuecomment-905446380 I am picking this up again. I notice in the Ref Guide in main, that we do suggest this feature exists in `collections-api.adoc`! ``` Flush out all stored completed and

[GitHub] [solr] epugh commented on pull request #43: SOLR-15278: allow the flush parameter to be passed when doing a DELETE

2021-08-25 Thread GitBox
epugh commented on pull request #43: URL: https://github.com/apache/solr/pull/43#issuecomment-905446380 I am picking this up again. I notice in the Ref Guide in main, that we do suggest this feature exists! ``` Flush out all stored completed and failed async request responses:

[jira] [Assigned] (SOLR-15296) Provide allowlisting mechanism in the JWT auth plugin to ignore paths like login

2021-08-25 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15296: -- Assignee: David Eric Pugh > Provide allowlisting mechanism in the JWT auth plugin to

[GitHub] [solr] janhoy commented on pull request #269: SOLR-13138: deprecate LegacyBM25SimilarityFactory

2021-08-25 Thread GitBox
janhoy commented on pull request #269: URL: https://github.com/apache/solr/pull/269#issuecomment-905301302 I think it may make sense to deprecate it in Solr 8.10. Not because people use it in their client code and would be alerted by the annotation. But because RefGuide mentions it

[jira] [Resolved] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15324. Resolution: Fixed Resolving for 9.0. If anyone thinks we should back-port for 8.10, speak up. I

[jira] [Updated] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15324: --- Fix Version/s: main (9.0) > High security vulnerability in Apache Thrift - CVE-2020-13949 (+1)

[jira] [Commented] (SOLR-15324) High security vulnerability in Apache Thrift - CVE-2020-13949 (+1) bundled within Solr

2021-08-25 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17404273#comment-17404273 ] ASF subversion and git services commented on SOLR-15324: Commit

[GitHub] [solr] janhoy merged pull request #268: SOLR-15324 Upgrade Jaeger dependency from 1.1.0 to 1.6.0

2021-08-25 Thread GitBox
janhoy merged pull request #268: URL: https://github.com/apache/solr/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Issue Comment Deleted] (SOLR-14414) New Admin UI

2021-08-25 Thread Almog Tavor (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Almog Tavor updated SOLR-14414: --- Comment: was deleted (was: As said, if needed, I’m ready to take whatever control needed. But the