[jira] [Commented] (SOLR-15427) [child limit=...] should be unlimited by default

2021-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446923#comment-17446923 ] David Smiley commented on SOLR-15427: - I've seen a recent high-number count as well.

[jira] [Reopened] (SOLR-15427) [child limit=...] should be unlimited by default

2021-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reopened SOLR-15427: - > [child limit=...] should be unlimited by default > ---

[jira] [Commented] (SOLR-15427) [child limit=...] should be unlimited by default

2021-11-20 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446922#comment-17446922 ] Ishan Chattopadhyaya commented on SOLR-15427: - I've seen genuine usecases whe

[GitHub] [solr] dsmiley commented on pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
dsmiley commented on pull request #427: URL: https://github.com/apache/solr/pull/427#issuecomment-974745217 BTW I reviewed the the choice of which handler has which permissions (we did this in the previous PR for this) but I don't feel qualified to gauge the impact on tests, as it requires

[GitHub] [solr] mhitza commented on pull request #428: SOLR-14410: switch from SysV to systemd service

2021-11-20 Thread GitBox
mhitza commented on pull request #428: URL: https://github.com/apache/solr/pull/428#issuecomment-974742668 @janhoy I know in the previous PR your pointed out the possibility of handling the upgrade path SysV to systemd https://github.com/apache/lucene-solr/pull/1435#discussion_r723118782 .

[GitHub] [solr] mhitza opened a new pull request #428: SOLR-14410: switch from SysV to systemd service

2021-11-20 Thread GitBox
mhitza opened a new pull request #428: URL: https://github.com/apache/solr/pull/428 # Description * Update the installation script to configure a systemd service instead of a SysV service. * Update the documentation with the replacement systemd (systemctl) commands, and not

[GitHub] [solr] janhoy commented on a change in pull request #424: SOLR-15809 Get rid of blacklist/whitelist terminology

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #424: URL: https://github.com/apache/solr/pull/424#discussion_r753726610 ## File path: solr/CHANGES.txt ## @@ -1578,7 +1583,7 @@ Improvements SOLR_REQUESTLOG_ENABLED=true. This will respect SOLR_LOGS_DIR if it is set. (rmuir)

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753726238 ## File path: solr/core/src/java/org/apache/solr/security/RuleBasedAuthorizationPluginBase.java ## @@ -173,6 +173,7 @@ private boolean predefinedPermissionApp

[jira] [Resolved] (SOLR-15427) [child limit=...] should be unlimited by default

2021-11-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15427. - Fix Version/s: main (9.0) Resolution: Fixed > [child limit=...] should be unlimited by def

[GitHub] [solr] dsmiley merged pull request #144: SOLR-15427: Nested docs: [child limit=...] now defaults to -1

2021-11-20 Thread GitBox
dsmiley merged pull request #144: URL: https://github.com/apache/solr/pull/144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (SOLR-15427) [child limit=...] should be unlimited by default

2021-11-20 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446910#comment-17446910 ] ASF subversion and git services commented on SOLR-15427: Commit 0

[jira] [Commented] (SOLR-11623) Every request handler in Solr should implement PermissionNameProvider interface

2021-11-20 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-11623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446908#comment-17446908 ] Jan Høydahl commented on SOLR-11623: A new [GitHub Pull Request #427|https://github.c

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753723148 ## File path: solr/solr-ref-guide/src/major-changes-in-solr-9.adoc ## @@ -80,6 +80,8 @@ All the usages are replaced by BaseHttpSolrClient.RemoteSolrException a

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753723020 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()

[GitHub] [solr] janhoy commented on a change in pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy commented on a change in pull request #427: URL: https://github.com/apache/solr/pull/427#discussion_r753722612 ## File path: solr/core/src/test/org/apache/solr/security/BaseTestRuleBasedAuthorizationPlugin.java ## @@ -213,14 +212,14 @@ public void testBasicPermissions()

[GitHub] [solr] janhoy opened a new pull request #427: SOLR-11623 Every request handler - PermissionNameProvider (Take 2)

2021-11-20 Thread GitBox
janhoy opened a new pull request #427: URL: https://github.com/apache/solr/pull/427 https://issues.apache.org/jira/browse/SOLR-11623 First merge of this had test failures in prod. This PR fixes tests so that they run. -- This is an automated message from the Apache Git Service. To

[GitHub] [solr] cpoerschke commented on pull request #159: [SOLR-10059] Handle appends params in distributed requests

2021-11-20 Thread GitBox
cpoerschke commented on pull request #159: URL: https://github.com/apache/solr/pull/159#issuecomment-974716554 > ... no cloud setup test though ... #426 is about adding a `SearchHandlerAppendsCloudTest` test. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [solr] cpoerschke opened a new pull request #426: SOLR-10059: add SearchHandlerAppendsCloudTest

2021-11-20 Thread GitBox
cpoerschke opened a new pull request #426: URL: https://github.com/apache/solr/pull/426 https://issues.apache.org/jira/browse/SOLR-10059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (SOLR-11704) sample_techproducts_configs is really out-of-date

2021-11-20 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446830#comment-17446830 ] David Eric Pugh commented on SOLR-11704: I'm going to try and get SOLR-15788 wrap

[jira] [Assigned] (SOLR-15682) Add a CONTRIBUTING file

2021-11-20 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-15682: -- Assignee: David Eric Pugh > Add a CONTRIBUTING file > --- > >

[jira] [Commented] (SOLR-15807) Add a "LogInterceptor" helpe class that makes it easy to inspect & assert expected log messages

2021-11-20 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446817#comment-17446817 ] Dawid Weiss commented on SOLR-15807: I like it! I've written a similar thing, here [1