[jira] [Resolved] (SOLR-15884) unexpected response format in Collection Backup Status

2022-01-21 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman resolved SOLR-15884. --- Resolution: Fixed > unexpected response format in Collection Backup Status >

[jira] [Commented] (SOLR-15884) unexpected response format in Collection Backup Status

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480279#comment-17480279 ] ASF subversion and git services commented on SOLR-15884: Commit

[jira] [Commented] (SOLR-15884) unexpected response format in Collection Backup Status

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480278#comment-17480278 ] ASF subversion and git services commented on SOLR-15884: Commit

[GitHub] [solr] anshumg commented on a change in pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-21 Thread GitBox
anshumg commented on a change in pull request #554: URL: https://github.com/apache/solr/pull/554#discussion_r790039360 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -543,6 +543,9 @@ public void makePath(String path, byte[] data,

[jira] [Commented] (SOLR-15944) Tagger JSON should use an object, not an array

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480277#comment-17480277 ] ASF subversion and git services commented on SOLR-15944: Commit

[GitHub] [solr] dsmiley merged pull request #552: SOLR-15944: Tagger: JSON response should use map not array

2022-01-21 Thread GitBox
dsmiley merged pull request #552: URL: https://github.com/apache/solr/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] HoustonPutman merged pull request #549: SOLR-15884: Use a map for backup responses

2022-01-21 Thread GitBox
HoustonPutman merged pull request #549: URL: https://github.com/apache/solr/pull/549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (SOLR-15884) unexpected response format in Collection Backup Status

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480276#comment-17480276 ] ASF subversion and git services commented on SOLR-15884: Commit

[GitHub] [solr] HoustonPutman commented on pull request #549: SOLR-15884: Use a map for backup responses

2022-01-21 Thread GitBox
HoustonPutman commented on pull request #549: URL: https://github.com/apache/solr/pull/549#issuecomment-1018910294 Tested this out locally and it looks good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [solr] HoustonPutman commented on pull request #479: SOLR-15842: Fix async backup response

2022-01-21 Thread GitBox
HoustonPutman commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1018906578 This is good to go, minus a ChangeLog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] HoustonPutman commented on pull request #479: SOLR-15842: Fix async backup response

2022-01-21 Thread GitBox
HoustonPutman commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-1018906313 Ok, I brought over that change from #549, so now this PR adds the non-incremental backup response, and correctly merges the responses for async and non-async calls. --

[GitHub] [solr] HoustonPutman edited a comment on pull request #479: SOLR-15842: Fix async backup response

2022-01-21 Thread GitBox
HoustonPutman edited a comment on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-101098 I also added in the incremental backup information `indexFileCount`, `uploadedIndexFileCount`, `uploadedIndexFileMB` and `shardBackupIds` in the aggregated response.

[GitHub] [solr] HoustonPutman commented on pull request #479: SOLR-15842: Fix async backup response

2022-01-21 Thread GitBox
HoustonPutman commented on pull request #479: URL: https://github.com/apache/solr/pull/479#issuecomment-101098 I also added in the incremental backup information `indexFileCount`, `uploadedIndexFileCount`, `uploadedIndexFileMB` and `shardBackupIds` in the aggregated response. (if they

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r787223054 ## File path: solr/core/src/java/org/apache/solr/search/DocSet.java ## @@ -121,7 +121,7 @@ public int andNotSize(DocSet other) { * was generated from the

[GitHub] [solr] madrob commented on a change in pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-21 Thread GitBox
madrob commented on a change in pull request #554: URL: https://github.com/apache/solr/pull/554#discussion_r790011451 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -543,6 +543,9 @@ public void makePath(String path, byte[] data,

[GitHub] [solr] madrob commented on a change in pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-21 Thread GitBox
madrob commented on a change in pull request #554: URL: https://github.com/apache/solr/pull/554#discussion_r790011451 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -543,6 +543,9 @@ public void makePath(String path, byte[] data,

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789996382 ## File path: solr/core/src/java/org/apache/solr/search/DocSet.java ## @@ -117,11 +118,11 @@ public int andNotSize(DocSet other) { } /** - * Returns a

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790010642 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790010190 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r78177 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790001455 ## File path: solr/core/src/test/org/apache/solr/search/TestDocSet.java ## @@ -556,41 +558,55 @@ public void doFilterTest(IndexReader reader) throws

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790007449 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -127,22 +130,42 @@ public void testNullDocIdSet() throws Exception {

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790007312 ## File path: solr/core/src/test/org/apache/solr/search/TestFilteredDocIdSet.java ## @@ -113,7 +116,7 @@ protected boolean match(int docid) { } public

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r790001455 ## File path: solr/core/src/test/org/apache/solr/search/TestDocSet.java ## @@ -556,41 +558,55 @@ public void doFilterTest(IndexReader reader) throws

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r78177 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r78177 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r78177 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789996382 ## File path: solr/core/src/java/org/apache/solr/search/DocSet.java ## @@ -117,11 +118,11 @@ public int andNotSize(DocSet other) { } /** - * Returns a

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789991711 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/RangeFacet.java ## @@ -54,7 +53,7 @@ public RangeFacet(String name, SchemaField

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480265#comment-17480265 ] Dawid Weiss commented on SOLR-14660: I am away this week and with limited access to the internet. I'm

[GitHub] [solr] anshumg commented on a change in pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-21 Thread GitBox
anshumg commented on a change in pull request #554: URL: https://github.com/apache/solr/pull/554#discussion_r789957037 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java ## @@ -543,6 +543,9 @@ public void makePath(String path, byte[] data,

[jira] [Commented] (SOLR-15556) Ref Guide Redesign Phase 3: Replace Jekyll

2022-01-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480252#comment-17480252 ] Mike Drob commented on SOLR-15556: -- One interesting side effect (I think related to this) is that after

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-21 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r789930090 ## File path: solr/solr-ref-guide/src/dense-vector-search.adoc ## @@ -0,0 +1,308 @@ += Dense Vector Search +// Licensed to the Apache Software

[jira] [Updated] (SOLR-14909) Add replica is very slow on a large cluster

2022-01-21 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-14909: - Fix Version/s: 9.0 main (10.0) > Add replica is very slow on a large cluster

[jira] [Updated] (SOLR-14909) Add replica is very slow on a large cluster

2022-01-21 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker updated SOLR-14909: - Affects Version/s: 8.11 8.10 8.9

[jira] [Resolved] (SOLR-14909) Add replica is very slow on a large cluster

2022-01-21 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Thacker resolved SOLR-14909. -- Resolution: Fixed > Add replica is very slow on a large cluster >

[jira] [Commented] (SOLR-14909) Add replica is very slow on a large cluster

2022-01-21 Thread Varun Thacker (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480230#comment-17480230 ] Varun Thacker commented on SOLR-14909: -- Hi David, You are right - I think we can close this since

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789901078 ## File path: solr/core/src/java/org/apache/solr/search/DocSet.java ## @@ -117,11 +118,11 @@ public int andNotSize(DocSet other) { } /** - * Returns

[GitHub] [solr] HoustonPutman commented on pull request #550: SOLR-15917: Rename contrib -> modules

2022-01-21 Thread GitBox
HoustonPutman commented on pull request #550: URL: https://github.com/apache/solr/pull/550#issuecomment-1018754574 Ok after many rounds of testing the Nightly & HDFS tests, only 1 fails: `SharedFSAutoReplicaFailoverTest`. However this fails on main for me consistently, so I don't think it

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789897875 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/RangeFacet.java ## @@ -54,7 +53,7 @@ public RangeFacet(String name, SchemaField

[GitHub] [solr] dsmiley commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
dsmiley commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789897662 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/AbstractSolrQueryFacet.java ## @@ -50,11 +49,11 @@ protected

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789803776 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/AnalyticsDriver.java ## @@ -37,28 +37,28 @@ * * @param manager of the request

[GitHub] [solr] magibney commented on a change in pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-21 Thread GitBox
magibney commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r789890276 ## File path: solr/solr-ref-guide/src/dense-vector-search.adoc ## @@ -0,0 +1,308 @@ += Dense Vector Search +// Licensed to the Apache Software Foundation

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480213#comment-17480213 ] Mike Drob commented on SOLR-14660: -- [~dweiss] - can we request some of your gradle expertise to help

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-21 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r789862393 ## File path: solr/solr-ref-guide/src/dense-vector-search.adoc ## @@ -0,0 +1,308 @@ += Dense Vector Search +// Licensed to the Apache Software

[GitHub] [solr-operator] nickumia-reisys opened a new issue #399: Random Loss of Credentials

2022-01-21 Thread GitBox
nickumia-reisys opened a new issue #399: URL: https://github.com/apache/solr-operator/issues/399 Hi, I was searching official documentation and previous issues to see if this issue was ever brought up before, but couldn't find anything. Please let me know what technical

[GitHub] [solr] dsmiley commented on pull request #555: SOLR-13138: Remove deprecations in highlighting

2022-01-21 Thread GitBox
dsmiley commented on pull request #555: URL: https://github.com/apache/solr/pull/555#issuecomment-1018709907 oops; I meant to put this on my fork, not upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480193#comment-17480193 ] ASF subversion and git services commented on SOLR-14142: Commit

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480192#comment-17480192 ] ASF subversion and git services commented on SOLR-14142: Commit

[jira] [Commented] (SOLR-13138) Remove deprecated code prior to 9.0

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480191#comment-17480191 ] ASF subversion and git services commented on SOLR-13138: Commit

[jira] [Commented] (SOLR-14142) Enable jetty's request log by default

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480190#comment-17480190 ] ASF subversion and git services commented on SOLR-14142: Commit

[jira] [Resolved] (SOLR-14142) Enable jetty's request log by default

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14142. Resolution: Fixed > Enable jetty's request log by default > -

[GitHub] [solr] dsmiley opened a new pull request #555: SOLR-13138: Remove deprecations in highlighting

2022-01-21 Thread GitBox
dsmiley opened a new pull request #555: URL: https://github.com/apache/solr/pull/555 hl.method=postings was marked for deprecation and un-documented a release or more ago. https://issues.apache.org/jira/browse/SOLR-13138 `gw check` passes. The Postings highlighter was

[GitHub] [solr] risdenk commented on a change in pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-21 Thread GitBox
risdenk commented on a change in pull request #553: URL: https://github.com/apache/solr/pull/553#discussion_r789842243 ## File path: solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java ## @@ -41,6 +41,10 @@ public boolean reject(Thread t) {

[GitHub] [solr] janhoy merged pull request #542: SOLR-14142 Log in Solr's log whether request logging is enabled

2022-01-21 Thread GitBox
janhoy merged pull request #542: URL: https://github.com/apache/solr/pull/542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] risdenk commented on pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-21 Thread GitBox
risdenk commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-1018680697 > I'm concerned about this missing changes to the Hadoop code from the endianness fix, the upgrade to 3.3.1, and whatever else we've had to patch up since this PR was originally

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480178#comment-17480178 ] Kevin Risden commented on SOLR-14660: - The HDFS integration isn't THAT complicated. 99% of the crap

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789814138 ## File path: solr/CHANGES.txt ## @@ -72,6 +72,10 @@ New Features Improvements -- +* SOLR-15257: Add DocSetQuery in lieu of

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789811761 ## File path: solr/core/src/java/org/apache/solr/search/FunctionRangeQuery.java ## @@ -42,7 +43,12 @@ public FunctionRangeQuery(ValueSourceRangeFilter filter) {

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789811443 ## File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789804691 ## File path: solr/CHANGES.txt ## @@ -72,6 +72,10 @@ New Features Improvements -- +* SOLR-15257: Add DocSetQuery in lieu of

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789803776 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/AnalyticsDriver.java ## @@ -37,28 +37,28 @@ * * @param manager of the request

[GitHub] [solr] madrob commented on pull request #324: SOLR-14660 - move HDFS to a contrib module

2022-01-21 Thread GitBox
madrob commented on pull request #324: URL: https://github.com/apache/solr/pull/324#issuecomment-1018662773 I'm concerned about this missing changes to the Hadoop code from the endianness fix, the upgrade to 3.3.1, and whatever else we've had to patch up since this PR was originally

[GitHub] [solr] Caa52 commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
Caa52 commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789797372 ## File path: solr/contrib/analytics/src/java/org/apache/solr/analytics/facet/AbstractSolrQueryFacet.java ## @@ -50,11 +49,11 @@ protected

[GitHub] [solr] madrob commented on a change in pull request #529: SOLR-15257 Add DocSetQuery in lieu of DocSet.getTopFilter

2022-01-21 Thread GitBox
madrob commented on a change in pull request #529: URL: https://github.com/apache/solr/pull/529#discussion_r789791743 ## File path: solr/CHANGES.txt ## @@ -72,6 +72,10 @@ New Features Improvements -- +* SOLR-15257: Add DocSetQuery in lieu of

[jira] [Commented] (SOLR-15660) Remove universal 10 second test thread leak linger.

2022-01-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480159#comment-17480159 ] Gus Heck commented on SOLR-15660: - Another puzzling thing is that the stack trace there appears to

[jira] [Updated] (SOLR-15660) Remove universal 10 second test thread leak linger.

2022-01-21 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gus Heck updated SOLR-15660: Attachment: screenshot-1.png > Remove universal 10 second test thread leak linger. >

[jira] [Resolved] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15870. Resolution: Fixed Trying to close this again, crossing fingers. Looks good in jenkins so far >

[GitHub] [solr] janhoy commented on pull request #542: SOLR-14142 Log in Solr's log whether request logging is enabled

2022-01-21 Thread GitBox
janhoy commented on pull request #542: URL: https://github.com/apache/solr/pull/542#issuecomment-1018641639 Thanks for the review. I'll merge now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [solr] magibney commented on a change in pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-21 Thread GitBox
magibney commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r789773406 ## File path: solr/solr-ref-guide/src/dense-vector-search.adoc ## @@ -0,0 +1,308 @@ += Dense Vector Search +// Licensed to the Apache Software Foundation

[jira] [Assigned] (SOLR-15259) Lower default hl.fragAlignRatio

2022-01-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-15259: --- Assignee: David Smiley > Lower default hl.fragAlignRatio > ---

[jira] [Commented] (SOLR-14686) Remove log "[coreName]" (logid) which is redundant with MDC

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480143#comment-17480143 ] ASF subversion and git services commented on SOLR-14686: Commit

[GitHub] [solr] dsmiley merged pull request #517: SOLR-14686 Remove log "[coreName]" (logid) which is redundant with MDC

2022-01-21 Thread GitBox
dsmiley merged pull request #517: URL: https://github.com/apache/solr/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] madrob commented on a change in pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-21 Thread GitBox
madrob commented on a change in pull request #553: URL: https://github.com/apache/solr/pull/553#discussion_r789752564 ## File path: solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java ## @@ -41,6 +41,10 @@ public boolean reject(Thread t) {

[jira] [Commented] (SOLR-15660) Remove universal 10 second test thread leak linger.

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480138#comment-17480138 ] Jan Høydahl commented on SOLR-15660: I see several test failures with "leaked threads" in the report,

[GitHub] [solr] madrob commented on pull request #553: SOLR-15942: Upgrade Hadoop to 3.3.1

2022-01-21 Thread GitBox
madrob commented on pull request #553: URL: https://github.com/apache/solr/pull/553#issuecomment-1018607670 We shouldn't need https://github.com/apache/solr/blob/ebc9e00fa331f52db6373e6e0c9af6adbe217bf1/solr/core/src/test/org/apache/hadoop/http/HttpServer2.java anymore, right? Since that

[GitHub] [solr] madrob opened a new pull request #554: SOLR-15918 Avoid repetitive creating parent znodes

2022-01-21 Thread GitBox
madrob opened a new pull request #554: URL: https://github.com/apache/solr/pull/554 https://issues.apache.org/jira/browse/SOLR-15918 When uploading a configset, we do not need to create the parent znodes for each file. I did not have idea on how to make a unit test here that

[jira] [Commented] (SOLR-13396) SolrCloud will delete the core data for any core that is not referenced in the clusterstate

2022-01-21 Thread Koen De Groote (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480124#comment-17480124 ] Koen De Groote commented on SOLR-13396: --- On my end, we implemented a daily backup of solr.  

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480111#comment-17480111 ] David Smiley commented on SOLR-14660: - Sigh. Maybe you don't recall but we over-used the word

[jira] [Commented] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480105#comment-17480105 ] ASF subversion and git services commented on SOLR-15870: Commit

[jira] [Commented] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480100#comment-17480100 ] ASF subversion and git services commented on SOLR-15870: Commit

[GitHub] [solr] ctargett commented on pull request #550: SOLR-15917: Rename contrib -> modules

2022-01-21 Thread GitBox
ctargett commented on pull request #550: URL: https://github.com/apache/solr/pull/550#issuecomment-1018530029 I'm fine with merging this and dealing with the merge conflicts in the Antora branch, I suspect these would be relatively minor. If this is ready, let's keep making progress IMO.

[jira] [Commented] (SOLR-15947) Add filter to vector search

2022-01-21 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17480080#comment-17480080 ] Joel Bernstein commented on SOLR-15947: --- During testing I found that there is no way currently to

[jira] [Updated] (SOLR-15947) Add filter to vector search

2022-01-21 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-15947: -- Description: LUCENE-10382 is adding the ability to add a query to filter the result set that

[jira] [Created] (SOLR-15947) Add filter to vector search

2022-01-21 Thread Joel Bernstein (Jira)
Joel Bernstein created SOLR-15947: - Summary: Add filter to vector search Key: SOLR-15947 URL: https://issues.apache.org/jira/browse/SOLR-15947 Project: Solr Issue Type: Improvement

[GitHub] [solr] madrob commented on a change in pull request #542: SOLR-14142 Log in Solr's log whether request logging is enabled

2022-01-21 Thread GitBox
madrob commented on a change in pull request #542: URL: https://github.com/apache/solr/pull/542#discussion_r789656412 ## File path: solr/core/src/java/org/apache/solr/util/StartupLoggingUtils.java ## @@ -187,4 +187,20 @@ public static String getLogLevelString() { else if

[GitHub] [solr] alessandrobenedetti commented on a change in pull request #476: SOLR-15880: K Nearest Neighbors Search

2022-01-21 Thread GitBox
alessandrobenedetti commented on a change in pull request #476: URL: https://github.com/apache/solr/pull/476#discussion_r789563790 ## File path: solr/solr-ref-guide/src/dense-vector-search.adoc ## @@ -0,0 +1,308 @@ += Dense Vector Search +// Licensed to the Apache Software

[jira] [Reopened] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened SOLR-15870: Re-opening to tweak the test further. > Test TestCollectionAPI fails frequently >

[jira] [Commented] (SOLR-15870) Test TestCollectionAPI fails frequently

2022-01-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479994#comment-17479994 ] ASF subversion and git services commented on SOLR-15870: Commit

[jira] [Comment Edited] (SOLR-13396) SolrCloud will delete the core data for any core that is not referenced in the clusterstate

2022-01-21 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479982#comment-17479982 ] Colvin Cowie edited comment on SOLR-13396 at 1/21/22, 10:30 AM: I

[jira] [Commented] (SOLR-13396) SolrCloud will delete the core data for any core that is not referenced in the clusterstate

2022-01-21 Thread Colvin Cowie (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479982#comment-17479982 ] Colvin Cowie commented on SOLR-13396: - I couldn't wait for something to be done / agreement to be

[jira] [Updated] (SOLR-15718) Remove backcompat feature solr.useUnsafeOverseerResponse

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15718: --- Priority: Blocker (was: Major) > Remove backcompat feature solr.useUnsafeOverseerResponse >

[jira] [Updated] (SOLR-15718) Remove backcompat feature solr.useUnsafeOverseerResponse

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15718: --- Fix Version/s: main (10.0) > Remove backcompat feature solr.useUnsafeOverseerResponse >

[jira] [Updated] (SOLR-15718) Remove backcompat feature solr.useUnsafeOverseerResponse

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-15718: --- Parent: (was: SOLR-13138) Issue Type: Bug (was: Sub-task) > Remove backcompat feature

[jira] [Commented] (SOLR-12632) Completely remove Trie fields

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-12632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479974#comment-17479974 ] Jan Høydahl commented on SOLR-12632: Trie fields are still with us. Would be nice to get rid of them

[jira] [Commented] (SOLR-14660) Migrating HDFS into a module

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479966#comment-17479966 ] Jan Høydahl commented on SOLR-14660: HDFS was deprecated in 8.x, so everyone kind of expects it to be

[jira] [Commented] (SOLR-15946) SOLR searching is not working in websites

2022-01-21 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479955#comment-17479955 ] Jan Høydahl commented on SOLR-15946: That depends on OS and the way you have installed things. Please

[GitHub] [solr] janhoy commented on pull request #542: SOLR-14142 Log in Solr's log whether request logging is enabled

2022-01-21 Thread GitBox
janhoy commented on pull request #542: URL: https://github.com/apache/solr/pull/542#issuecomment-1018325608 I think this should be ready to merge now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [solr] janhoy commented on a change in pull request #542: SOLR-14142 Log in Solr's log whether request logging is enabled

2022-01-21 Thread GitBox
janhoy commented on a change in pull request #542: URL: https://github.com/apache/solr/pull/542#discussion_r789480970 ## File path: solr/core/src/java/org/apache/solr/util/StartupLoggingUtils.java ## @@ -187,4 +187,19 @@ public static String getLogLevelString() { else if

[jira] [Commented] (SOLR-15946) SOLR searching is not working in websites

2022-01-21 Thread Raja (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479891#comment-17479891 ] Raja commented on SOLR-15946: - can you please let me know the command to shutdown the solr and zookeeper ?  

  1   2   >