joshgog commented on code in PR #1115:
URL: https://github.com/apache/solr/pull/1115#discussion_r1005251953
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
sonatype-lift[bot] commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1005193785
##
solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java:
##
@@ -1628,9 +1629,9 @@ public DirectoryFileStream(SolrParams solrParams) {
}
[
https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16416.
---
Fix Version/s: 9.1
main (10.0)
Assignee: Houston Putman
[
https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624156#comment-17624156
]
ASF subversion and git services commented on SOLR-16416:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624147#comment-17624147
]
ASF subversion and git services commented on SOLR-16363:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624148#comment-17624148
]
ASF subversion and git services commented on SOLR-16363:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16363:
Fix Version/s: 9.2
> DirectUpdateHandler2 should not throw UnknownFormatConversionException
>
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16363:
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the nice error
[
https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624145#comment-17624145
]
ASF subversion and git services commented on SOLR-16416:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16363:
Fix Version/s: main (10.0)
(was: 9.2)
> DirectUpdateHandler2 should not
[
https://issues.apache.org/jira/browse/SOLR-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624143#comment-17624143
]
ASF subversion and git services commented on SOLR-16416:
Commit
HoustonPutman merged PR #1129:
URL: https://github.com/apache/solr/pull/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624142#comment-17624142
]
ASF subversion and git services commented on SOLR-16363:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16363:
Fix Version/s: 9.2
> DirectUpdateHandler2 should not throw UnknownFormatConversionException
>
risdenk merged PR #1124:
URL: https://github.com/apache/solr/pull/1124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
risdenk commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1005148149
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -131,24 +131,24 @@ public void init(UpdateHandler uhandler, SolrCore core) {
sonatype-lift[bot] commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1005148184
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -131,24 +131,24 @@ public void init(UpdateHandler uhandler, SolrCore core)
risdenk commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1005147235
##
solr/core/src/java/org/apache/solr/util/hll/SerializationUtil.java:
##
@@ -137,8 +137,8 @@ public static byte packVersionByte(final int schemaVersion,
final int
HoustonPutman commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1005143310
##
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624132#comment-17624132
]
ASF subversion and git services commented on SOLR-16412:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16412:
Fix Version/s: 9.1
main (10.0)
Resolution: Fixed
Status:
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16412:
Priority: Major (was: Blocker)
> Race condition could trigger error on concurrent
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624128#comment-17624128
]
ASF subversion and git services commented on SOLR-16412:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624124#comment-17624124
]
ASF subversion and git services commented on SOLR-16412:
Commit
risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1005095748
##
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String
overseerId)
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624085#comment-17624085
]
ASF subversion and git services commented on SOLR-16412:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624084#comment-17624084
]
ASF subversion and git services commented on SOLR-16412:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624083#comment-17624083
]
ASF subversion and git services commented on SOLR-16412:
Commit
noblepaul commented on PR #1032:
URL: https://github.com/apache/solr/pull/1032#issuecomment-1291267801
thanks @patsonluk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
noblepaul merged PR #1032:
URL: https://github.com/apache/solr/pull/1032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624074#comment-17624074
]
Patson Luk commented on SOLR-16412:
---
[~noblepaul][~ichattopadhyaya] It's probably a good idea to push
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patson Luk updated SOLR-16412:
--
Affects Version/s: 9.1
> Race condition could trigger error on concurrent SizeLimitedDistributedMap
>
[
https://issues.apache.org/jira/browse/SOLR-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patson Luk updated SOLR-16412:
--
Priority: Blocker (was: Major)
> Race condition could trigger error on concurrent
[
https://issues.apache.org/jira/browse/SOLR-16495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624072#comment-17624072
]
Gus Heck commented on SOLR-16495:
-
Since this is just ref guide and hopefully not controversial I'll try
[
https://issues.apache.org/jira/browse/SOLR-16303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-16303:
Fix Version/s: 9.1
(was: main (10.0))
> Upgrade to Lucene 9.3
>
HoustonPutman commented on PR #1129:
URL: https://github.com/apache/solr/pull/1129#issuecomment-1291200682
@gerlowskija I have actually fixed the underlying issue. We were running
overseer ops before actually registering all of the Solr handlers.
--
This is an automated message from the
gus-asf opened a new pull request, #1130:
URL: https://github.com/apache/solr/pull/1130
https://issues.apache.org/jira/browse/SOLR-16495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-14278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-14278:
Attachment: SOLR-14278.patch
Status: Open (was: Open)
Attached is an updated patch that
dsmiley commented on PR #1088:
URL: https://github.com/apache/solr/pull/1088#issuecomment-1291167131
The bug was found/fixed locally in May of 2020. I see that Yonik's
SOLR-14278 is a test for shard split errors (not committed; seems rather
WIP/DRAFT). I took the old patch and updated it
risdenk commented on code in PR #1129:
URL: https://github.com/apache/solr/pull/1129#discussion_r1004960908
##
solr/core/src/java/org/apache/solr/cloud/OverseerNodePrioritizer.java:
##
@@ -133,6 +135,23 @@ public synchronized void prioritizeOverseerNodes(String
overseerId)
HoustonPutman opened a new pull request, #1129:
URL: https://github.com/apache/solr/pull/1129
https://issues.apache.org/jira/browse/SOLR-16416
This should fix the failing test. No idea why the endpoints noted in the
JIRA were unavailable when restarting the test nodes, but anyways it
sonatype-lift[bot] commented on code in PR #1128:
URL: https://github.com/apache/solr/pull/1128#discussion_r1004945806
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##
@@ -131,24 +131,24 @@ public void init(UpdateHandler uhandler, SolrCore core)
risdenk commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1004945487
##
solr/core/src/java/org/apache/solr/util/hll/SerializationUtil.java:
##
@@ -137,8 +137,8 @@ public static byte packVersionByte(final int schemaVersion,
final int
gerlowskija commented on code in PR #1115:
URL: https://github.com/apache/solr/pull/1115#discussion_r1004888461
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rudi Seitz updated SOLR-16496:
--
Description:
The Query Elevation Component respects the fq parameter.
A document listed in
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624018#comment-17624018
]
Alex Deparvu commented on SOLR-16477:
-
good point [~krisden], I missed this on the bug report. should
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624016#comment-17624016
]
Rudi Seitz commented on SOLR-16496:
---
I've begun implementing this request here:
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16477:
Description:
Renaming a collection results in a broken alias (name as the source param)
pointing
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16477:
Description:
Renaming a collection results in a broken alias (name as the source param)
pointing
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16477:
Attachment: broken-alias.png
> Collection RENAME api creates broken alias
>
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16477:
Description:
Renaming a collection results in a broken alias (name as the source param)
pointing
risdenk opened a new pull request, #1128:
URL: https://github.com/apache/solr/pull/1128
https://issues.apache.org/jira/browse/SOLR-16427
builds on https://github.com/apache/solr/pull/1116
Enables the following errorprone rules:
* TODO
--
This is an automated message from
Rudi Seitz created SOLR-16496:
-
Summary: provide option for Query Elevation Component to bypass
filters
Key: SOLR-16496
URL: https://issues.apache.org/jira/browse/SOLR-16496
Project: Solr
Issue
stillalex commented on PR #1127:
URL: https://github.com/apache/solr/pull/1127#issuecomment-1291056422
There is some code in the Aliases class I don't get:
```
public static Map>
convertMapOfCommaDelimitedToMapOfList(
Map collectionAliasMap) {
return
stillalex commented on PR #1127:
URL: https://github.com/apache/solr/pull/1127#issuecomment-1291053356
thanks for taking a look @risdenk! updated PR based on your observations so
far.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stillalex commented on code in PR #1127:
URL: https://github.com/apache/solr/pull/1127#discussion_r1004897653
##
solr/CHANGES.txt:
##
@@ -65,6 +65,8 @@ Optimizations
Bug Fixes
-
+* SOLR-16477: Collection RENAME api creates broken alias
Review Comment:
risdenk commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1004894002
##
solr/core/src/java/org/apache/solr/util/hll/SerializationUtil.java:
##
@@ -137,8 +137,8 @@ public static byte packVersionByte(final int schemaVersion,
final int
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17624002#comment-17624002
]
Kevin Risden commented on SOLR-16477:
-
[~stillalex] can you add to the description potentially 2
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16477:
Status: Patch Available (was: Open)
> Collection RENAME api creates broken alias
>
risdenk commented on code in PR #1127:
URL: https://github.com/apache/solr/pull/1127#discussion_r1004878560
##
solr/solrj/src/test/org/apache/solr/common/cloud/AliasesTest.java:
##
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
[
https://issues.apache.org/jira/browse/SOLR-16477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623996#comment-17623996
]
Alex Deparvu commented on SOLR-16477:
-
I was able to repro this bug via SolrJ client too
{code:java}
[
https://issues.apache.org/jira/browse/SOLR-16495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck reassigned SOLR-16495:
---
Assignee: Gus Heck
> Update first page of ref guide ("Introduction to Solr")
>
Gus Heck created SOLR-16495:
---
Summary: Update first page of ref guide ("Introduction to Solr")
Key: SOLR-16495
URL: https://issues.apache.org/jira/browse/SOLR-16495
Project: Solr
Issue Type: Task
stillalex opened a new pull request, #1127:
URL: https://github.com/apache/solr/pull/1127
https://issues.apache.org/jira/browse/SOLR-16477
# Description
Collection RENAME api creates broken alias, named as source pointing to
collection named as target.
#
HoustonPutman commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1290977959
The new releaseWizard step should allow it to work for almost all
environments. So you can go back to running it through the releaseWizard after
this is merged.
--
This is an
[
https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623976#comment-17623976
]
Kevin Risden commented on SOLR-16441:
-
FWIW I looked at this a bit. The biggest question will be do
[
https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16441:
Component/s: Server
> Upgrade Jetty to 11.x
> -
>
> Key:
[
https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16441:
Description:
Solr is currently using Jetty 9.4.x and upgrading to Jetty 10.x in SOLR-15955,
we
[
https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612729#comment-17612729
]
Kevin Risden edited comment on SOLR-16441 at 10/25/22 6:22 PM:
---
Jetty 10
[
https://issues.apache.org/jira/browse/SOLR-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623972#comment-17623972
]
Kevin Risden commented on SOLR-16494:
-
The other thing I'll add here about a separate Jetty 11.x
[ https://issues.apache.org/jira/browse/SOLR-16441 ]
Kevin Risden deleted comment on SOLR-16441:
-
was (Author: risdenk):
Jetty 10 upgrade is SOLR-15955 and is most of the way done.
> Upgrade Jetty to 11.x
> -
>
>
[
https://issues.apache.org/jira/browse/SOLR-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623971#comment-17623971
]
Joshua Ouma commented on SOLR-11028:
I found the solution after some critical analysis
> Create a
gerlowskija commented on code in PR #1115:
URL: https://github.com/apache/solr/pull/1115#discussion_r1004828107
##
solr/core/src/java/org/apache/solr/handler/admin/api/ReplaceNodeAPI.java:
##
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
madrob commented on code in PR #1116:
URL: https://github.com/apache/solr/pull/1116#discussion_r1004825708
##
solr/core/src/java/org/apache/solr/util/hll/SerializationUtil.java:
##
@@ -137,8 +137,8 @@ public static byte packVersionByte(final int schemaVersion,
final int
iamsanjay commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1004820977
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static
[
https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623963#comment-17623963
]
John Durham edited comment on SOLR-16462 at 10/25/22 6:09 PM:
--
Sure thing!
[
https://issues.apache.org/jira/browse/SOLR-16462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623963#comment-17623963
]
John Durham commented on SOLR-16462:
Sure thing! The PR should be available
iamsanjay commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1004818754
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static
chatman commented on PR #1125:
URL: https://github.com/apache/solr/pull/1125#issuecomment-1290954867
Thanks Houston, I'm trying this out with a new run of RC1. Might take an
hour or so before I get to know if it works.
If it works, I'll merge to branch_9x and main.
--
This is an
iamsanjay commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1004816133
##
solr/core/src/java/org/apache/solr/handler/replication/BackupAPI.java:
##
@@ -0,0 +1,100 @@
+package org.apache.solr.handler.replication;
+
+import static
iamsanjay commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1004814541
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -452,6 +454,11 @@ void call() throws Exception {
}
}
+ @Override
Review
iamsanjay commented on code in PR #1119:
URL: https://github.com/apache/solr/pull/1119#discussion_r1004814313
##
solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java:
##
@@ -452,6 +454,11 @@ void call() throws Exception {
}
}
+ @Override
Review
Jdurham2843 opened a new pull request, #1126:
URL: https://github.com/apache/solr/pull/1126
https://issues.apache.org/jira/browse/SOLR-16462
# Description
This pull request implements V2 equivalent endpoints for the Snapshot API
(Create, List, and Delete).
#
HoustonPutman opened a new pull request, #1125:
URL: https://github.com/apache/solr/pull/1125
Also make the release wizard work. It is currently broken with respect to
GPG signing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16476:
Resolution: Fixed
Status: Resolved (was: Patch Available)
another core dependency bites
[
https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16476:
Fix Version/s: 9.2
> Remove commons-text dependency from solr-core
>
[
https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623939#comment-17623939
]
ASF subversion and git services commented on SOLR-16476:
Commit
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290889195
https://github.com/apache/solr/pull/1124 to remove String.format from
DirectUpdateHandler2
--
This is an automated message from the Apache Git Service.
To respond to the message, please
mmoscher commented on issue #477:
URL: https://github.com/apache/solr-operator/issues/477#issuecomment-1290888915
@iampranabroy yes, all resources (Solr + ZK) in the same namespace with
NetworkPolicies denying all pod's egress traffic.
--
This is an automated message from the Apache Git
risdenk opened a new pull request, #1124:
URL: https://github.com/apache/solr/pull/1124
https://issues.apache.org/jira/browse/SOLR-16363
Follow on to https://github.com/apache/solr/pull/1121 that I merged too soon
by mistake.
--
This is an automated message from the Apache Git
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290886169
> We wouldn't even need a test.
I'm going to leave the test - it tests the `IllegalArgumentException` code
path in `DirectUpdateHandler2` that doesn't seem to be tested elsewhere.
[
https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16476:
Fix Version/s: main (10.0)
> Remove commons-text dependency from solr-core
>
DennisBerger1984 commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1290876283
Hi @ben-manes,
I can confirm that. We've bumped the version in our gradle build and I just
verified that in the resulting docker image the actual jar is 3.1.1.
--
This is an
dsmiley commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290875227
Wow; let's allow more time to review please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623934#comment-17623934
]
ASF subversion and git services commented on SOLR-16363:
Commit
risdenk commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290875313
> Can we please consider not using String.format here at all? String.format
is useful when there is non-trivial formatting. I don't think we should use
String.format when a trivial String
risdenk merged PR #1121:
URL: https://github.com/apache/solr/pull/1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623933#comment-17623933
]
ASF subversion and git services commented on SOLR-16476:
Commit
risdenk merged PR #1122:
URL: https://github.com/apache/solr/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on PR #1121:
URL: https://github.com/apache/solr/pull/1121#issuecomment-1290873232
Can we please consider not using String.format here at all? String.format
is useful when there is non-trivial formatting. I don't think we should use
String.format when a trivial String
1 - 100 of 163 matches
Mail list logo
