[
https://issues.apache.org/jira/browse/SOLR-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628120#comment-17628120
]
Shubanker commented on SOLR-16350:
--
[~krisden] Yes I did try accessing it over 127.0.0.1, the delay is
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628111#comment-17628111
]
ASF subversion and git services commented on SOLR-16414:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628107#comment-17628107
]
ASF subversion and git services commented on SOLR-16414:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628105#comment-17628105
]
ASF subversion and git services commented on SOLR-16414:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya reopened SOLR-16414:
-
The last commit caused a massive slowdown in node stop event. With 1000
cores/node,
noblepaul commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1012271453
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
[
https://issues.apache.org/jira/browse/SOLR-16490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628021#comment-17628021
]
Sanjay Dutt commented on SOLR-16490:
I am working on the v2 BACKUPCORE API. Will submit the PR in
janhoy opened a new issue, #488:
URL: https://github.com/apache/solr-operator/issues/488
A user can now bootstrap `security.json` through operator, even by providing
the raw `security.json` file in a Secret that will be uploaded to ZK on first
Solr Pod start through an init-container.
janhoy commented on issue #85:
URL: https://github.com/apache/solr-operator/issues/85#issuecomment-1301476051
First question is - should it be a configSet bootstrapping feature that will
only be run on first startup if a configset with that name does not already
exist...
OR - should
[
https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17628004#comment-17628004
]
Jason Gerlowski commented on SOLR-16468:
I'm going to grab LISTSNAPSHOT and push up a PR shortly.
[
https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski reassigned SOLR-16468:
--
Assignee: Jason Gerlowski
> Create v2 equivalent of v1 'CREATESNAPSHOT',
dsmiley commented on code in PR #862:
URL: https://github.com/apache/solr/pull/862#discussion_r1012271513
##
build.gradle:
##
@@ -207,3 +207,5 @@ apply from: file('gradle/ant-compat/solr.post-jar.gradle')
apply from: file('gradle/node.gradle')
+sourceCompatibility =
noblepaul commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1012271453
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
jkgonzio opened a new issue, #487:
URL: https://github.com/apache/solr-operator/issues/487
I ran a flexline scan and ran into some security vulnerabilities that should
be remediated:
Vulnerability ID: CVE-2021-33194
Finding Level: High
Package: golang.org/x/net/html
Version:
[
https://issues.apache.org/jira/browse/SOLR-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16517.
---
Resolution: Invalid
Please read our security page: https://solr.apache.org/security.html
[
https://issues.apache.org/jira/browse/SOLR-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ritchie Gu updated SOLR-16517:
--
Description:
I have a question regarding the solr exporter
Ritchie Gu created SOLR-16517:
-
Summary: Solr export 8.11.2-slim Vulnerabilities
Key: SOLR-16517
URL: https://issues.apache.org/jira/browse/SOLR-16517
Project: Solr
Issue Type: Bug
dsmiley commented on PR #1156:
URL: https://github.com/apache/solr/pull/1156#issuecomment-1300871894
I don't mean change Lucene code, I mean change SlowCompositeReaderWrapper
internals only. Yeah Multi-stuff is kind of discouraged... more of a -- hey,
use this if your algorithm can't
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300831545
DisjunctionMaxQuery unfortunately has a getDisjuncts that returns a mutable
Multiset (a Lucene collection subclass):
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300811132
This is a non-Lucene or non-Solr query from the external Querqy plugin.
ben-manes commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300803918
oh yes, I did not notice that `Collection getClauses(Occur occur)` is
package-private. This is returning a mutable collection, but since it is not
public then that is safe (maybe
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300772734
Yes this helps. Interestingly: The "clauses" of a BooleanQuery are
non-mutable, it is already wrapped with Collections.unmodifiableList(). So
nobody can change the clauses after calling
HoustonPutman merged PR #81:
URL: https://github.com/apache/solr-site/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
HoustonPutman opened a new pull request, #81:
URL: https://github.com/apache/solr-site/pull/81
Co-authored-by: David Smiley
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/SOLR-16496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627788#comment-17627788
]
Rudi Seitz commented on SOLR-16496:
---
Thanks, [~dsmiley], I've updated the PR based on your feedback.
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011906493
##
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTests.java:
##
@@ -602,58 +602,60 @@ public void testUnicode() throws Exception {
SolrClient client =
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011904785
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -478,6 +484,8 @@ public void testUpdate() throws Exception {
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011902917
##
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##
@@ -341,7 +346,6 @@ public void testQuery() throws Exception {
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011897088
##
solr/solrj/src/test/org/apache/solr/client/solrj/TestBatchUpdate.java:
##
@@ -46,24 +46,28 @@ public static void beforeTest() throws Exception {
@Test
public
rseitz commented on PR #1154:
URL: https://github.com/apache/solr/pull/1154#issuecomment-1300609618
Thanks for reviewing, @risdenk and thanks to @dsmiley for feedback on the
JIRA ticket. I have reworked this PR in accordance with that feedback.
--
This is an automated message from the
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011894050
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##
@@ -813,6 +813,7 @@ public String getBaseURL() {
* In this case the client is more
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011891480
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -71,7 +71,7 @@ public void testDistribJsonRequest() throws Exception {
@Override
DennisBerger1984 commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300604173
@uschindler does this help?
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011888554
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
##
@@ -118,72 +111,22 @@ public void testUtf8PerfDegradation() throws Exception {
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011881388
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ConcurrentUpdateSolrClient.java:
##
@@ -107,8 +107,8 @@ protected ConcurrentUpdateSolrClient(Builder builder) {
risdenk commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1300573313
https://github.com/apache/solr/search?q=setWrappedQuery is definitely not
used in Solr main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
risdenk commented on code in PR #1159:
URL: https://github.com/apache/solr/pull/1159#discussion_r1011865290
##
solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java:
##
@@ -295,15 +296,12 @@ private static DocCollection collectionFromObjects(
}
@Override
-
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011860272
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java:
##
@@ -813,6 +813,7 @@ public String getBaseURL() {
* In this case the client is more
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011858823
##
solr/core/src/test/org/apache/solr/search/TestSmileRequest.java:
##
@@ -71,7 +71,7 @@ public void testDistribJsonRequest() throws Exception {
@Override
risdenk commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011844656
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -46,6 +50,21 @@ public B withResponseParser(ResponseParser responseParser) {
mpetris commented on PR #1156:
URL: https://github.com/apache/solr/pull/1156#issuecomment-1300514827
> Hey, this looks excellent! The code looks a bit deja-vu... do you think we
could & should factorize out anything common?
@dsmiley We could factorize out most of
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627725#comment-17627725
]
Bence Szabó commented on SOLR-16367:
I see, having that in mind the code makes more sense now. Thank
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627696#comment-17627696
]
David Smiley commented on SOLR-16367:
-
Construction of the ClusterStateProvider is internal based on
[
https://issues.apache.org/jira/browse/SOLR-16367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627674#comment-17627674
]
Bence Szabó commented on SOLR-16367:
Maybe I am missing something but it seems to me there is no way
[
https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627665#comment-17627665
]
Noble Paul edited comment on SOLR-16512 at 11/2/22 12:12 PM:
-
MapWriter is an
[
https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627665#comment-17627665
]
Noble Paul commented on SOLR-16512:
---
MapWriter is an interface we use to serialize all objects in Solr.
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011650146
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
epugh commented on code in PR #1158:
URL: https://github.com/apache/solr/pull/1158#discussion_r1011647489
##
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingBinaryTest.java:
##
@@ -35,9 +34,15 @@ public class SolrExampleStreamingBinaryTest extends
[
https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17627655#comment-17627655
]
Eric Pugh commented on SOLR-16512:
--
Out of curiosity, what does moving to MapWriter give us? I read
noblepaul commented on PR #1159:
URL: https://github.com/apache/solr/pull/1159#issuecomment-1300178646
> Seems fine. Couldn't find review button, btw.
I think if you go to the "files" tab , it's on the top right
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul reassigned SOLR-16512:
-
Assignee: Noble Paul
> Eliminate noggit JSONWriter.Writable from Solr classes
>
mkhludnev commented on PR #1159:
URL: https://github.com/apache/solr/pull/1159#issuecomment-1299968926
Seems fine. Couldn't find review button, btw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-16512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-16512:
--
Summary: Eliminate noggit JSONWriter.Writable from Solr classes (was: Get
rid of JSONWriter.Writable
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1299808362
For booleanQuery we have many tests in Lucene core and its own cache
implementation. So it is three cases where it may break:
- somebody calls getClauses() and modifies them (adding
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1299803390
Anyways, we should figure out if not the WrappedQuery is changing its
hashCode, because this one was explicitely mutable. But the setter is never
called from Solr (dead code according to
uschindler commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1299799324
The clauses should not be modifyable from outside and I don't know any code
doing this. BooleanQuery is designed to be immutable, the problem is more that
there seems to be a getter that
ben-manes commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1299774688
Lucerne’s BooleanQuery clauseSets is externally mutable. The getClauses
method returns a mutable collection (hashset) so the caller might add to it. I
don’t see an occurrence, but some
DennisBerger1984 commented on PR #1118:
URL: https://github.com/apache/solr/pull/1118#issuecomment-1299722332
It's a WrappedQuery Object.
--
This is an
DennisBerger1984 commented on PR #1156:
URL: https://github.com/apache/solr/pull/1156#issuecomment-1299716722
It's a WrappedQuery object.
--
This is
sonatype-lift[bot] commented on PR #1159:
URL: https://github.com/apache/solr/pull/1159#issuecomment-1299671194
:warning: **314 God Classes** were detected by Lift in this project. [Visit
the Lift web
60 matches
Mail list logo
