dsmiley opened a new pull request, #1243:
URL: https://github.com/apache/solr/pull/1243
Remove transient core processing from SolrCores. Move to a new subclass of
SolrCores: TransientSolrCores. Remove TransientSolrCoreCacheFactory; not a
useful intermediary.
Ideally move
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16584:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> integrationTests (BATS) fail
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16584:
Fix Version/s: main (10.0)
9.2
> integrationTests (BATS) fail on GitHub and
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648294#comment-17648294
]
Kevin Risden commented on SOLR-16584:
-
I'm going to proactively resolve this and keep an eye on
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16584:
Status: Patch Available (was: Open)
> integrationTests (BATS) fail on GitHub and Jenkins
>
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648293#comment-17648293
]
ASF subversion and git services commented on SOLR-16584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16584:
---
Assignee: Kevin Risden
> integrationTests (BATS) fail on GitHub and Jenkins
>
risdenk closed pull request #1223: SOLR-16584 BATS test fails stopping two
instances
URL: https://github.com/apache/solr/pull/1223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
risdenk commented on PR #1223:
URL: https://github.com/apache/solr/pull/1223#issuecomment-1353837501
Closed since not debugging here anymore for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648290#comment-17648290
]
ASF subversion and git services commented on SOLR-16584:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648291#comment-17648291
]
ASF subversion and git services commented on SOLR-16589:
Commit
risdenk merged PR #1240:
URL: https://github.com/apache/solr/pull/1240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Large fields with
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648289#comment-17648289
]
ASF subversion and git services commented on SOLR-16589:
Commit
risdenk commented on PR #1241:
URL: https://github.com/apache/solr/pull/1241#issuecomment-1353833905
> Esp. given that a 9.1.1 release looks
https://github.com/apache/solr/pull/1236, would you consider backporting this
to branch_9_1?
yup done and done :)
--
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648287#comment-17648287
]
ASF subversion and git services commented on SOLR-16589:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Fix Version/s: 9.1.1
> Large fields with large="true" can be truncated when using unicode values
>
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648288#comment-17648288
]
ASF subversion and git services commented on SOLR-16589:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648286#comment-17648286
]
ASF subversion and git services commented on SOLR-16589:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648284#comment-17648284
]
Kevin Risden commented on SOLR-16589:
-
Well being a bit too adventurous with the unicode :) This
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648285#comment-17648285
]
ASF subversion and git services commented on SOLR-16589:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Fix Version/s: 9.2
> Large fields with large="true" can be truncated when using unicode values
>
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648279#comment-17648279
]
Kevin Risden commented on SOLR-16589:
-
Sigh let it sit all day and then Jenkins fails with the
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648277#comment-17648277
]
ASF subversion and git services commented on SOLR-16589:
Commit
magibney commented on PR #1241:
URL: https://github.com/apache/solr/pull/1241#issuecomment-1353701952
Esp. given that a 9.1.1 release looks
[inevitable](https://github.com/apache/solr/pull/1236), would you consider
backporting this to `branch_9_1`?
--
This is an automated message from
[
https://issues.apache.org/jira/browse/SOLR-14906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648240#comment-17648240
]
Mikhail Khludnev commented on SOLR-14906:
-
adding
{code}
maven {
url
epugh commented on PR #1217:
URL: https://github.com/apache/solr/pull/1217#issuecomment-1353674604
> needs CHANGES.txt too
Went ahad and added it. Ugh, got conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
epugh commented on code in PR #1217:
URL: https://github.com/apache/solr/pull/1217#discussion_r1050102202
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrClient.java:
##
@@ -259,6 +261,21 @@ public Builder withBaseSolrUrls(String... solrUrls) {
return
epugh commented on PR #1217:
URL: https://github.com/apache/solr/pull/1217#issuecomment-1353655272
> needs CHANGES.txt too
I will add this at the end, I find I always get merge conflicts when I add
this early...
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648227#comment-17648227
]
Eric Pugh commented on SOLR-16567:
--
Makes sense to me!
> java.lang.StackOverflowError when combining
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648218#comment-17648218
]
Gabriel Magno commented on SOLR-16567:
--
Oh, noh! I was referring to the fact of KNN queries being
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648218#comment-17648218
]
Gabriel Magno edited comment on SOLR-16567 at 12/15/22 7:31 PM:
Oh, noh!
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Affects Version/s: (was: 9.2)
> Large fields with large="true" can be truncated when using
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648216#comment-17648216
]
ASF subversion and git services commented on SOLR-16589:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Fix Version/s: main (10.0)
> Large fields with large="true" can be truncated when using unicode
risdenk merged PR #1241:
URL: https://github.com/apache/solr/pull/1241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
David Smiley created SOLR-16591:
---
Summary: Refactor transient cores to be a subclass of SolrCores
Key: SOLR-16591
URL: https://issues.apache.org/jira/browse/SOLR-16591
Project: Solr
Issue
noblepaul commented on PR #1242:
URL: https://github.com/apache/solr/pull/1242#issuecomment-1353491762
@justinrsweeney @patsonluk this is still WIP , reviews are welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Status: Patch Available (was: Open)
> Large fields with large="true" can be truncated when using
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden reassigned SOLR-16589:
---
Assignee: Kevin Risden (was: Michael Gibney)
> Large fields with large="true" can be
dsmiley commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049951107
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean
parallelUpdates) {
[
https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648168#comment-17648168
]
David Smiley commented on SOLR-14988:
-
In retrospect, renaming the method isn't necessary; its name
[
https://issues.apache.org/jira/browse/SOLR-16590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648155#comment-17648155
]
Eric Pugh commented on SOLR-16590:
--
This was inspired by [~dsmiley] comment in reviewing a PR.
risdenk commented on code in PR #86:
URL: https://github.com/apache/solr-site/pull/86#discussion_r1049844493
##
requirements.txt:
##
@@ -5,6 +5,9 @@ checksumdir~=1.2.0
# Pelican plugins
mdx-include~=1.4.1
beautifulsoup4~=4.9.3
+# Dependencies of the vex plugin
+jsonschema
risdenk opened a new pull request, #1241:
URL: https://github.com/apache/solr/pull/1241
https://issues.apache.org/jira/browse/SOLR-16589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648140#comment-17648140
]
Eric Pugh commented on SOLR-16567:
--
So, should we close this issue? As a follow on thought, was there
[
https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648136#comment-17648136
]
Gabriel Magno commented on SOLR-16567:
--
The KNN was actually not broken in the main branch.
It was
epugh commented on PR #1220:
URL: https://github.com/apache/solr/pull/1220#issuecomment-1353303993
@dsmiley @risdenk I think I am ready for another review after addressing
feedback. Can I get a LGTM?
--
This is an automated message from the Apache Git Service.
To respond to the
epugh commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049812581
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean
parallelUpdates) {
Eric Pugh created SOLR-16590:
Summary: Standardize Builder method names
Key: SOLR-16590
URL: https://issues.apache.org/jira/browse/SOLR-16590
Project: Solr
Issue Type: Sub-task
Affects
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Summary: Large fields with large="true" can be truncated when using unicode
values (was: Large
epugh commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049801546
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java:
##
@@ -34,6 +35,8 @@
protected boolean useMultiPartPost;
protected Integer
epugh commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049793352
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean
parallelUpdates) {
epugh commented on code in PR #1220:
URL: https://github.com/apache/solr/pull/1220#discussion_r1049791072
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##
@@ -245,6 +249,16 @@ public Builder withParallelUpdates(boolean
parallelUpdates) {
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Description:
h3. Summary
For fields using large="true", large fields (which is what they are
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Description:
h3. Summary
For fields using large="true", large fields (which is what they are
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-16589:
Description:
h3. Summary
For fields using large="true", large fields (which is what they are
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17648108#comment-17648108
]
Kevin Risden commented on SOLR-16589:
-
Before saying this ends up in Apache Lucene land - I see that
gabrielmagno commented on PR #1213:
URL: https://github.com/apache/solr/pull/1213#issuecomment-1353235629
Hey @epugh!
Yeah, at least from my side I think I have finished it.
Sorry for not making that more clear
By the way, sonatype complained about using lxml, but since we
epugh commented on PR #1213:
URL: https://github.com/apache/solr/pull/1213#issuecomment-1353225663
@gabrielmagno are you ready for me to review this PR? I was sort of
waiting till you gave me the all clear!
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Gibney reassigned SOLR-16589:
-
Assignee: Michael Gibney
> Large fields with large="true" can be truncated in v9+
>
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolas Osvalds updated SOLR-16589:
---
Description:
h3. Summary
For fields using large="true", large fields (which is what they
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolas Osvalds updated SOLR-16589:
---
Description:
h3. Summary
For fields using `large="true"`, large fields (which is what they
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolas Osvalds updated SOLR-16589:
---
Description:
h3. Summary
For fields using `large="true"`, large fields (which is what they
[
https://issues.apache.org/jira/browse/SOLR-16589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nikolas Osvalds updated SOLR-16589:
---
Description:
#
##
h3. Summary
For fields using `large="true"`, large fields (which is
Nikolas Osvalds created SOLR-16589:
--
Summary: Large fields with large="true" can be truncated in v9+
Key: SOLR-16589
URL: https://issues.apache.org/jira/browse/SOLR-16589
Project: Solr
raboof commented on code in PR #86:
URL: https://github.com/apache/solr-site/pull/86#discussion_r1049644651
##
vex-input.json:
##
@@ -0,0 +1,468 @@
+[
+ {
+"ids": [
+ "CVE-2022-33980"
+],
+"versions": "< 9.1",
+"jars": [
+
raboof commented on code in PR #86:
URL: https://github.com/apache/solr-site/pull/86#discussion_r1049644130
##
content/pages/security.md:
##
@@ -10,17 +10,42 @@ Every CVE that is detected by a software scanner is by
definition already public
To find a path forward in
raboof commented on code in PR #86:
URL: https://github.com/apache/solr-site/pull/86#discussion_r1049643505
##
content/pages/security.md:
##
@@ -10,17 +10,42 @@ Every CVE that is detected by a software scanner is by
definition already public
To find a path forward in
debe commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1352876178
Should we change the overflow cache to a Map in the mean time, to get this
PR going? what do you think?
chers, -dennis
--
This is an automated message from the Apache Git Service.
To
mpetris commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1352824165
Refactoring SolrCores with TransientCores support and SolrCores without
TransientCores support into separate implementations is really a good idea. +1
We would re-do our PR on the result
bruno-roustant commented on PR #1155:
URL: https://github.com/apache/solr/pull/1155#issuecomment-1352812182
+1 to extract the support of transient cores as a subclass of SolrCores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
72 matches
Mail list logo
