[GitHub] [solr] metapox opened a new pull request, #1274: fixed top_fc getSorted

2023-01-04 Thread GitBox
metapox opened a new pull request, #1274: URL: https://github.com/apache/solr/pull/1274 https://issues.apache.org/jira/browse/SOLR-X # Description Please provide a short description of the changes you're making with this pull request. # Solution Pl

[jira] [Created] (SOLR-16611) When there are no segments, using hint=top_fc in collapse results in NPE.

2023-01-04 Thread minami takuya (Jira)
minami takuya created SOLR-16611: Summary: When there are no segments, using hint=top_fc in collapse results in NPE. Key: SOLR-16611 URL: https://issues.apache.org/jira/browse/SOLR-16611 Project: Solr

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-04 Thread GitBox
noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1062117703 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: `SolrCores` is a concrete class . I'm against ma

[GitHub] [solr] dsmiley commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-04 Thread GitBox
dsmiley commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1062115144 ## solr/core/src/java/org/apache/solr/core/SolrCores.java: ## @@ -99,37 +85,34 @@ protected void close() { waitForLoadingCoresToFinish(30 * 1000); Collection cor

[jira] [Commented] (SOLR-16603) Create a public constructor for SolrCore

2023-01-04 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654701#comment-17654701 ] Shawn Heisey commented on SOLR-16603: - EmbeddedSolrServer is Solr without Jetty.  The

[GitHub] [solr] dsmiley commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-04 Thread GitBox
dsmiley commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r1061986196 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: I'm confused how I should satisfy the "clear defin

[GitHub] [solr] risdenk commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread GitBox
risdenk commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1371566317 https://docs.antora.org/antora-ui-default/copy-to-clipboard/#console-blocks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [solr] hiteshk25 commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
hiteshk25 commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061982849 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -465,7 +467,11 @@ public boolean isPerReplicaState() { } public PerReplicaStates ge

[GitHub] [solr] hiteshk25 commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
hiteshk25 commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061982253 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -488,4 +494,27 @@ public interface CollectionStateProps { String SHARDS = "shards";

[GitHub] [solr] epugh commented on pull request #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread GitBox
epugh commented on PR #1273: URL: https://github.com/apache/solr/pull/1273#issuecomment-1371549122 Ironically, from starting a journey to remove the `$` from all commands, now we would go the opposite direction and introduce them everywhere! Right now it's kind of a mish mash. -- This i

[GitHub] [solr] epugh opened a new pull request, #1273: SOLR-16610: Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread GitBox
epugh opened a new pull request, #1273: URL: https://github.com/apache/solr/pull/1273 https://issues.apache.org/jira/browse/SOLR-16610 # Description This is an example of the types of changes we would need to make to be more in line with Antora's handling of command lin

[GitHub] [solr] noblepaul commented on a diff in pull request #1243: SOLR-16591 Make SolrCores pluggable.

2023-01-04 Thread GitBox
noblepaul commented on code in PR #1243: URL: https://github.com/apache/solr/pull/1243#discussion_r106196 ## solr/core/src/test-files/solr/solr.xml: ## @@ -35,11 +35,6 @@ ${connTimeout:15000} - Review Comment: > There is no change of responsibilities here.

[GitHub] [solr] noblepaul commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
noblepaul commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061966859 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -465,7 +467,11 @@ public boolean isPerReplicaState() { } public PerReplicaStates ge

[GitHub] [solr] noblepaul commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
noblepaul commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061964993 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) { * only a r

[jira] [Commented] (SOLR-16536) Replace OpenTracing instrumentation with OpenTelemetry

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654669#comment-17654669 ] Jan Høydahl commented on SOLR-16536: According to [https://opentelemetry.io/docs/mig

[jira] [Updated] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16610: - Attachment: visual difference.png formatting differences.png > Support Copy n Paste of Co

[jira] [Updated] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16610: - Description: >From a discussion started in SOLR-16602, the suggestion is to remove $ from >the command l

[jira] [Updated] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16610: - Description: >From a discussion started in SOLR-16602, the suggestion is to remove $ from >the command l

[jira] [Updated] (SOLR-16610) Support Copy n Paste of Command Line commands in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16610: - Summary: Support Copy n Paste of Command Line commands in Ref Guide (was: Remove $ from command line exa

[GitHub] [solr] hiteshk25 commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
hiteshk25 commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061927938 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -465,7 +467,11 @@ public boolean isPerReplicaState() { } public PerReplicaStates ge

[jira] [Updated] (SOLR-16535) Remove jaegertracer-configurator module (main only)

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16535: --- Summary: Remove jaegertracer-configurator module (main only) (was: Remove jaegertracer-configurator

[jira] [Assigned] (SOLR-16534) Deprecate Jaegertracer-Configurator

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16534: -- Assignee: Jan Høydahl > Deprecate Jaegertracer-Configurator >

[jira] [Assigned] (SOLR-16535) Remove jaegertracer-configurator module (main only)

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reassigned SOLR-16535: -- Assignee: Jan Høydahl > Remove jaegertracer-configurator module (main only) >

[jira] [Resolved] (SOLR-16533) Add Jaeger exporter to the new otel module

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16533. Resolution: Won't Fix > Add Jaeger exporter to the new otel module > --

[GitHub] [solr] janhoy commented on a diff in pull request #1272: Solr 16535 Remove jaegertracer-configurator module in 10.0

2023-01-04 Thread GitBox
janhoy commented on code in PR #1272: URL: https://github.com/apache/solr/pull/1272#discussion_r1061919838 ## solr/solr-ref-guide/modules/deployment-guide/pages/cluster-node-management.adoc: ## @@ -852,9 +849,8 @@ http://localhost:8983/solr/admin/collections?action=OVERSEERSTAT

[GitHub] [solr] janhoy opened a new pull request, #1272: Solr 16535 Remove jaegertracer-configurator module in 10.0

2023-01-04 Thread GitBox
janhoy opened a new pull request, #1272: URL: https://github.com/apache/solr/pull/1272 https://issues.apache.org/jira/browse/SOLR-16535 The plan is to merge #1270 only to `branch_9x` and merge this only to `main`. That's why I included the 9.2 changes line for SOLR-16534 here as well.

[GitHub] [solr] risdenk commented on a diff in pull request #1271: fix-hadoop-openj9

2023-01-04 Thread GitBox
risdenk commented on code in PR #1271: URL: https://github.com/apache/solr/pull/1271#discussion_r1061917968 ## solr/modules/hdfs/src/test/org/apache/hadoop/util/PlatformName.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [solr] risdenk opened a new pull request, #1271: fix-hadoop-openj9

2023-01-04 Thread GitBox
risdenk opened a new pull request, #1271: URL: https://github.com/apache/solr/pull/1271 https://issues.apache.org/jira/browse/SOLR-X I'm looking into the Hadoop integration test failures on openj9 that are related to https://lists.apache.org/thread/b3053cvc2jqw768jrrw8npxkow4k70r6

[jira] [Commented] (SOLR-16533) Add Jaeger exporter to the new otel module

2023-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654656#comment-17654656 ] David Smiley commented on SOLR-16533: - Agreed; users can add whatever JARs they need.

[GitHub] [solr] dsmiley commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
dsmiley commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061895876 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/ClosableTracerShim.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (SOLR-16610) Remove $ from command line examples in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654650#comment-17654650 ] Eric Pugh commented on SOLR-16610: -- This page on Antora actually does what we want...

[GitHub] [solr] janhoy opened a new pull request, #1270: SOLR-16534 Deprecate Jaegertracer-Configurator

2023-01-04 Thread GitBox
janhoy opened a new pull request, #1270: URL: https://github.com/apache/solr/pull/1270 https://issues.apache.org/jira/browse/SOLR-16534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [solr] alessandrobenedetti commented on pull request #1255: SOLR-16588: set default knn algorithm

2023-01-04 Thread GitBox
alessandrobenedetti commented on PR #1255: URL: https://github.com/apache/solr/pull/1255#issuecomment-137195 thanks @risdenk ! All committed, adding the Changes.txt as soon as I know this is coming in 9.1.1! Cheers -- This is an automated message from the Apache Git Service. To res

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654648#comment-17654648 ] Kevin Risden commented on SOLR-16567: - [~abenedetti] looks like branch_9x is failing

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654645#comment-17654645 ] Alessandro Benedetti commented on SOLR-16567: - all done and merged, coming in

[jira] [Updated] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread Alessandro Benedetti (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alessandro Benedetti updated SOLR-16567: Fix Version/s: 9.1.1 > java.lang.StackOverflowError when combining KnnQParser and

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654643#comment-17654643 ] ASF subversion and git services commented on SOLR-16567: Commit d

[jira] [Commented] (SOLR-16533) Add Jaeger exporter to the new otel module

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654642#comment-17654642 ] Jan Høydahl commented on SOLR-16533: [~dsmiley] Perhaps we should just close this and

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654640#comment-17654640 ] ASF subversion and git services commented on SOLR-16567: Commit 3

[jira] [Updated] (SOLR-16532) New OpenTelemetry module with OTLP trace exporter

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16532: --- Summary: New OpenTelemetry module with OTLP trace exporter (was: New OTEL module with OTLP trace exp

[jira] [Resolved] (SOLR-16532) New OTEL module with OTLP trace exporter

2023-01-04 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16532. Fix Version/s: 9.2 Resolution: Fixed Thanks for review help everyone. Thrilled to have this

[jira] [Commented] (SOLR-16532) New OTEL module with OTLP trace exporter

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654638#comment-17654638 ] ASF subversion and git services commented on SOLR-16532: Commit 3

[GitHub] [solr] janhoy merged pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy merged PR #1168: URL: https://github.com/apache/solr/pull/1168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-16567) java.lang.StackOverflowError when combining KnnQParser and FunctionRangeQParser

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654637#comment-17654637 ] ASF subversion and git services commented on SOLR-16567: Commit 2

[GitHub] [solr] alessandrobenedetti merged pull request #1245: SOLR-16567: KnnQueryParser support for both pre-filters and post-filter

2023-01-04 Thread GitBox
alessandrobenedetti merged PR #1245: URL: https://github.com/apache/solr/pull/1245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@so

[GitHub] [solr] epugh merged pull request #1259: SOLR-16602: tweaks to package manager docs to make following along easier

2023-01-04 Thread GitBox
epugh merged PR #1259: URL: https://github.com/apache/solr/pull/1259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[GitHub] [solr] epugh commented on pull request #1259: SOLR-16602: tweaks to package manager docs to make following along easier

2023-01-04 Thread GitBox
epugh commented on PR #1259: URL: https://github.com/apache/solr/pull/1259#issuecomment-1371403744 > > I wish Antora would just automtically prefix any bash commands in the UI with a > > this isn't necessary. `$` is just a terminal prompt display thing. Its not necessary and my termi

[jira] [Created] (SOLR-16610) Remove $ from command line examples in Ref Guide

2023-01-04 Thread Eric Pugh (Jira)
Eric Pugh created SOLR-16610: Summary: Remove $ from command line examples in Ref Guide Key: SOLR-16610 URL: https://issues.apache.org/jira/browse/SOLR-16610 Project: Solr Issue Type: Improvement

[jira] [Resolved] (SOLR-14988) CoreContainer.getCores should should return transient cores that are loaded

2023-01-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-14988. - Resolution: Won't Fix > CoreContainer.getCores should should return transient cores that are load

[GitHub] [solr] dsmiley closed pull request #1235: SOLR-14988: Rename #getCores of CoreContainer and SolrCores to #getLoadedCores

2023-01-04 Thread GitBox
dsmiley closed pull request #1235: SOLR-14988: Rename #getCores of CoreContainer and SolrCores to #getLoadedCores URL: https://github.com/apache/solr/pull/1235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [solr] risdenk commented on a diff in pull request #1203: introduce org.cyclonedx.bom gradle plugin

2023-01-04 Thread GitBox
risdenk commented on code in PR #1203: URL: https://github.com/apache/solr/pull/1203#discussion_r1061863631 ## build.gradle: ## @@ -28,6 +28,19 @@ plugins { id "net.ltgt.errorprone" version "3.0.1" apply false id 'com.diffplug.spotless' version "6.5.2" apply false id 'c

[GitHub] [solr] risdenk commented on pull request #1259: SOLR-16602: tweaks to package manager docs to make following along easier

2023-01-04 Thread GitBox
risdenk commented on PR #1259: URL: https://github.com/apache/solr/pull/1259#issuecomment-1371392071 > I wish Antora would just automtically prefix any bash commands in the UI with a this isn't necessary. `$` is just a terminal prompt display thing. Its not necessary and my terminal

[jira] [Assigned] (SOLR-16588) solr.DenseVectorField fieldType without a knnAlgorithm parameter results in error

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-16588: --- Assignee: Alessandro Benedetti > solr.DenseVectorField fieldType without a knnAlgorithm para

[jira] [Commented] (SOLR-16588) solr.DenseVectorField fieldType without a knnAlgorithm parameter results in error

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654621#comment-17654621 ] Kevin Risden commented on SOLR-16588: - PR is being worked on here: https://github.com

[jira] [Updated] (SOLR-16588) solr.DenseVectorField fieldType without a knnAlgorithm parameter results in error

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16588: Status: Patch Available (was: Open) > solr.DenseVectorField fieldType without a knnAlgorithm param

[GitHub] [solr] risdenk commented on a diff in pull request #1255: Fix/solr 16588 set default knn algorithm

2023-01-04 Thread GitBox
risdenk commented on code in PR #1255: URL: https://github.com/apache/solr/pull/1255#discussion_r1061858513 ## solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java: ## @@ -124,18 +124,18 @@ public KnnVectorsFormat getKnnVectorsFormatForField(String field) {

[GitHub] [solr] risdenk commented on a diff in pull request #1239: SOLR-15787: Fix FileSystemConfigSetService test failure

2023-01-04 Thread GitBox
risdenk commented on code in PR #1239: URL: https://github.com/apache/solr/pull/1239#discussion_r1061851039 ## solr/core/src/java/org/apache/solr/core/FileSystemConfigSetService.java: ## @@ -238,9 +238,14 @@ public List getAllConfigFiles(String configName) throws IOException {

[GitHub] [solr] patsonluk commented on a diff in pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

2023-01-04 Thread GitBox
patsonluk commented on code in PR #1242: URL: https://github.com/apache/solr/pull/1242#discussion_r1061136542 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -139,30 +138,10 @@ public static String getCollectionPathRoot(String coll) { * only a r

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061842663 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061838234 ## versions.props: ## @@ -20,8 +20,10 @@ commons-codec:commons-codec=1.15 commons-collections:commons-collections=3.2.2 commons-io:commons-io=2.11.0 io.dropwizard.metri

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061837911 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061832334 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061828235 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreement

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061822568 ## versions.props: ## @@ -20,8 +20,10 @@ commons-codec:commons-codec=1.15 commons-collections:commons-collections=3.2.2 commons-io:commons-io=2.11.0 io.dropwizard.metric

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061819187 ## solr/solr-ref-guide/antora.yml: ## @@ -40,16 +40,17 @@ asciidoc: # 'patch-version' is the 'z' part of x.y.z semantic version page-solr-javadocs: 'https://solr.

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061818303 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061815367 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreement

[GitHub] [solr] janhoy commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061815367 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreement

[jira] [Commented] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654564#comment-17654564 ] Kevin Risden commented on SOLR-16607: - [~houston] yup - pretty sure we wouldn't since

[jira] [Commented] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654563#comment-17654563 ] ASF subversion and git services commented on SOLR-16607: Commit c

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Fix Version/s: 9.1.1 > org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle > lo

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Fix Version/s: (was: 9.2) > org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to han

[jira] [Commented] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654554#comment-17654554 ] Houston Putman commented on SOLR-16607: --- [~krisden] can we get this backported to 9

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Resolution: Fixed Status: Resolved (was: Patch Available) > org.apache.solr.security.hadoo

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Fix Version/s: 9.2 > org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle > loca

[jira] [Commented] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654530#comment-17654530 ] ASF subversion and git services commented on SOLR-16607: Commit 0

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Fix Version/s: main (10.0) > org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle

[jira] [Commented] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654522#comment-17654522 ] ASF subversion and git services commented on SOLR-16607: Commit 8

[GitHub] [solr] risdenk merged pull request #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread GitBox
risdenk merged PR #1269: URL: https://github.com/apache/solr/pull/1269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[jira] [Commented] (SOLR-16597) Give Solr executors a config option to use daemon threads

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654521#comment-17654521 ] Kevin Risden commented on SOLR-16597: - So I'm against this change. I didn't know why

[GitHub] [solr] risdenk commented on a diff in pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
risdenk commented on code in PR #1168: URL: https://github.com/apache/solr/pull/1168#discussion_r1061625026 ## solr/modules/opentelemetry/build.gradle: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreemen

[GitHub] [solr] risdenk commented on a diff in pull request #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread GitBox
risdenk commented on code in PR #1269: URL: https://github.com/apache/solr/pull/1269#discussion_r1061622621 ## solr/modules/hadoop-auth/src/test/org/apache/solr/security/hadoop/KerberosTestServices.java: ## @@ -198,10 +198,18 @@ public AppConfigurationEntry[] getAppConfiguratio

[GitHub] [solr] risdenk commented on a diff in pull request #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread GitBox
risdenk commented on code in PR #1269: URL: https://github.com/apache/solr/pull/1269#discussion_r1061620447 ## solr/modules/hadoop-auth/src/test/org/apache/solr/security/hadoop/KerberosTestServices.java: ## @@ -198,10 +198,18 @@ public AppConfigurationEntry[] getAppConfiguratio

[GitHub] [solr] janhoy commented on pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on PR #1168: URL: https://github.com/apache/solr/pull/1168#issuecomment-1371092716 I have now also tested locally, exporting to a local otel-collector, on both default grpc, port 4317 and with `OTEL_EXPORTER_OTLP_PROTOCOL=http/protobuf` on port 4318. Both works fine. If the

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread GitBox
HoustonPutman commented on code in PR #1269: URL: https://github.com/apache/solr/pull/1269#discussion_r1061617583 ## solr/modules/hadoop-auth/src/test/org/apache/solr/security/hadoop/KerberosTestServices.java: ## @@ -198,10 +198,18 @@ public AppConfigurationEntry[] getAppConfig

[jira] [Updated] (SOLR-16607) org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-16607: Status: Patch Available (was: Open) > org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs

[GitHub] [solr] risdenk opened a new pull request, #1269: SOLR-16607: org.apache.solr.security.hadoop.LocaleTest.testWithKdc needs to handle locales raj, bho, bgc added in JDK 20

2023-01-04 Thread GitBox
risdenk opened a new pull request, #1269: URL: https://github.com/apache/solr/pull/1269 https://issues.apache.org/jira/browse/SOLR-16607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [solr] gabrielmagno commented on pull request #1245: SOLR-16567: KnnQueryParser support for both pre-filters and post-filter

2023-01-04 Thread GitBox
gabrielmagno commented on PR #1245: URL: https://github.com/apache/solr/pull/1245#issuecomment-1370930774 Just to bring a "data-science KNN user" view on this. I think there is actually _two_ related but different ways one could use the Dense Vectors and KNN features. The first one is

[GitHub] [solr-operator] janhoy commented on issue #436: Limit default k8s role's access to collection API

2023-01-04 Thread GitBox
janhoy commented on issue #436: URL: https://github.com/apache/solr-operator/issues/436#issuecomment-1370875767 Once we release an operator that is >=solr9 then we could use pre-defined permission `collection-admin-read` instead of the custom permission. -- This is an automated message fr

[GitHub] [solr] janhoy commented on pull request #1168: SOLR-16532 New OTEL module with OTLP trace exporter

2023-01-04 Thread GitBox
janhoy commented on PR #1168: URL: https://github.com/apache/solr/pull/1168#issuecomment-1370609810 Opened a discussion here https://github.com/open-telemetry/opentelemetry-java/discussions/5079 to explore options. -- This is an automated message from the Apache Git Service. To respond t