[GitHub] [solr] mkhludnev merged pull request #1343: fix typo in comment (#1305)

2023-02-08 Thread via GitHub
mkhludnev merged PR #1343: URL: https://github.com/apache/solr/pull/1343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [solr] mkhludnev opened a new pull request, #1343: fix typo in comment (#1305)

2023-02-08 Thread via GitHub
mkhludnev opened a new pull request, #1343: URL: https://github.com/apache/solr/pull/1343 Co-authored-by: Renato Haeberli <> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (SOLR-16648) NullPointerException when using facets in More Like This Handler

2023-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-16648. - Resolution: Fixed > NullPointerException when using facets in More Like This Handler >

[jira] [Updated] (SOLR-16248) equals() & hashCode() impl of DocCollection does not consider PRS

2023-02-08 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Noble Paul updated SOLR-16248: -- Fix Version/s: 9.1 Resolution: Fixed Status: Resolved (was: Patch Available) >

[GitHub] [solr-operator] dependabot[bot] opened a new pull request, #522: Bump helm.sh/helm/v3 from 3.10.3 to 3.11.1

2023-02-08 Thread via GitHub
dependabot[bot] opened a new pull request, #522: URL: https://github.com/apache/solr-operator/pull/522 Bumps [helm.sh/helm/v3](https://github.com/helm/helm) from 3.10.3 to 3.11.1. Release notes Sourced from https://github.com/helm/helm/releases;>helm.sh/helm/v3's releases.

[GitHub] [solr] epugh commented on a diff in pull request #1341: SOLR-16623:SolrClientTestRule for JettySolrRunner

2023-02-08 Thread via GitHub
epugh commented on code in PR #1341: URL: https://github.com/apache/solr/pull/1341#discussion_r1100742588 ## solr/core/src/test/org/apache/solr/schema/TestBinaryField.java: ## @@ -65,14 +60,14 @@ public static void beforeTest() throws Exception { new File(src_dir,

[GitHub] [solr] magibney commented on a diff in pull request #1302: SOLR-16628: Ensure that InputStreams are closed after Xml parsing

2023-02-08 Thread via GitHub
magibney commented on code in PR #1302: URL: https://github.com/apache/solr/pull/1302#discussion_r1100712374 ## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ## @@ -197,89 +200,99 @@ public ManagedIndexSchema create( this.config = config;

[GitHub] [solr] dsmiley commented on a diff in pull request #1302: SOLR-16628: Ensure that InputStreams are closed after Xml parsing

2023-02-08 Thread via GitHub
dsmiley commented on code in PR #1302: URL: https://github.com/apache/solr/pull/1302#discussion_r1100587425 ## solr/core/src/java/org/apache/solr/schema/ManagedIndexSchemaFactory.java: ## @@ -197,89 +200,99 @@ public ManagedIndexSchema create( this.config = config;

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686073#comment-17686073 ] Houston Putman commented on SOLR-16531: --- Thanks for the link, it looks like the 2 big winners

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686057#comment-17686057 ] Jason Gerlowski commented on SOLR-16531: Hey, great news! bq. it is difficult to exactly

[GitHub] [solr] dsmiley commented on pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-08 Thread via GitHub
dsmiley commented on PR #1342: URL: https://github.com/apache/solr/pull/1342#issuecomment-1423084699 > Not adding CHANGES line since none of this is yet released. But this change isn't restricted to OTEL; any tracer plugin would get these new tags. Any way, it's fine with me. --

[jira] [Comment Edited] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686051#comment-17686051 ] Ishan Chattopadhyaya edited comment on SOLR-16531 at 2/8/23 6:44 PM: -

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686051#comment-17686051 ] Ishan Chattopadhyaya commented on SOLR-16531: - bq. Is there an interactive thing that says

[GitHub] [solr] HoustonPutman commented on pull request #1317: SOLR-16639: Fix solr-exporter parse error of node_thread_pool_completed_total

2023-02-08 Thread via GitHub
HoustonPutman commented on PR #1317: URL: https://github.com/apache/solr/pull/1317#issuecomment-1423056660 @chlorochrule could you add a CHANGES.txt entry? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686031#comment-17686031 ] Houston Putman commented on SOLR-16531: --- So from what I can see, the big performance gain didn't

[jira] [Commented] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-02-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686027#comment-17686027 ] Kevin Risden commented on SOLR-16649: - Looks good - didn't try running check or anything. >

[jira] [Comment Edited] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686017#comment-17686017 ] Ishan Chattopadhyaya edited comment on SOLR-16531 at 2/8/23 6:14 PM: -

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-08 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686025#comment-17686025 ] Kevin Risden commented on SOLR-16457: - Yea that looks reasonable. We need to pass both variants since

[jira] [Resolved] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya resolved SOLR-16531. - Resolution: Fixed Thanks a lot to [~gerlowskija] for his work on fixing the

[jira] [Commented] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686017#comment-17686017 ] Ishan Chattopadhyaya commented on SOLR-16531: - !Screenshot from 2023-02-08

[jira] [Updated] (SOLR-16531) Performance degradation due to introduction of JAX-RS

2023-02-08 Thread Ishan Chattopadhyaya (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ishan Chattopadhyaya updated SOLR-16531: Attachment: Screenshot from 2023-02-08 23-31-18.png > Performance degradation due

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2023-02-08 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685963#comment-17685963 ] Shawn Heisey commented on SOLR-16466: - {quote}So, if I'm understanding the rationale here correctly,

[jira] [Commented] (SOLR-16248) equals() & hashCode() impl of DocCollection does not consider PRS

2023-02-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685955#comment-17685955 ] Jason Gerlowski commented on SOLR-16248: Ping [~noble.paul] - can this be resolved? > equals() &

[jira] [Commented] (SOLR-16479) Support for `repository` parameter in v2 api for restores

2023-02-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685942#comment-17685942 ] Jason Gerlowski commented on SOLR-16479: Good catch Josh, thanks for calling this out! > Support

[GitHub] [solr] risdenk commented on a diff in pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-08 Thread via GitHub
risdenk commented on code in PR #1342: URL: https://github.com/apache/solr/pull/1342#discussion_r1100269587 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -310,7 +310,11 @@ protected static Span buildSpan(Tracer tracer, HttpServletRequest request) {

[GitHub] [solr] risdenk commented on a diff in pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-08 Thread via GitHub
risdenk commented on code in PR #1342: URL: https://github.com/apache/solr/pull/1342#discussion_r1100267843 ## solr/core/src/java/org/apache/solr/servlet/ServletUtils.java: ## @@ -310,7 +310,11 @@ protected static Span buildSpan(Tracer tracer, HttpServletRequest request) {

[jira] [Commented] (SOLR-16466) Admin UI - Make it optional to sort list of commandline args

2023-02-08 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685931#comment-17685931 ] Jason Gerlowski commented on SOLR-16466: bq. Sorting them, while it does make it easier to see if

[jira] [Commented] (SOLR-16608) Enable ability to compress state.json in Zookeeper

2023-02-08 Thread Justin Sweeney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685891#comment-17685891 ] Justin Sweeney commented on SOLR-16608: --- I'm planning an additional PR as part of this ticket to

[jira] [Updated] (SOLR-16648) NullPointerException when using facets in More Like This Handler

2023-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev updated SOLR-16648: Fix Version/s: 9.2 > NullPointerException when using facets in More Like This Handler >

[jira] [Assigned] (SOLR-16648) NullPointerException when using facets in More Like This Handler

2023-02-08 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev reassigned SOLR-16648: --- Assignee: Mikhail Khludnev > NullPointerException when using facets in More Like

[jira] [Commented] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685873#comment-17685873 ] ASF subversion and git services commented on SOLR-16636: Commit

[jira] [Commented] (SOLR-16636) ZkStateReader.waitForState should not register a watch if state already matches predicate

2023-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685872#comment-17685872 ] ASF subversion and git services commented on SOLR-16636: Commit

[GitHub] [solr] janhoy commented on pull request #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-08 Thread via GitHub
janhoy commented on PR #1342: URL: https://github.com/apache/solr/pull/1342#issuecomment-1422456775 Not adding CHANGES line since none of this is yet released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [solr] janhoy opened a new pull request, #1342: SOLR-16650, SOLR-16532: OTEL tracer additional tags

2023-02-08 Thread via GitHub
janhoy opened a new pull request, #1342: URL: https://github.com/apache/solr/pull/1342 https://issues.apache.org/jira/browse/SOLR-16650 https://issues.apache.org/jira/browse/SOLR-16532 Testing solr 9.2.0-SNAPSHOT at a client and missing hostname/port from traces. So this PR will

[jira] [Created] (SOLR-16650) OTEL tracer additional tags

2023-02-08 Thread Jira
Jan Høydahl created SOLR-16650: -- Summary: OTEL tracer additional tags Key: SOLR-16650 URL: https://issues.apache.org/jira/browse/SOLR-16650 Project: Solr Issue Type: Improvement Security

[jira] [Commented] (SOLR-16457) solr.data.home should not be set to empty string in bin/solr

2023-02-08 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685792#comment-17685792 ] Jan Høydahl commented on SOLR-16457: I found {{pwd -L}} that will give the symlink path. I belive it

[jira] [Commented] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-02-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685747#comment-17685747 ] Andrzej Bialecki commented on SOLR-16649: - Oops, right - I attached the new patch. >

[jira] [Updated] (SOLR-16649) Http2SolrClient.processErrorsAndResponse uses wrong instance of ResponseParser

2023-02-08 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-16649: Attachment: SOLR-16649-1.patch > Http2SolrClient.processErrorsAndResponse uses wrong