[
https://issues.apache.org/jira/browse/SOLR-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696497#comment-17696497
]
Erick Erickson commented on SOLR-8238:
--
"Me or one of my esteemed colleagues is likely to re-open
dsmiley commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1454899402
Thanks Rob for chiming in.
Made two commits.
I looked at the ComplexPhraseQParser test and I don't think we should bend
over backwards to support `hl.usePhraseHighlighter=false`,
dsmiley commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1454898195
Made two commits.
I looked at the ComplexPhraseQParser changes and I don't think we should
bend over backwards to support hl.usePhraseHighlighter=false, which is what the
failing test
rmuir commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1454886054
Creating this MultiTerms doesn't really do anything. It doesn't do any IO or
anything like that. It essentially makes a list of reader.terms() for each
segment. It doesn't sort this list or
dsmiley commented on PR #1360:
URL: https://github.com/apache/solr/pull/1360#issuecomment-1454873263
I'll be sad to see the Terms caching go in SlowCompositeReaderWrapper but
maybe it has to be this way. Although I added the test of this, removed here,
the underlying caching pre-dated me
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1454711385
I've made a new PR introducing both options:
https://github.com/apache/solr/pull/1431 - could you give that a review please?
(It felt cleaner to raise a new PR, though now I'm
[
https://issues.apache.org/jira/browse/SOLR-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Webb updated SOLR-16643:
-
Description:
I noticed the ReRank query parser adds the score from the {{reRankQuery}} to
the original
[
https://issues.apache.org/jira/browse/SOLR-16643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy Webb updated SOLR-16643:
-
Summary: Add multiply/replace options to ReRank query parser (was: Add
multiplying boost option to
vinayakphegde commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125445848
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory,
andywebb1975 opened a new pull request, #1431:
URL: https://github.com/apache/solr/pull/1431
https://issues.apache.org/jira/browse/SOLR-16643
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125444982
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext
mkhludnev commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1454685739
Congratulations, @andywebb1975!
Pushing both altogether makes more sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
andywebb1975 commented on PR #1324:
URL: https://github.com/apache/solr/pull/1324#issuecomment-1454682268
I have committer rights now - a massive thank you if you were involved in
arranging this!
I'm wondering whether to merge this as-is, or supersede it with a version
including a
uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125416874
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext
uschindler commented on code in PR #1360:
URL: https://github.com/apache/solr/pull/1360#discussion_r1125416518
##
solr/core/src/java/org/apache/solr/core/MMapDirectoryFactory.java:
##
@@ -63,7 +63,7 @@ protected Directory create(String path, LockFactory
lockFactory, DirContext
[
https://issues.apache.org/jira/browse/SOLR-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17696417#comment-17696417
]
ASF subversion and git services commented on SOLR-16585:
Commit
mkhludnev merged PR #1430:
URL: https://github.com/apache/solr/pull/1430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
17 matches
Mail list logo
