[
https://issues.apache.org/jira/browse/SOLR-16705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710391#comment-17710391
]
ASF subversion and git services commented on SOLR-16705:
Commit
murblanc merged PR #1465:
URL: https://github.com/apache/solr/pull/1465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dsmiley commented on code in PR #1504:
URL: https://github.com/apache/solr/pull/1504#discussion_r1162183932
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -331,7 +342,7 @@ protected boolean versionAdd(AddUpdateCommand cmd) throws
stillalex commented on PR #1504:
URL: https://github.com/apache/solr/pull/1504#issuecomment-1502421101
> Where is this in the PR? I at least like the sound of it :-)
you can find the logic here, basically not leader logic and zero version
will trigger an exception:
[
https://issues.apache.org/jira/browse/SOLR-16742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710340#comment-17710340
]
Houston Putman commented on SOLR-16742:
---
I decided to add back in the examples, because they do
[
https://issues.apache.org/jira/browse/SOLR-16742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-16742:
--
Description:
In addition to the solr-.tgz that contains all Solr binaries, include
a release
dsmiley commented on code in PR #1504:
URL: https://github.com/apache/solr/pull/1504#discussion_r1162098045
##
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java:
##
@@ -331,7 +342,7 @@ protected boolean versionAdd(AddUpdateCommand cmd) throws
markrmiller merged PR #53:
URL: https://github.com/apache/solr-sandbox/pull/53
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710285#comment-17710285
]
Jan Høydahl commented on SOLR-16739:
{quote}I think we should get rid of both of these, and adopt
markrmiller commented on code in PR #53:
URL: https://github.com/apache/solr-sandbox/pull/53#discussion_r1161995956
##
crossdc-producer/src/test/java/org/apache/solr/crossdc/SolrAndKafkaIntegrationTest.java:
##
@@ -64,19 +62,24 @@
protected static volatile
noblepaul merged PR #1553:
URL: https://github.com/apache/solr/pull/1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
risdenk commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1161962963
##
solr/core/src/java/org/apache/solr/util/SolrCLI.java:
##
@@ -804,6 +804,7 @@ public List getOptions() {
protected void runImpl(CommandLine cli) throws Exception {
dsmiley commented on code in PR #1182:
URL: https://github.com/apache/solr/pull/1182#discussion_r1161954013
##
solr/core/src/test/org/apache/solr/util/ApiToolTest.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
epugh commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1502102973
@bszabo97 I hope it's okay, I pushed up a fix, though I don't know that how
I fixed it was the best way.. Would your thoughts on if there is a cleaner way
;-)
--
This is an automated
[
https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710242#comment-17710242
]
Kevin Risden commented on SOLR-16240:
-
[~jrballesteros05] thanks for the report and being persistent
[
https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman resolved SOLR-16240.
---
Fix Version/s: 9.3
9.2.1
Assignee: Houston Putman
[
https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710237#comment-17710237
]
ASF subversion and git services commented on SOLR-16240:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710236#comment-17710236
]
ASF subversion and git services commented on SOLR-16240:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710234#comment-17710234
]
ASF subversion and git services commented on SOLR-16240:
Commit
HoustonPutman merged PR #1546:
URL: https://github.com/apache/solr/pull/1546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
markrmiller commented on PR #53:
URL: https://github.com/apache/solr-sandbox/pull/53#issuecomment-1502064759
There is still one test issue that seems to perhaps be environment issue
related, but I'm going to put this in for now and will continue to look into
that.
--
This is an
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710232#comment-17710232
]
Ishan Chattopadhyaya edited comment on SOLR-16739 at 4/10/23 5:00 PM:
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710232#comment-17710232
]
Ishan Chattopadhyaya commented on SOLR-16739:
-
[Off-topic]
bq. 42M ./gcs-repository
bq.
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710224#comment-17710224
]
Ishan Chattopadhyaya commented on SOLR-16739:
-
bq. However, we should not stop adding
janhoy commented on PR #1546:
URL: https://github.com/apache/solr/pull/1546#issuecomment-1502047760
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
HoustonPutman commented on PR #1546:
URL: https://github.com/apache/solr/pull/1546#issuecomment-1502046302
@janhoy added an integration test, which seems to work as expected, and
fails when I remove the line that fixes this PR. Let me know if it looks good
to you.
--
This is an
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710221#comment-17710221
]
Houston Putman commented on SOLR-16739:
---
Completely agreed [~janhoy] , started SOLR-16742 to get
epugh commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1502044312
Okay, it looks like the reason that the `SQL Module` test is failing is that
the we need now to use `%20` instead of `+` for the spaces in the url...
```
@@ -32,7 +32,7 @@ teardown()
HoustonPutman opened a new pull request, #1556:
URL: https://github.com/apache/solr/pull/1556
https://issues.apache.org/jira/browse/SOLR-16742
Things to do:
- [ ] Add a slim binary image when packaging.
All packaging commands should work with `slim` and `full`,
[
https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710217#comment-17710217
]
ASF subversion and git services commented on SOLR-16721:
Commit
Houston Putman created SOLR-16742:
-
Summary: Provide a slim Solr binary release
Key: SOLR-16742
URL: https://issues.apache.org/jira/browse/SOLR-16742
Project: Solr
Issue Type: Improvement
sonatype-lift[bot] commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161872783
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -102,6 +104,13 @@ def update_changes(filename, version, changes_lines):
epugh commented on PR #1182:
URL: https://github.com/apache/solr/pull/1182#issuecomment-1502024753
I ran `./gradlew integrationTests` on both `main` and this branch. They all
pass on main. on this branch I get these two failures:
```
not ok 30 SQL Module
not ok 34 start solr
[
https://issues.apache.org/jira/browse/SOLR-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16721:
---
Fix Version/s: 9.2.1
> Java version detection fails when `_JAVA_OPTIONS` is set
>
[
https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710209#comment-17710209
]
ASF subversion and git services commented on SOLR-16649:
Commit
gerlowskija commented on PR #1471:
URL: https://github.com/apache/solr/pull/1471#issuecomment-1502011763
New unit tests and other tweaks look great! We're just down to the docs at
this point I think.
> It may be worth adding the API docs to collection-management.adoc like you
[
https://issues.apache.org/jira/browse/SOLR-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-16649:
---
Fix Version/s: 9.2.1
> Http2SolrClient.processErrorsAndResponse uses wrong instance of
gerlowskija commented on code in PR #1471:
URL: https://github.com/apache/solr/pull/1471#discussion_r1161841669
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -1764,96 +1767,55 @@ public Map execute(
(req, rsp, h) -> {
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-16714.
Fix Version/s: 9.2.1
Resolution: Fixed
> ReleaseWizard to add dependency upgrades to
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710202#comment-17710202
]
ASF subversion and git services commented on SOLR-16714:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710200#comment-17710200
]
ASF subversion and git services commented on SOLR-16714:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710199#comment-17710199
]
ASF subversion and git services commented on SOLR-16714:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710198#comment-17710198
]
Jan Høydahl commented on SOLR-16739:
+1 for a kubernetes module. Nice win!
Also agree that we should
janhoy merged PR #1552:
URL: https://github.com/apache/solr/pull/1552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gerlowskija commented on code in PR #1471:
URL: https://github.com/apache/solr/pull/1471#discussion_r1161841669
##
solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java:
##
@@ -1764,96 +1767,55 @@ public Map execute(
(req, rsp, h) -> {
[
https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710191#comment-17710191
]
Eric Pugh commented on SOLR-16563:
--
I am unassigning myself from this ticket as I don't have a strong
[
https://issues.apache.org/jira/browse/SOLR-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-16563:
Assignee: (was: Eric Pugh)
> Http2SolrClient should have a defaultCollection setting
>
janhoy commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161831927
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -102,6 +104,11 @@ def update_changes(filename, version, changes_lines):
buffer.append(change_line)
sonatype-lift[bot] commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161815749
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -124,8 +125,11 @@ def main():
gitlog_lines = run(
'git log --author=' + newconf.user + '
janhoy commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161815684
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -124,8 +125,11 @@ def main():
gitlog_lines = run(
'git log --author=' + newconf.user + ' --oneline
janhoy commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161815414
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -124,8 +125,11 @@ def main():
gitlog_lines = run(
'git log --author=' + newconf.user + ' --oneline
sonatype-lift[bot] commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161815482
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -124,8 +125,11 @@ def main():
gitlog_lines = run(
'git log --author=' + newconf.user + '
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710184#comment-17710184
]
Ishan Chattopadhyaya commented on SOLR-16739:
-
bq. 32M ./kubernetes
Ouch.
bq. If we are
janhoy merged PR #1554:
URL: https://github.com/apache/solr/pull/1554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
janhoy merged PR #1555:
URL: https://github.com/apache/solr/pull/1555
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gerlowskija commented on code in PR #1471:
URL: https://github.com/apache/solr/pull/1471#discussion_r1161798594
##
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCollectionSnapshotAPI.java:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation
gerlowskija commented on code in PR #1471:
URL: https://github.com/apache/solr/pull/1471#discussion_r1161791770
##
solr/core/src/java/org/apache/solr/handler/admin/api/CreateCollectionSnapshotAPI.java:
##
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710178#comment-17710178
]
Houston Putman commented on SOLR-16739:
---
This would be shipped just like the s3-repository, or
janhoy opened a new pull request, #1555:
URL: https://github.com/apache/solr/pull/1555
Backport to `branch_9_2`
Fewer CVEs in various dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
janhoy opened a new pull request, #1554:
URL: https://github.com/apache/solr/pull/1554
Backport from `branch_9x` to `branch_9_2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
gerlowskija commented on code in PR #53:
URL: https://github.com/apache/solr-sandbox/pull/53#discussion_r1161731667
##
SolrAndKafkaIntegrationTest.java:
##
@@ -0,0 +1,335 @@
+package org.apache.solr.crossdc;
Review Comment:
[Q] I'm assuming this is just a temp file you
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710145#comment-17710145
]
Ishan Chattopadhyaya commented on SOLR-16739:
-
bq. to be clear, under the
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710144#comment-17710144
]
Ishan Chattopadhyaya commented on SOLR-16739:
-
Sounds good. Thanks for addressing my fears
HoustonPutman commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161733279
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -102,6 +104,11 @@ def update_changes(filename, version, changes_lines):
sonatype-lift[bot] commented on code in PR #1552:
URL: https://github.com/apache/solr/pull/1552#discussion_r1161727202
##
dev-tools/scripts/addDepsToChanges.py:
##
@@ -124,8 +125,11 @@ def main():
gitlog_lines = run(
'git log --author=' + newconf.user + '
[
https://issues.apache.org/jira/browse/SOLR-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710138#comment-17710138
]
Houston Putman commented on SOLR-16739:
---
This wouldn't go in solr core, it would go into a new Solr
HoustonPutman commented on code in PR #540:
URL: https://github.com/apache/solr-operator/pull/540#discussion_r1161718687
##
helm/solr/templates/solrcloud.yaml:
##
@@ -108,6 +108,12 @@ spec:
{{- end }}
{{- end }}
+ {{- if and (.Values.availability)
janhoy opened a new pull request, #1552:
URL: https://github.com/apache/solr/pull/1552
https://issues.apache.org/jira/browse/SOLR-16714
After committing, I did a test on branch_9_2 and discovered a bug when list
of solrbot changes was empty. This will detect not changes and exit
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710122#comment-17710122
]
ASF subversion and git services commented on SOLR-16714:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710123#comment-17710123
]
ASF subversion and git services commented on SOLR-16714:
Commit
[
https://issues.apache.org/jira/browse/SOLR-16714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17710121#comment-17710121
]
ASF subversion and git services commented on SOLR-16714:
Commit
janhoy merged PR #1483:
URL: https://github.com/apache/solr/pull/1483
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gerlowskija commented on code in PR #540:
URL: https://github.com/apache/solr-operator/pull/540#discussion_r1161646201
##
helm/solr/templates/solrcloud.yaml:
##
@@ -108,6 +108,12 @@ spec:
{{- end }}
{{- end }}
+ {{- if and (.Values.availability)
73 matches
Mail list logo
