[GitHub] [solr] stillalex commented on pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
stillalex commented on PR #1565: URL: https://github.com/apache/solr/pull/1565#issuecomment-1524484701 @epugh I can't push to your branch directly, so I forked it to my own repo and pushed there. please take a look at https://github.com/stillalex/solr/commit/aa6ff0d6ec8982d8bd32d668fea478b

[jira] [Created] (SOLR-16773) UI: Cloud>NOdes screen can't display disk usage from replicas using non-standard core names (ie: implicit router)

2023-04-26 Thread Chris M. Hostetter (Jira)
Chris M. Hostetter created SOLR-16773: - Summary: UI: Cloud>NOdes screen can't display disk usage from replicas using non-standard core names (ie: implicit router) Key: SOLR-16773 URL: https://issues.apache.org

[jira] [Resolved] (SOLR-16719) Let AffinityPlacementFactory have a spread_domain label

2023-04-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-16719. -- Fix Version/s: main (10.0) 9.3 Resolut

[jira] [Updated] (SOLR-16719) Let AffinityPlacementFactory have a spread_domain label

2023-04-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16719: - Summary: Let AffinityPlacementFactory have a spread_domain label

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2023-04-26 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716928#comment-17716928 ] Matthew Biscocho commented on SOLR-16470: - Interested in picking this up and cont

[jira] [Commented] (SOLR-16719) Let AffinityPlacementFactory have an anti-affinity label

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716907#comment-17716907 ] ASF subversion and git services commented on SOLR-16719: Commit f

[jira] [Commented] (SOLR-16719) Let AffinityPlacementFactory have an anti-affinity label

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716892#comment-17716892 ] ASF subversion and git services commented on SOLR-16719: Commit 2

[GitHub] [solr] tflobbe merged pull request #1577: SOLR-16719: Let AffinityPlacementFactory have a spread_domain label

2023-04-26 Thread via GitHub
tflobbe merged PR #1577: URL: https://github.com/apache/solr/pull/1577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] epugh commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
epugh commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178224029 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -168,6 +168,12 @@ protected HttpSolrClient(Builder builder) { this.internalClient

[GitHub] [solr] epugh commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
epugh commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178220595 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderTest.java: ## @@ -51,6 +52,22 @@ public void testProvidesHttpClientToClient() throws IOExcepti

[GitHub] [solr] epugh commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
epugh commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178220595 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderTest.java: ## @@ -51,6 +52,22 @@ public void testProvidesHttpClientToClient() throws IOExcepti

[GitHub] [solr] stillalex commented on pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
stillalex commented on PR #1565: URL: https://github.com/apache/solr/pull/1565#issuecomment-1523830570 sure @epugh will try to push something later today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Resolved] (SOLR-16737) SOLR 9.2.0 cluster basic authentication with http2 solr client

2023-04-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe resolved SOLR-16737. -- Fix Version/s: main (10.0) 9.3 Resolut

[jira] [Updated] (SOLR-16737) SOLR 9.2.0 cluster basic authentication with http2 solr client

2023-04-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe updated SOLR-16737: - Affects Version/s: (was: 9.2) > SOLR 9.2.0 cluster basic auth

[jira] [Assigned] (SOLR-16737) SOLR 9.2.0 cluster basic authentication with http2 solr client

2023-04-26 Thread Tomas Eduardo Fernandez Lobbe (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomas Eduardo Fernandez Lobbe reassigned SOLR-16737: Assignee: Tomas Eduardo Fernandez Lobbe > SOLR 9.2.0 clust

[jira] [Commented] (SOLR-16737) SOLR 9.2.0 cluster basic authentication with http2 solr client

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716839#comment-17716839 ] ASF subversion and git services commented on SOLR-16737: Commit b

[jira] [Commented] (SOLR-16392) Cosmetic improvements and migration to JAX-RS (shard, replica, and replicaprop CRUD APIs)

2023-04-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716833#comment-17716833 ] Jason Gerlowski commented on SOLR-16392: I started looking a little more closely

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have a spread_domain label

2023-04-26 Thread via GitHub
HoustonPutman commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1178191971 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +533,203 @@ private String getNodeAZ(Node n, final Attri

[GitHub] [solr] tflobbe commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have a spread_domain label

2023-04-26 Thread via GitHub
tflobbe commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1178189030 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -503,15 +533,203 @@ private String getNodeAZ(Node n, final AttributeVa

[GitHub] [solr] gerlowskija commented on pull request #1592: SOLR-16394: Tweak v2 restore-coll to be more REST-ful

2023-04-26 Thread via GitHub
gerlowskija commented on PR #1592: URL: https://github.com/apache/solr/pull/1592#issuecomment-1523765458 Excepting a few new tests added here, all of this code comes from a pre-existing PR: #1453 . Since the code has been available for review for several weeks there, I'll aim to merg

[GitHub] [solr] gerlowskija opened a new pull request, #1592: SOLR-16394: Tweak v2 restore-coll to be more REST-ful

2023-04-26 Thread via GitHub
gerlowskija opened a new pull request, #1592: URL: https://github.com/apache/solr/pull/1592 https://issues.apache.org/jira/browse/SOLR-16394 # Description Solr is currently making slow progress in moving its v2 APIs in a more REST-ful direction. Many APIs have been improved, bu

[jira] [Commented] (SOLR-16737) SOLR 9.2.0 cluster basic authentication with http2 solr client

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716815#comment-17716815 ] ASF subversion and git services commented on SOLR-16737: Commit 0

[GitHub] [solr] tflobbe merged pull request #1587: SOLR-16737 Http2SolrClient needs to inherit all properties when initialized with another http2 client

2023-04-26 Thread via GitHub
tflobbe merged PR #1587: URL: https://github.com/apache/solr/pull/1587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] stillalex commented on pull request #1587: SOLR-16737 Http2SolrClient needs to inherit all properties when initialized with another http2 client

2023-04-26 Thread via GitHub
stillalex commented on PR #1587: URL: https://github.com/apache/solr/pull/1587#issuecomment-1523735012 > @HoustonPutman , are you ok with the updated PR title? @tflobbe he added a 👍 to my comment, so I would take that as a yes? I fixed the merge conflicts too. we should be good to go

[GitHub] [solr] mlbiscoc commented on pull request #1588: SOLR-15083: prometheus-exporter incorrect metric namings

2023-04-26 Thread via GitHub
mlbiscoc commented on PR #1588: URL: https://github.com/apache/solr/pull/1588#issuecomment-1523686569 Looks like other check tests failed at LTR as well. For example this change that was only ref-doc change: https://github.com/apache/solr/actions/runs/4808042532/jobs/8558639488 -- This

[GitHub] [solr] stillalex commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
stillalex commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178102320 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderTest.java: ## @@ -51,6 +52,22 @@ public void testProvidesHttpClientToClient() throws IOExc

[GitHub] [solr] epugh commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
epugh commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178092451 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderTest.java: ## @@ -51,6 +52,22 @@ public void testProvidesHttpClientToClient() throws IOExcepti

[GitHub] [solr] epugh commented on pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
epugh commented on PR #1565: URL: https://github.com/apache/solr/pull/1565#issuecomment-1523655098 I like your ideas @stillalex, do you want to try and push up a change? (Not sure if there are any permissions issue?) -- This is an automated message from the Apache Git Service. To respon

[GitHub] [solr] stillalex commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
stillalex commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178050642 ## solr/solrj/src/test/org/apache/solr/client/solrj/impl/HttpSolrClientBuilderTest.java: ## @@ -51,6 +52,22 @@ public void testProvidesHttpClientToClient() throws IOExc

[GitHub] [solr-operator] HoustonPutman merged pull request #562: Use DeferCleanup() and a sharedZK in e2e tests

2023-04-26 Thread via GitHub
HoustonPutman merged PR #562: URL: https://github.com/apache/solr-operator/pull/562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

[jira] [Resolved] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)

2023-04-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-16468. Fix Version/s: 9.3 Resolution: Fixed > Create v2 equivalent of v1 'CREATESNAPSHOT',

[jira] [Commented] (SOLR-16468) Create v2 equivalent of v1 'CREATESNAPSHOT', 'LISTSNAPSHOT' and 'DELETESNAPSHOT' (collection level)

2023-04-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716775#comment-17716775 ] Jason Gerlowski commented on SOLR-16468: Alright, our snapshot tests continued to

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716774#comment-17716774 ] ASF subversion and git services commented on SOLR-16391: Commit 8

[jira] [Updated] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-04-26 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-16391: --- Description: As mentioned on SOLR-15781, the v2 API currently has an experimental designatio

[jira] [Commented] (SOLR-16391) Cosmetic improvements and migration to JAX-RS (collection, collection prop, core CRUD APIs)

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716772#comment-17716772 ] ASF subversion and git services commented on SOLR-16391: Commit 2

[jira] [Commented] (SOLR-15737) Ensure all (desired) v1 APIs have v2 equivalent

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716771#comment-17716771 ] ASF subversion and git services commented on SOLR-15737: Commit b

[GitHub] [solr] stillalex commented on a diff in pull request #1565: SOLR-13605: HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2023-04-26 Thread via GitHub
stillalex commented on code in PR #1565: URL: https://github.com/apache/solr/pull/1565#discussion_r1178026053 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java: ## @@ -168,6 +168,12 @@ protected HttpSolrClient(Builder builder) { this.internalCli

[jira] [Commented] (SOLR-16393) Cosmetic improvements and migration to JAX-RS (alias, alias-prop CRUD APIs)

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716764#comment-17716764 ] ASF subversion and git services commented on SOLR-16393: Commit 1

[GitHub] [solr] gerlowskija merged pull request #1590: SOLR-16393: Tweak v2 "create alias" API to be more REST-ful

2023-04-26 Thread via GitHub
gerlowskija merged PR #1590: URL: https://github.com/apache/solr/pull/1590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] HoustonPutman commented on pull request #1588: SOLR-15083: prometheus-exporter incorrect metric namings

2023-04-26 Thread via GitHub
HoustonPutman commented on PR #1588: URL: https://github.com/apache/solr/pull/1588#issuecomment-1523540931 > Is this still somehow related to my PR or a known issue? This does not seem to be a known issue, but also looking at the test I think its impossible for your change to have had

[GitHub] [solr] mlbiscoc commented on pull request #1588: SOLR-15083: prometheus-exporter incorrect metric namings

2023-04-26 Thread via GitHub
mlbiscoc commented on PR #1588: URL: https://github.com/apache/solr/pull/1588#issuecomment-1523525809 Solr Tests seem to be failing from LTR but run fine locally. Is this still somehow related to my PR or a known issue? `gradlew :solr:modules:ltr:test --tests "org.apache.solr.ltr.fea

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1577: SOLR-16719: Let AffinityPlacementFactory have an anti-affinity label

2023-04-26 Thread via GitHub
HoustonPutman commented on code in PR #1577: URL: https://github.com/apache/solr/pull/1577#discussion_r1177962847 ## solr/solr-ref-guide/modules/configuration-guide/pages/replica-placement-plugins.adoc: ## @@ -184,6 +192,24 @@ This property defines an additional constraint that

[GitHub] [solr-operator] iampranabroy commented on issue #471: How to prevent node rotation behavior from causing cluster instability

2023-04-26 Thread via GitHub
iampranabroy commented on issue #471: URL: https://github.com/apache/solr-operator/issues/471#issuecomment-1523499874 @joshsouza Please let me know if you try the new version and if it helps resolve the problem. We kind of have a similar scenario. Will give it a try ourselves soon and will

[jira] [Commented] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerReplicaStates param

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716712#comment-17716712 ] ASF subversion and git services commented on SOLR-16712: Commit 6

[jira] [Commented] (SOLR-16712) Simplify PerReplicaStates (PRS) logic in DocCollection, replace PrsSupplier with actual PerReplicaStates param

2023-04-26 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716711#comment-17716711 ] ASF subversion and git services commented on SOLR-16712: Commit 0

[GitHub] [solr] noblepaul merged pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-26 Thread via GitHub
noblepaul merged PR #1477: URL: https://github.com/apache/solr/pull/1477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[GitHub] [solr] noblepaul commented on a diff in pull request #1477: SOLR-16712: Simplify DocCollection ctor for PRS enabled collection

2023-04-26 Thread via GitHub
noblepaul commented on code in PR #1477: URL: https://github.com/apache/solr/pull/1477#discussion_r1150090351 ## solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java: ## @@ -146,6 +143,45 @@ public DocCollection( assert name != null && slices != null; }

[GitHub] [solr] skowront opened a new pull request, #1591: tutorial-aws.adoc link fix

2023-04-26 Thread via GitHub
skowront opened a new pull request, #1591: URL: https://github.com/apache/solr/pull/1591 The link in current form does not work. It needs "apache-" in front as visible below: This works: https://archive.apache.org/dist/zookeeper/zookeeper-3.8.1/ https://archive.apache.org/dist/zookeepe