[GitHub] [solr] solrbot opened a new pull request, #1746: Update org.mockito:mockito* to v5.4.0

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1746: URL: https://github.com/apache/solr/pull/1746 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.mockito:mockito-subclass](https://togithub.com/mockito/mockito) | test | minor | `5.3.1`

[GitHub] [solr] solrbot opened a new pull request, #1745: Update dependency com.google.cloud:google-cloud-bom to v0.198.0

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1745: URL: https://github.com/apache/solr/pull/1745 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [com.google.cloud:google-cloud-bom](https://togithub.com/googleapis/java-cloud-b

[GitHub] [solr] solrbot opened a new pull request, #1744: Update software.amazon.awssdk:* to v2.20.92

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1744: URL: https://github.com/apache/solr/pull/1744 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [software.amazon.awssdk:url-connection-client](https://aws.amazon.com/sdkforjava

[GitHub] [solr] solrbot opened a new pull request, #1743: Update org.apache.hadoop:* to v3.3.6

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1743: URL: https://github.com/apache/solr/pull/1743 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | org.apache.hadoop:hadoop-minikdc | test | patch | `3.3.5` -> `3.3.6` | | org.apache.hadoop:h

[GitHub] [solr] solrbot opened a new pull request, #1742: Update dependency org.hsqldb:hsqldb to v2.7.2

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1742: URL: https://github.com/apache/solr/pull/1742 This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.hsqldb:hsqldb](http://hsqldb.org) ([source](http://sourceforge.net/p/hsqldb/svn/HEAD)) |

[GitHub] [solr] solrbot opened a new pull request, #1741: Update dependency com.adobe.testing:s3mock-junit4 to v2.13.1

2023-06-30 Thread via GitHub
solrbot opened a new pull request, #1741: URL: https://github.com/apache/solr/pull/1741 This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [com.adobe.testing:s3mock-junit4](https://togithub.com/adobe/S3Mock) | test | pa

[GitHub] [solr] HoustonPutman commented on pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-30 Thread via GitHub
HoustonPutman commented on PR #1704: URL: https://github.com/apache/solr/pull/1704#issuecomment-1615259421 No worries, its annoying because that gradle validation only runs if it can tell its running in a Github Action or in Jenkins. So you can't tell locally. If you look at the check

[GitHub] [solr] mlbiscoc commented on pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-30 Thread via GitHub
mlbiscoc commented on PR #1704: URL: https://github.com/apache/solr/pull/1704#issuecomment-1615240500 > @gerlowskija, this broke precommit (for jenkins and github actions) https://github.com/apache/solr/actions/runs/5425690231/jobs/9866774872 Sorry about that. ```./gradlew check``` pa

[jira] [Commented] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2023-06-30 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739237#comment-17739237 ] Gus Heck commented on SOLR-16594: - I fiddled around with customizing solr to do this and

[GitHub] [solr] sonatype-lift[bot] commented on a diff in pull request #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-06-30 Thread via GitHub
sonatype-lift[bot] commented on code in PR #1740: URL: https://github.com/apache/solr/pull/1740#discussion_r1248254353 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [solr] HoustonPutman commented on pull request #1730: SOLR-16855: Add a MigrateReplicas API

2023-06-30 Thread via GitHub
HoustonPutman commented on PR #1730: URL: https://github.com/apache/solr/pull/1730#issuecomment-1615148566 I'll merge this early next week in case anyone wants to take a look at the new logic/data structures used for the orderedNodes placement stuff. -- This is an automated message from t

[GitHub] [solr] HoustonPutman commented on pull request #1730: SOLR-16855: Add a MigrateReplicas API

2023-06-30 Thread via GitHub
HoustonPutman commented on PR #1730: URL: https://github.com/apache/solr/pull/1730#issuecomment-1615147207 Ok the tests now pass (fixed a weird bug where splitShard can send a placementRequest with no actual replicas to add... but anyways) The "hacky" fix for tied-nodes, is now expand

[GitHub] [solr] HoustonPutman commented on pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-30 Thread via GitHub
HoustonPutman commented on PR #1704: URL: https://github.com/apache/solr/pull/1704#issuecomment-1615138862 @gerlowskija, this broke precommit (for jenkins and github actions) https://github.com/apache/solr/actions/runs/5425690231/jobs/9866774872 -- This is an automated message from the Ap

[GitHub] [solr] iamsanjay opened a new pull request, #1740: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-06-30 Thread via GitHub
iamsanjay opened a new pull request, #1740: URL: https://github.com/apache/solr/pull/1740 https://issues.apache.org/jira/browse/SOLR-16490 # Description Create a v2 equivalent for /admin/cores BACKUPCORE # Solution Created a new class BackupAPI.java, a

[GitHub] [solr] iamsanjay commented on a diff in pull request #1734: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-06-30 Thread via GitHub
iamsanjay commented on code in PR #1734: URL: https://github.com/apache/solr/pull/1734#discussion_r1248197799 ## solr/core/src/java/org/apache/solr/handler/admin/api/BackupCoreAPI.java: ## @@ -0,0 +1,179 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [solr] iamsanjay closed pull request #1734: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE

2023-06-30 Thread via GitHub
iamsanjay closed pull request #1734: SOLR-16490: Create a v2 equivalent for /admin/cores BACKUPCORE URL: https://github.com/apache/solr/pull/1734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (SOLR-16840) Fix overly verbose v2 API console logging

2023-06-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739217#comment-17739217 ] ASF subversion and git services commented on SOLR-16840: Commit 5

[GitHub] [solr] gerlowskija merged pull request #1726: SOLR-16840: Workaround HK2 DI bug

2023-06-30 Thread via GitHub
gerlowskija merged PR #1726: URL: https://github.com/apache/solr/pull/1726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] gerlowskija commented on pull request #1726: SOLR-16840: Workaround HK2 DI bug

2023-06-30 Thread via GitHub
gerlowskija commented on PR #1726: URL: https://github.com/apache/solr/pull/1726#issuecomment-1615076263 > are we behind on our version of Glassfish and HK2? No, we're not behind on hk2 - it's just a long standing bug I guess. I've added a comment as you guy suggested to we can use m

[GitHub] [solr] gerlowskija commented on pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-30 Thread via GitHub
gerlowskija commented on PR #1704: URL: https://github.com/apache/solr/pull/1704#issuecomment-1615002968 Merged - will target backporting next week if test runs over the weekend don't surface any issues. Thanks again @mlbiscoc! -- This is an automated message from the Apache Git Service

[jira] [Commented] (SOLR-16702) JMH benchmarks can fail with http2 when using many threads

2023-06-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739184#comment-17739184 ] ASF subversion and git services commented on SOLR-16702: Commit 4

[jira] [Commented] (SOLR-16702) JMH benchmarks can fail with http2 when using many threads

2023-06-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739181#comment-17739181 ] ASF subversion and git services commented on SOLR-16702: Commit 1

[GitHub] [solr] tflobbe merged pull request #1731: SOLR-16702 JMH benchmarks can fail with http2 when using many threads

2023-06-30 Thread via GitHub
tflobbe merged PR #1731: URL: https://github.com/apache/solr/pull/1731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or

[GitHub] [solr] tflobbe commented on pull request #1731: SOLR-16702 JMH benchmarks can fail with http2 when using many threads

2023-06-30 Thread via GitHub
tflobbe commented on PR #1731: URL: https://github.com/apache/solr/pull/1731#issuecomment-1614944656 Interestingly, I'm also not getting that many errors now, one every now and then, probably enough to make the test unreliable without the the `catch` added here -- This is an automated me

[jira] [Commented] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2023-06-30 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739174#comment-17739174 ] ASF subversion and git services commented on SOLR-16470: Commit 2

[GitHub] [solr] gerlowskija merged pull request #1704: SOLR-16470 : Create V2 equivalent of V1 Replication: GET files

2023-06-30 Thread via GitHub
gerlowskija merged PR #1704: URL: https://github.com/apache/solr/pull/1704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apach

[GitHub] [solr] madrob commented on pull request #1721: Add CodeQL workflow

2023-06-30 Thread via GitHub
madrob commented on PR #1721: URL: https://github.com/apache/solr/pull/1721#issuecomment-1614825677 @dsmiley I think this produces a different set of results than our other scanning tools. At least, it produces results that I have not personally reviewed before. It took a bit of work to fig

[GitHub] [solr] gerlowskija commented on pull request #1738: SOLR-15753: Ensure v2 API requests are logged

2023-06-30 Thread via GitHub
gerlowskija commented on PR #1738: URL: https://github.com/apache/solr/pull/1738#issuecomment-1614825404 > I am so thankful you are a wizard with the Jersey stuff Haha, thanks - but I swear I'm just one or two frantic google-searches ahead of everyone else haha! > would it be p

[GitHub] [solr] jorgectf commented on a diff in pull request #1721: Add CodeQL workflow

2023-06-30 Thread via GitHub
jorgectf commented on code in PR #1721: URL: https://github.com/apache/solr/pull/1721#discussion_r1247999847 ## .github/workflows/codeql.yml: ## @@ -0,0 +1,66 @@ +name: "CodeQL" + +on: + push: +branches: [ 'main' ] + pull_request: +# The branches below must be a subset

[GitHub] [solr] jorgectf commented on pull request #1721: Add CodeQL workflow

2023-06-30 Thread via GitHub
jorgectf commented on PR #1721: URL: https://github.com/apache/solr/pull/1721#issuecomment-1614818391 @madrob > 1. We need to be able to exclude certain paths. For example, I don't think we're interested in the javascript scan results for `solr/webapp/web/libs/*` as that is all third par

[jira] [Updated] (SOLR-16858) Allow KnnQParser to selectively apply filters

2023-06-30 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-16858: -- Description: The KnnQParser is parsing the filter query which limits the rows considered by th

[GitHub] [solr] Willdotwhite commented on pull request #1670: SOLR-16829: Delegate arg parsing and help usage to java. (Round 1)

2023-06-30 Thread via GitHub
Willdotwhite commented on PR #1670: URL: https://github.com/apache/solr/pull/1670#issuecomment-1614280342 > okay @Willdotwhite I had to restore a change to `StatusTool.java` to make it work on Unix.. Is it possible that we have the .cmd and the .sh somewhat working at cross purposes in how