[GitHub] [solr] jrhenderson1988 commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

2023-08-13 Thread via GitHub
jrhenderson1988 commented on PR #1837: URL: https://github.com/apache/solr/pull/1837#issuecomment-1676457599 Sounds good! Let me know if there's anything you need from me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [solr] janhoy commented on a diff in pull request #1792: add support of OAuth 2.0/OIDC 'code with PKCE' flow (back-end)

2023-08-13 Thread via GitHub
janhoy commented on code in PR #1792: URL: https://github.com/apache/solr/pull/1792#discussion_r1292849716 ## solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java: ## @@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String authori

[GitHub] [solr] mkhludnev commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

2023-08-13 Thread via GitHub
mkhludnev commented on PR #1837: URL: https://github.com/apache/solr/pull/1837#issuecomment-1676446514 Thanks, Jonathon. I'm for merging and picking it into 9, without mention in CHANGES. I'm taking a pause for a while to check if there's an alternative opinion. -- This is an automated

[GitHub] [solr] jrhenderson1988 commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

2023-08-13 Thread via GitHub
jrhenderson1988 commented on PR #1837: URL: https://github.com/apache/solr/pull/1837#issuecomment-1676406483 @mkhludnev Thanks for kicking off again. Looks to have passed this time. > I think, we might not mention it in CHANGES.txt. WDYT? I'm not sure that I understand. Would yo

[GitHub] [solr] janhoy commented on a diff in pull request #1791: add support of OAuth 2.0/OIDC 'code with PKCE' flow (front-end)

2023-08-13 Thread via GitHub
janhoy commented on code in PR #1791: URL: https://github.com/apache/solr/pull/1791#discussion_r1292753402 ## solr/webapp/web/js/angular/controllers/login.js: ## @@ -60,92 +60,169 @@ solrAdminApp.controller('LoginController', var hp = AuthenticationService.decodeHas

[GitHub] [solr] mkhludnev commented on pull request #1837: SOLR-16928: Add missing unit tests for RegexFileFilter and StrUtils.toLower

2023-08-13 Thread via GitHub
mkhludnev commented on PR #1837: URL: https://github.com/apache/solr/pull/1837#issuecomment-1676330502 I think, we might not mention it in CHANGES.txt. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo