janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1292849716
##########
solr/modules/jwt-auth/src/java/org/apache/solr/security/jwt/JWTIssuerConfig.java:
##########
@@ -315,6 +327,24 @@ public JWTIssuerConfig setAuthorizationEndpoint(String
authorizationEndpoint) {
return this;
}
+ public String getTokenEndpoint() {
+ return tokenEndpoint;
+ }
+
+ public JWTIssuerConfig setTokenEndpoint(String tokenEndpoint) {
+ this.tokenEndpoint = tokenEndpoint;
+ return this;
+ }
+
+ public String getAuthorizationFlow() {
+ return authorizationFlow;
+ }
+
+ public JWTIssuerConfig setAuthorizationFlow(String authorizationFlow) {
+ this.authorizationFlow = authorizationFlow;
Review Comment:
Should we not validate the flow value early and fail if not either of the
two allowed values? I'm thinking we can also let this default to `implicit`
here in the backend instead of in the frontend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
