renatoh commented on PR #1873:
URL: https://github.com/apache/solr/pull/1873#issuecomment-1702234144
hmm, now JavaSpotless check is failing on a class I have not touched, this
one:
src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java
--
This is an auto
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-8027.
-
Resolution: Not A Problem
Picked "Not a Problem" as we've decided this isn't actually required anymore.
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761140#comment-17761140
]
Shawn Heisey commented on SOLR-8027:
{quote}i am okay with closing this ticket. The do
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761136#comment-17761136
]
Eric Pugh commented on SOLR-8027:
-
i am okay with closing this ticket. The documentation
solrbot opened a new pull request, #1877:
URL: https://github.com/apache/solr/pull/1877
This PR contains the following updates:
| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
|
[software.amazon.awssdk:url-connection-client](https://aws.amazon.com/sdkforjava
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761094#comment-17761094
]
Shawn Heisey edited comment on SOLR-8027 at 8/31/23 10:15 PM:
--
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761094#comment-17761094
]
Shawn Heisey commented on SOLR-8027:
With more time to think about this, I don't know
HoustonPutman merged PR #608:
URL: https://github.com/apache/solr-operator/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman closed issue #603: Allow a direct password for mounted TLS
Passwords
URL: https://github.com/apache/solr-operator/issues/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
HoustonPutman commented on PR #1866:
URL: https://github.com/apache/solr/pull/1866#issuecomment-1701754522
Thanks for the explanation! In general it seems a little daunting to have
them all separated and there, when it would be easier to work with them in the
same place. Maybe it'll be wort
gerlowskija commented on PR #1866:
URL: https://github.com/apache/solr/pull/1866#issuecomment-1701747937
Kindof?
That approach works fine as far as JAX-RS and Solr are concerned. In fact
I'm sure you noticed it's how things were structured when these classes lived
in 'core'.
stillalex commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1312200136
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -139,11 +147,15 @@ public SimplePropagatorSpanBuilder(ScopeManager
scopeManager) {
HoustonPutman closed issue #604: Upgrade minimum Kubernetes version to v1.22
URL: https://github.com/apache/solr-operator/issues/604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
HoustonPutman merged PR #612:
URL: https://github.com/apache/solr-operator/pull/612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
HoustonPutman commented on PR #1866:
URL: https://github.com/apache/solr/pull/1866#issuecomment-1701712648
Is it possible to make the model classes static inner classes of the
interfaces that use them?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-16879.
-
Resolution: Fixed
Thanks for contributing Pierre!
> Throttle concurrent backups/restores per nod
[
https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761078#comment-17761078
]
ASF subversion and git services commented on SOLR-16879:
Commit d
dsmiley commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1312162134
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -139,11 +147,15 @@ public SimplePropagatorSpanBuilder(ScopeManager
scopeManager) {
@O
[
https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761075#comment-17761075
]
ASF subversion and git services commented on SOLR-16879:
Commit 5
dsmiley merged PR #1864:
URL: https://github.com/apache/solr/pull/1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
stillalex commented on PR #1853:
URL: https://github.com/apache/solr/pull/1853#issuecomment-1701620055
converted to draft so no one accidentally merges this. the PR is waiting
review from @dsmiley and potentially some contributions, as requested on the
Jira ticket.
--
This is an automate
dsmiley merged PR #1869:
URL: https://github.com/apache/solr/pull/1869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley closed pull request #1761: SOLR-16879: add queue for expensive admin
operations
URL: https://github.com/apache/solr/pull/1761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
dsmiley commented on PR #1761:
URL: https://github.com/apache/solr/pull/1761#issuecomment-1701560186
Closed in favor of #1864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/SOLR-16879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761057#comment-17761057
]
David Smiley commented on SOLR-16879:
-
The solution presented is a generalized approa
stillalex commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1312007618
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
HoustonPutman merged PR #614:
URL: https://github.com/apache/solr-operator/pull/614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@s
epugh commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-1701520212
You are quite right about probably conflating this with my other experiment
to see how it works.if you are running a cluster with six nodes, then you
probably SHOULD be using Solrcloud, an
Colvin Cowie created SOLR-16958:
---
Summary: Spurious warning logged when using latest
luceneMatchVersion
Key: SOLR-16958
URL: https://issues.apache.org/jira/browse/SOLR-16958
Project: Solr
Issu
epugh commented on PR #1875:
URL: https://github.com/apache/solr/pull/1875#issuecomment-170140
> Cool. I don't see the point in testing replication between two isolated
SolrCloud nodes though, is that even supported? Are you thinking about some
kind of usecase where you pull the index f
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311976271
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ry
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311966439
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ryan
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311961728
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ry
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311961728
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ry
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311961728
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ry
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311948300
##
solr/CHANGES.txt:
##
@@ -147,6 +149,8 @@ Bug Fixes
* SOLR-16916: Use of the JSON Query DSL should ignore the defType parameter
(Christina Chortaria, Max Kadel, Ryan
janhoy commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1311946171
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codahale.
janhoy commented on code in PR #1876:
URL: https://github.com/apache/solr/pull/1876#discussion_r1311927251
##
dev-docs/apis.adoc:
##
@@ -0,0 +1,81 @@
+= APIs in Solr
+:toc: left
+
+Solr's codebase currently has a handful of ways of defining APIs.
+This complexity stems largely f
laminelam commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1701423640
THANK YOU @janhoy for your extensive review and contribution.
I think the PR is now good for a merge.
--
This is an automated message from the Apache Git Service.
To respond to the mes
laminelam commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311932809
##
solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java:
##
@@ -60,20 +66,49 @@ public void doGet(HttpServletRequest _request,
HttpServletResponse _respon
stillalex commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1311921932
##
solr/core/src/java/org/apache/solr/util/tracing/SimplePropagator.java:
##
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
janhoy commented on code in PR #1875:
URL: https://github.com/apache/solr/pull/1875#discussion_r1311917393
##
solr/packaging/test/test_replication.bats:
##
@@ -0,0 +1,125 @@
+#!/usr/bin/env bats
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
cpoerschke commented on code in PR #96:
URL: https://github.com/apache/solr/pull/96#discussion_r1311918794
##
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java:
##
@@ -17,54 +17,49 @@
package org.apache.solr.util.circuitbreaker;
+import com.codah
stillalex commented on code in PR #1868:
URL: https://github.com/apache/solr/pull/1868#discussion_r1311901790
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -32,7 +33,7 @@ public static void setDbInstance(SolrQueryRequest req, String
coreOrColl) {
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1701318663
@dsmiley added a test covering collection creation and deletion. I also took
some inspiration from https://github.com/apache/solr/pull/1869 to add
collection name to the span data.
let
epugh commented on code in PR #1876:
URL: https://github.com/apache/solr/pull/1876#discussion_r1311845624
##
dev-docs/apis.adoc:
##
@@ -0,0 +1,81 @@
+= APIs in Solr
+:toc: left
+
+Solr's codebase currently has a handful of ways of defining APIs.
+This complexity stems largely fr
epugh commented on code in PR #1876:
URL: https://github.com/apache/solr/pull/1876#discussion_r1311844082
##
dev-docs/apis.adoc:
##
@@ -0,0 +1,81 @@
+= APIs in Solr
+:toc: left
+
+Solr's codebase currently has a handful of ways of defining APIs.
+This complexity stems largely fr
epugh commented on code in PR #1876:
URL: https://github.com/apache/solr/pull/1876#discussion_r1311843664
##
dev-docs/apis.adoc:
##
@@ -0,0 +1,81 @@
+= APIs in Solr
+:toc: left
+
+Solr's codebase currently has a handful of ways of defining APIs.
+This complexity stems largely fr
gerlowskija opened a new pull request, #1876:
URL: https://github.com/apache/solr/pull/1876
https://issues.apache.org/jira/browse/SOLR-15734
# Description
Solr's API situation generally has seen a lot of change in the last few
years. Many developers may feel unsure of the
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760979#comment-17760979
]
Gézapeti commented on SOLR-13833:
-
Yes, this caused issues for us when we've used TTL to
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760973#comment-17760973
]
Kevin Risden edited comment on SOLR-13833 at 8/31/23 2:21 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760973#comment-17760973
]
Kevin Risden edited comment on SOLR-13833 at 8/31/23 2:20 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760973#comment-17760973
]
Kevin Risden edited comment on SOLR-13833 at 8/31/23 2:20 PM:
-
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Risden updated SOLR-13833:
Attachment: Screenshot 2023-08-31 at 10.18.49.png
> setupRequest normally called twice
> --
[
https://issues.apache.org/jira/browse/SOLR-13833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760973#comment-17760973
]
Kevin Risden commented on SOLR-13833:
-
I can 100% confirm this is happening for delet
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311708090
##
solr/core/src/java/org/apache/solr/servlet/LoadAdminUiServlet.java:
##
@@ -60,20 +66,49 @@ public void doGet(HttpServletRequest _request,
HttpServletResponse _response)
dsmiley commented on code in PR #1869:
URL: https://github.com/apache/solr/pull/1869#discussion_r1311702971
##
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java:
##
@@ -113,7 +113,9 @@ public OverseerCollectionMessageHandler(
@Ov
janhoy commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1701134559
> We do have two packages "in the wild" that come with a UI
As stated anove, we never really needed to disable the old CSP header config
in `jetty.xml`. Turns out the `LoadAdminUiServle
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311699269
##
solr/server/etc/jetty.xml:
##
@@ -99,6 +100,7 @@
Review Comment:
Ok, turned out to be much simpler. Just leaving the `HeaderPatternRule
epugh opened a new pull request, #1875:
URL: https://github.com/apache/solr/pull/1875
https://issues.apache.org/jira/browse/SOLR-16957
# Description
BATS test for user managed index replication. This is a End 2 End test, not
a unit test for Bash scripts.
# Solution
psalagnac commented on PR #1864:
URL: https://github.com/apache/solr/pull/1864#issuecomment-1701018703
Suggested CHANGES.txt line:
> SOLR-16879: Limit the number of concurrent expensive core admin operations
by running them in a dedicated thread pool. Backup, Restore and Split are
ex
[
https://issues.apache.org/jira/browse/SOLR-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-16957:
-
Description:
We see a lot of user inquires about problems with replication using the
leader/follower pat
dizzu commented on PR #1843:
URL: https://github.com/apache/solr/pull/1843#issuecomment-1700991803
@Raghavan1988 any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
stillalex commented on code in PR #1869:
URL: https://github.com/apache/solr/pull/1869#discussion_r1311586699
##
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java:
##
@@ -113,7 +113,9 @@ public OverseerCollectionMessageHandler(
@
stillalex commented on code in PR #1869:
URL: https://github.com/apache/solr/pull/1869#discussion_r1311586699
##
solr/core/src/java/org/apache/solr/cloud/api/collections/OverseerCollectionMessageHandler.java:
##
@@ -113,7 +113,9 @@ public OverseerCollectionMessageHandler(
@
stillalex commented on PR #1869:
URL: https://github.com/apache/solr/pull/1869#issuecomment-1700972930
I think CreateCollectionCmd also uses 'NAME''
https://github.com/apache/solr/blob/22ac9105ea0382215c8fe558fc55977dc98aa14c/solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCol
[
https://issues.apache.org/jira/browse/SOLR-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-16957:
-
Summary: Test User-Managed Index Replication functionality (was: test
replication strategy for scaling i
Eric Pugh created SOLR-16957:
Summary: test replication strategy for scaling in leader/follower
Key: SOLR-16957
URL: https://issues.apache.org/jira/browse/SOLR-16957
Project: Solr
Issue Type: Imp
[
https://issues.apache.org/jira/browse/SOLR-7099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760905#comment-17760905
]
Eric Pugh commented on SOLR-7099:
-
It's been 8 years since the last comment, and I'm think
[
https://issues.apache.org/jira/browse/SOLR-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760907#comment-17760907
]
Eric Pugh commented on SOLR-8027:
-
[~elyograg] do you think this is still a need? Or can
[
https://issues.apache.org/jira/browse/SOLR-7617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760903#comment-17760903
]
Eric Pugh commented on SOLR-7617:
-
Could this be closed now that we have test_ssl.bats?
epugh commented on PR #1792:
URL: https://github.com/apache/solr/pull/1792#issuecomment-1700901263
We do have two packages "in the wild" that come with a UI, the YASA package
https://github.com/yasa-org/yasa and Splainer,
https://github.com/o19s/splainer/tree/main/solr-splainer-package.
rmuir commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311497182
##
solr/server/etc/jetty.xml:
##
@@ -99,6 +100,7 @@
Review Comment:
> @rmuir You added the CSP stuff to `jetty.xml`. Do you see a reason to
mkhludnev commented on PR #1874:
URL: https://github.com/apache/solr/pull/1874#issuecomment-1700705183
Appreciate, Dustin!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
mkhludnev merged PR #1874:
URL: https://github.com/apache/solr/pull/1874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311360400
##
solr/server/etc/jetty.xml:
##
@@ -99,6 +100,7 @@
Review Comment:
Ok, think I found a nice generic way of doing it:
```patch
diff
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311324407
##
solr/server/etc/jetty.xml:
##
@@ -99,6 +100,7 @@
Review Comment:
If there's an easy way to provide a "fallback" if the header is not se
janhoy commented on code in PR #1792:
URL: https://github.com/apache/solr/pull/1792#discussion_r1311274572
##
solr/server/etc/jetty.xml:
##
@@ -99,6 +100,7 @@
Review Comment:
@rmuir You added the CSP stuff to `jetty.xml`. Do you see a reason to
78 matches
Mail list logo
