pvcnt commented on PR #1891:
URL: https://github.com/apache/solr/pull/1891#issuecomment-1724927378
@dsmiley That's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Nicolò Mendola created SOLR-16987:
-
Summary: Upgrade jetty to 10.0.16 (CVE-2023-40167)
Key: SOLR-16987
URL: https://issues.apache.org/jira/browse/SOLR-16987
Project: Solr
Issue Type: Improvem
dsmiley commented on code in PR #1926:
URL: https://github.com/apache/solr/pull/1926#discussion_r1329571065
##
solr/core/src/java/org/apache/solr/cluster/maintenance/InactiveShardRemover.java:
##
@@ -0,0 +1,251 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/SOLR-15367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766642#comment-17766642
]
David Smiley commented on SOLR-15367:
-
+1. Deprecation is a fine enough goal. Thank
dsmiley commented on code in PR #1856:
URL: https://github.com/apache/solr/pull/1856#discussion_r1320994177
##
solr/core/src/java/org/apache/solr/util/tracing/TraceUtils.java:
##
@@ -150,4 +167,11 @@ public static void setOperations(SolrQueryRequest req,
String clazz, List
dsmiley commented on PR #1891:
URL: https://github.com/apache/solr/pull/1891#issuecomment-1724787866
Can you please add a CHANGES.txt note in the 9.4 section, probably in the
"Improvements" section? A brief sentence would do like "Make the internal
CoresLocator implementation configurable
tflobbe merged PR #1932:
URL: https://github.com/apache/solr/pull/1932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
tflobbe commented on PR #1931:
URL: https://github.com/apache/solr/pull/1931#issuecomment-1724631857
@gerlowskija Any thoughts here? I'm on the fence. I don't really love the
leniency with which we are reading boolean params here, it seems more useful
for configuration files than it is for
janhoy commented on code in PR #1930:
URL: https://github.com/apache/solr/pull/1930#discussion_r1329355144
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -343,4 +343,16 @@ public Collection getApis() {
return Collections.singleton(
new
David Smiley created SOLR-16986:
---
Summary: Measure and aggregate thread CPU time in distributed
search
Key: SOLR-16986
URL: https://issues.apache.org/jira/browse/SOLR-16986
Project: Solr
Issue
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16985:
Description:
Apache Lucene 9.8.0 was recently released: _TODO fill in link once Lucene is
released
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu reassigned SOLR-16985:
---
Assignee: (was: Houston Putman)
> Upgrade Lucene to 9.8.0
> ---
>
>
[
https://issues.apache.org/jira/browse/SOLR-16985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Deparvu updated SOLR-16985:
Fix Version/s: 9.4
(was: 9.3)
> Upgrade Lucene to 9.8.0
> --
Alex Deparvu created SOLR-16985:
---
Summary: Upgrade Lucene to 9.8.0
Key: SOLR-16985
URL: https://issues.apache.org/jira/browse/SOLR-16985
Project: Solr
Issue Type: Task
Reporter: Ale
noblepaul merged PR #1782:
URL: https://github.com/apache/solr/pull/1782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.
stillalex commented on PR #1856:
URL: https://github.com/apache/solr/pull/1856#issuecomment-1724111677
thinking about a CHANGES.txt entry I think this PR actually covers 2
different things:
- First, moves the tracing to the lower level
`InstrumentedHttpListenerFactory` and `Instrumented
cpoerschke commented on code in PR #1930:
URL: https://github.com/apache/solr/pull/1930#discussion_r1329049406
##
solr/core/src/java/org/apache/solr/handler/RequestHandlerBase.java:
##
@@ -343,4 +343,16 @@ public Collection getApis() {
return Collections.singleton(
epugh commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1723905011
Would then the preferred access mode for getting properties be via
`EnvUtils.getProp(SolrDispatchFilter.SOLR_DEFAULT_CONFDIR_ATTRIBUTE)` pattern?
I could imagine in a future ticket getting r
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328988330
##
solr/core/src/resources/EnvToSyspropMappings.properties:
##
Review Comment:
Searching for `System.getProperty` and `-D…` takes you a long way..
##
solr/c
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328985748
##
solr/bin/solr:
##
@@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
+# Export all SOLR variables so they are visible to Solr sub-process
epugh commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328984793
##
solr/core/src/resources/EnvToSyspropMappings.properties:
##
Review Comment:
I ❤️ this file!Now imagine if you could find all the possible system
property setti
epugh commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328982621
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
epugh commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328981379
##
solr/bin/solr:
##
@@ -1345,12 +1352,10 @@ if [ $# -gt 0 ]; then
;;
-v)
SOLR_LOG_LEVEL=DEBUG
-PASS_TO_RUN_EXAMPLE+=("-Dsolr.log.
epugh commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328980855
##
solr/bin/solr:
##
@@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then
. "$SOLR_INCLUDE"
fi
+# Export all SOLR variables so they are visible to Solr sub-process
+
epugh commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328977642
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Bernstein updated SOLR-16931:
--
Summary: ReRankScaler explain breaks with debug=true and in distributed
mode (was: ReRankScale
[
https://issues.apache.org/jira/browse/SOLR-16931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766455#comment-17766455
]
ASF subversion and git services commented on SOLR-16931:
Commit f
[
https://issues.apache.org/jira/browse/SOLR-16979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766433#comment-17766433
]
ASF subversion and git services commented on SOLR-16979:
Commit 7
janhoy merged PR #1923:
URL: https://github.com/apache/solr/pull/1923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328508569
##
solr/core/src/java/org/apache/solr/util/ModuleUtils.java:
##
@@ -56,17 +55,9 @@ public static Path getModuleLibPath(Path solrInstallDirPath,
String moduleName)
* @r
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328506613
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
janhoy commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1328441524
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor li
solrbot closed pull request #1822: Update dependency
no.nav.security:mock-oauth2-server to v1 - autoclosed
URL: https://github.com/apache/solr/pull/1822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-16750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17766268#comment-17766268
]
Vamsi Krishna K commented on SOLR-16750:
-
Thank you [~tflobbe]
> Grouping on E
bruno-roustant merged PR #72:
URL: https://github.com/apache/solr-sandbox/pull/72
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
bruno-roustant opened a new pull request, #72:
URL: https://github.com/apache/solr-sandbox/pull/72
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
bruno-roustant merged PR #71:
URL: https://github.com/apache/solr-sandbox/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@sol
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1722898115
Tests pass, @epugh can you have a first quick review and tell if this helps
your CLI work? After your first feedback I can invite more reviewers.
I feel the principle is well proven by
38 matches
Mail list logo
