stillalex commented on PR #1856: URL: https://github.com/apache/solr/pull/1856#issuecomment-1724111677
thinking about a CHANGES.txt entry I think this PR actually covers 2 different things: - First, moves the tracing to the lower level `InstrumentedHttpListenerFactory` and `InstrumentedHttpRequestExecutor` so it can capture more of the internal communication requests (and cover both client implementations: Jetty Client and Apache Httpclient). - Second, adds trace information for the internal operations by wrapping CollectionApiCommand So I would proposed the following (as Jira title too) ``` Extend Solr client tracing coverage to both Jetty Client and Apache HttpClient and attach spans to internal collection commands ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org