epugh commented on code in PR #1961:
URL: https://github.com/apache/solr/pull/1961#discussion_r1340899863
##
solr/solr-ref-guide/modules/indexing-guide/pages/charfilterfactories.adoc:
##
Review Comment:
I went ahead and did the page rename...
--
This is an automated
epugh commented on code in PR #1961:
URL: https://github.com/apache/solr/pull/1961#discussion_r1340878722
##
solr/solr-ref-guide/modules/indexing-guide/pages/charfilterfactories.adoc:
##
Review Comment:
I wonder if we should go ahead and rename the the from
epugh commented on code in PR #1961:
URL: https://github.com/apache/solr/pull/1961#discussion_r1340877351
##
solr/solr-ref-guide/modules/indexing-guide/pages/analyzers.adoc:
##
Review Comment:
I didn't actually really know about the shorter way of naming things... We
gerlowskija opened a new pull request, #636:
URL: https://github.com/apache/solr-operator/pull/636
The default solr.xml now has the necessary plumbing to obey the commonly
used `solr.sharedLib`, `solr.allowPaths`, and `enableMetrics` system properties.
Resolves #635
--
This is an
janhoy opened a new pull request, #1963:
URL: https://github.com/apache/solr/pull/1963
https://issues.apache.org/jira/browse/SOLR-X
The green bar should be 100% wide for the largest core, and the other should
be as wide as their relative size compared to the largest core.
--
dsmiley commented on code in PR #1935:
URL: https://github.com/apache/solr/pull/1935#discussion_r1340591638
##
solr/core/src/java/org/apache/solr/util/EnvUtils.java:
##
@@ -0,0 +1,279 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
risdenk commented on code in PR #1945:
URL: https://github.com/apache/solr/pull/1945#discussion_r1340609286
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1802,6 +1800,18 @@ public void waitForState(
throw new
dsmiley commented on PR #1950:
URL: https://github.com/apache/solr/pull/1950#issuecomment-1739867730
I've not seen underscores in method names in our codebase before. I think
you could call this method simply readNumericDocValuesDate. I just added
"Date" onto the existing method that
stillalex commented on PR #1950:
URL: https://github.com/apache/solr/pull/1950#issuecomment-1739858015
just a comment from the peanut gallery (will leave the review for the
experts).
this method `interprete_NumericDocValues_NumberType_DATE` feels very
specific, but at the same time
stillalex commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340547130
##
solr/core/src/java/org/apache/solr/core/SchemaCodecFactory.java:
##
@@ -145,4 +151,34 @@ public Codec getCodec() {
assert core != null : "inform must be called
gerlowskija commented on PR #629:
URL: https://github.com/apache/solr-operator/pull/629#issuecomment-1739831303
Thinking on this a bit more, are we sure we want to use `/admin/info/health`
for readiness probes?
Unlike the `/system`, `/health` will return an error on nodes with bad ZK
cpoerschke commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340538175
##
solr/core/src/test/org/apache/solr/search/neural/KnnQParserTest.java:
##
@@ -39,7 +39,7 @@ public class KnnQParserTest extends SolrTestCaseJ4 {
@Before
public
stillalex commented on PR #1958:
URL: https://github.com/apache/solr/pull/1958#issuecomment-1739810626
remaining failure is `TestFiltering.testRandomFiltering`:
```
- org.apache.solr.search.TestFiltering.testRandomFiltering (:solr:core)
Test output:
stillalex commented on PR #1958:
URL: https://github.com/apache/solr/pull/1958#issuecomment-1739797461
thanks @cpoerschke for links and cleanup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
HoustonPutman commented on PR #633:
URL: https://github.com/apache/solr-operator/pull/633#issuecomment-1739723709
Need to make sure the multi-namespace watch option still works before
merging, but otherwise this should be good to go.
--
This is an automated message from the Apache Git
cpoerschke commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340412849
##
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java:
##
@@ -368,14 +368,14 @@ public ByteVectorValues getByteVectorValues(String field)
{
}
cpoerschke commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340402317
##
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##
@@ -194,24 +193,24 @@ public void checkSchemaField(final SchemaField field)
throws
HoustonPutman commented on issue #635:
URL: https://github.com/apache/solr-operator/issues/635#issuecomment-1739640667
100%! The allowPaths will be great as well, so that we can eventually
utilize it for the backup paths, which currently reside in the data
directory... But that is not
[
https://issues.apache.org/jira/browse/SOLR-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Heisey updated SOLR-17001:
Attachment: SOLR-17001-2.patch
Status: Open (was: Open)
New patch adjusting solr.cmd
[
https://issues.apache.org/jira/browse/SOLR-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770124#comment-17770124
]
Shawn Heisey commented on SOLR-17001:
-
I was wrong, my solr.cmd changes are still wrong. Will have a
gerlowskija commented on issue #635:
URL: https://github.com/apache/solr-operator/issues/635#issuecomment-1739492006
This is a sub-task of #635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
gerlowskija opened a new issue, #635:
URL: https://github.com/apache/solr-operator/issues/635
The solr.xml that the operator currently uses as a default for new
`solrcloud` resources was crafted in the Solr 7.x timeline. [A recent
issue](https://github.com/apache/solr-operator/issues/630)
gerlowskija commented on PR #629:
URL: https://github.com/apache/solr-operator/pull/629#issuecomment-1739465569
Ah, good call - done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/SOLR-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770095#comment-17770095
]
Shawn Heisey commented on SOLR-17001:
-
Seems that the error I was running into (-Xss256k was
psalagnac commented on code in PR #1945:
URL: https://github.com/apache/solr/pull/1945#discussion_r1340250228
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1802,6 +1800,18 @@ public void waitForState(
throw new
[
https://issues.apache.org/jira/browse/SOLR-15940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770087#comment-17770087
]
Eric Pugh commented on SOLR-15940:
--
I fixed the code for this, and added, a commented out, bats test.
psalagnac commented on code in PR #1945:
URL: https://github.com/apache/solr/pull/1945#discussion_r1340250228
##
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##
@@ -1802,6 +1800,18 @@ public void waitForState(
throw new
[
https://issues.apache.org/jira/browse/SOLR-15940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-15940.
--
Fix Version/s: main (10.0)
9.4
Assignee: Eric Pugh
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770062#comment-17770062
]
Shawn Heisey commented on SOLR-17001:
-
Replaced the patch.
The windows script does not work yet, and
[
https://issues.apache.org/jira/browse/SOLR-17001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shawn Heisey updated SOLR-17001:
Attachment: SOLR-17001-1.patch
> Adjust workaround for JDK17 bug so it only applies to specific
Scott Vanderbilt created SOLR-17003:
---
Summary: Solr 9.3.0: NumberRangePrefixTree error
Key: SOLR-17003
URL: https://issues.apache.org/jira/browse/SOLR-17003
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-16953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17770046#comment-17770046
]
Monica Marrero commented on SOLR-16953:
---
Thank you [~pierre.salagnac] , I have run some tests and
janhoy commented on issue #600:
URL: https://github.com/apache/solr-operator/issues/600#issuecomment-1738781755
@cdmikechen What your're proposing is effectively for Solr Operator project
to take on the whole responsibility of zookeeper-operator, and that is likely
not something the
cdmikechen commented on issue #600:
URL: https://github.com/apache/solr-operator/issues/600#issuecomment-1738703237
@janhoy
I use https://github.com/strimzi/strimzi-kafka-operator to manage kafka
cluster in k8s.
Strimzi has built a unified image that includes both zookeeper and
34 matches
Mail list logo
