Re: [PR] SOLR-17036: Lazy create VersionBucket in the update log to free memory. [solr]

2023-10-17 Thread via GitHub
dsmiley commented on code in PR #2021: URL: https://github.com/apache/solr/pull/2021#discussion_r1363159588 ## solr/core/src/java/org/apache/solr/update/VersionInfo.java: ## @@ -103,14 +113,14 @@ public VersionInfo(UpdateLog ulog, int nBuckets) { .get("versionBucket

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776411#comment-17776411 ] David Smiley commented on SOLR-15782: - I wish to highlight that doing this shines a l

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-17 Thread via GitHub
dsmiley commented on code in PR #2016: URL: https://github.com/apache/solr/pull/2016#discussion_r1362721051 ## solr/core/src/java/org/apache/solr/api/ContainerPluginsRegistry.java: ## @@ -120,6 +123,33 @@ public void unregisterListener(PluginRegistryListener listener) { publ

[jira] [Assigned] (SOLR-17036) Lazy create VersionBucket in the update log to free memory.

2023-10-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Roustant reassigned SOLR-17036: - Assignee: Bruno Roustant > Lazy create VersionBucket in the update log to free memory. >

[jira] [Commented] (SOLR-16549) Solr core memory usage study

2023-10-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776388#comment-17776388 ] Bruno Roustant commented on SOLR-16549: --- I opened SOLR-17036 and its PR to lazy cre

[jira] [Comment Edited] (SOLR-16549) Solr core memory usage study

2023-10-17 Thread Bruno Roustant (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776388#comment-17776388 ] Bruno Roustant edited comment on SOLR-16549 at 10/17/23 8:53 PM: --

[jira] [Created] (SOLR-17036) Lazy create VersionBucket in the update log to free memory.

2023-10-17 Thread Bruno Roustant (Jira)
Bruno Roustant created SOLR-17036: - Summary: Lazy create VersionBucket in the update log to free memory. Key: SOLR-17036 URL: https://issues.apache.org/jira/browse/SOLR-17036 Project: Solr I

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-17 Thread via GitHub
dsmiley commented on PR #2016: URL: https://github.com/apache/solr/pull/2016#issuecomment-1767106858 > Do we envision having non-cloud container-level plugins, as this PR opens the way to? I am tempted to say it can be useful, but I don't know the original intention behind those plugins.

Re: [PR] SOLR-17035 Add trace id to jetty thread names to improve debuggability [solr]

2023-10-17 Thread via GitHub
stillalex commented on PR #2019: URL: https://github.com/apache/solr/pull/2019#issuecomment-1767094948 can't exactly tell why but there are threads that don't have the name cleared, so there is some subtle concurrency issue. ``` qtp2090991873-141-localhost-774737 (141)java.util.co

[jira] [Updated] (SOLR-17035) Add trace id to jetty thread names to improve debuggability via stack traces

2023-10-17 Thread Alex Deparvu (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Deparvu updated SOLR-17035: Description: Proposing to attach the trace id (if exists) data to the jetty thread names (the 'qtp

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on PR #1973: URL: https://github.com/apache/solr/pull/1973#issuecomment-1767054461 Sorry, I force pushed because I rebased against master (I had weird failures and hoped rebasing would help). Properties passed as `property.*` parameters in the CREATE collection comman

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
dsmiley commented on PR #1973: URL: https://github.com/apache/solr/pull/1973#issuecomment-1767022829 Why did you force push? Please don't do that (like ever, if you can help it); it resets the review state. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Updated] (SOLR-17034) Hitting /solr// ends up with HttpSolrCall NPE

2023-10-17 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden updated SOLR-17034: Status: Patch Available (was: Open) > Hitting /solr// ends up with HttpSolrCall NPE >

[PR] SOLR-17034: Hitting /solr// ends up with HttpSolrCall NPE [solr]

2023-10-17 Thread via GitHub
risdenk opened a new pull request, #2020: URL: https://github.com/apache/solr/pull/2020 https://issues.apache.org/jira/browse/SOLR-17034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[PR] SOLR-17035 Add trace id to jetty thread names to improve debuggability [solr]

2023-10-17 Thread via GitHub
stillalex opened a new pull request, #2019: URL: https://github.com/apache/solr/pull/2019 … via stack traces https://issues.apache.org/jira/browse/SOLR-17035 # Description Updating the thread name to include the trace id if present. # Solution Pl

[jira] [Created] (SOLR-17035) Add trace id to jetty thread names to improve debuggability via stack traces

2023-10-17 Thread Alex Deparvu (Jira)
Alex Deparvu created SOLR-17035: --- Summary: Add trace id to jetty thread names to improve debuggability via stack traces Key: SOLR-17035 URL: https://issues.apache.org/jira/browse/SOLR-17035 Project: Sol

[jira] [Created] (SOLR-17034) Hitting /solr// ends up with HttpSolrCall NPE

2023-10-17 Thread Kevin Risden (Jira)
Kevin Risden created SOLR-17034: --- Summary: Hitting /solr// ends up with HttpSolrCall NPE Key: SOLR-17034 URL: https://issues.apache.org/jira/browse/SOLR-17034 Project: Solr Issue Type: Bug

Re: [PR] learning-to-rank: explore AlternativeFormatWrapperModel [solr]

2023-10-17 Thread via GitHub
cpoerschke commented on PR #2018: URL: https://github.com/apache/solr/pull/2018#issuecomment-1766940934 closing draft pull request as exploration-only but leaving branch in-place in case anyone wants to branch-off it later -- This is an automated message from the Apache Git Service. To re

Re: [PR] learning-to-rank: explore AlternativeFormatWrapperModel [solr]

2023-10-17 Thread via GitHub
cpoerschke closed pull request #2018: learning-to-rank: explore AlternativeFormatWrapperModel URL: https://github.com/apache/solr/pull/2018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2023-10-17 Thread via GitHub
tflobbe commented on code in PR #2017: URL: https://github.com/apache/solr/pull/2017#discussion_r1362576129 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -68,6 +68,18 @@ In Solr 8, it was possible to add docValues to a schema without re-

Re: [PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2023-10-17 Thread via GitHub
tflobbe commented on PR #2017: URL: https://github.com/apache/solr/pull/2017#issuecomment-1766918924 Also, should we consider making this change as part of this schema upgrade? https://issues.apache.org/jira/browse/SOLR-12963 -- This is an automated message from the Apache Git Service. To

[PR] learning-to-rank: explore AlternativeFormatWrapperModel [solr]

2023-10-17 Thread via GitHub
cpoerschke opened a new pull request, #2018: URL: https://github.com/apache/solr/pull/2018 to go with my https://lists.apache.org/thread/5s5dq4j4bd74sfym7frwoqdokoh64s5l user mailing list reply -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2023-10-17 Thread via GitHub
HoustonPutman commented on code in PR #2017: URL: https://github.com/apache/solr/pull/2017#discussion_r1362562024 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -68,6 +68,18 @@ In Solr 8, it was possible to add docValues to a schema witho

Re: [PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2023-10-17 Thread via GitHub
tflobbe commented on code in PR #2017: URL: https://github.com/apache/solr/pull/2017#discussion_r1362549237 ## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc: ## @@ -68,6 +68,18 @@ In Solr 8, it was possible to add docValues to a schema without re-

[PR] SOLR-10808: SchemaVersion 1.7 - DocValues default to true [solr]

2023-10-17 Thread via GitHub
HoustonPutman opened a new pull request, #2017: URL: https://github.com/apache/solr/pull/2017 https://issues.apache.org/jira/browse/SOLR-10808 # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](h

[jira] [Created] (SOLR-17033) Admin UI - Cloud/Nodes list display broken

2023-10-17 Thread Jira
Dominique Béjean created SOLR-17033: --- Summary: Admin UI - Cloud/Nodes list display broken Key: SOLR-17033 URL: https://issues.apache.org/jira/browse/SOLR-17033 Project: Solr Issue Type: Bu

[jira] [Commented] (SOLR-10808) Enable DocValues by default for all string/numeric/date fields, unless explicitly disabled

2023-10-17 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776302#comment-17776302 ] Houston Putman commented on SOLR-10808: --- I'm bringing this back. DocValues should b

[PR] Update the CrossDC documentation. [solr-sandbox]

2023-10-17 Thread via GitHub
sigram opened a new pull request, #78: URL: https://github.com/apache/solr-sandbox/pull/78 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-17 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776265#comment-17776265 ] Vincent Primault commented on SOLR-15782: - I renamed the new code to be about "no

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #2016: URL: https://github.com/apache/solr/pull/2016#discussion_r1362401814 ## solr/core/src/java/org/apache/solr/core/CoreContainer.java: ## @@ -776,6 +775,7 @@ private void loadInternal() { ClusterEventProducerFactory clusterEventProducerFact

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1362381835 ## solr/CHANGES.txt: ## @@ -73,6 +73,8 @@ New Features - * SOLR-14496: Solr CLI commands now can interact with a Solr secured using Basic Authenticati

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1362380513 ## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as i

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1362377622 ## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as i

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1362377622 ## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as i

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-17 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1362367002 ## solr/core/src/test/org/apache/solr/cloud/CreateCollectionTest.java: ## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * con

[PR] Use 9.4 as the default e2e-tests Solr version [solr-operator]

2023-10-17 Thread via GitHub
HoustonPutman opened a new pull request, #645: URL: https://github.com/apache/solr-operator/pull/645 This overrides #632 Solr 9.4 has been released and fixes issues that caused incompatibility with the Solr Operator. The smoke tests use Solr 8.11, so its safer to default to 9.4 so

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776211#comment-17776211 ] David Smiley commented on SOLR-15782: - I don't think "cluster plugins" is wrong / ina

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-17 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776149#comment-17776149 ] Vincent Primault commented on SOLR-15782: - If going with "node plugin" (which I t

[jira] [Commented] (SOLR-14496) Add basic auth support to SolrCLI commands

2023-10-17 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776144#comment-17776144 ] Eric Pugh commented on SOLR-14496: -- Going to wait for a clean run on Jenkins main, and t

Re: [PR] SOLR-14496: Add Basic Auth support to SolrCLI [solr]

2023-10-17 Thread via GitHub
epugh merged PR #1954: URL: https://github.com/apache/solr/pull/1954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-14496) Add basic auth support to SolrCLI commands

2023-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776141#comment-17776141 ] ASF subversion and git services commented on SOLR-14496: Commit d

Re: [PR] Add dead letter queue functionality on the producer and consumer side [solr-sandbox]

2023-10-17 Thread via GitHub
sigram merged PR #70: URL: https://github.com/apache/solr-sandbox/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] Add support for mirroring ConfigSet requests. [solr-sandbox]

2023-10-17 Thread via GitHub
sigram merged PR #69: URL: https://github.com/apache/solr-sandbox/pull/69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache