[PR] Auto-label PRs with labeler action [solr]

2024-01-05 Thread via GitHub
janhoy opened a new pull request, #2180: URL: https://github.com/apache/solr/pull/2180 The project has some PR labels defined, but we don't use them because it is boring to manually label things, see https://github.com/apache/solr/pulls This PR implements https://github.com/actions/la

Re: [PR] SOLR-17096: Cluster Singleton plugin support for immutable deployments [solr]

2024-01-05 Thread via GitHub
pjmcarthur commented on PR #2126: URL: https://github.com/apache/solr/pull/2126#issuecomment-1879279003 I will add the validation. Regarding piggybacking on the existing `disable.configEdit` property, I like the idea, but I have one concern. If there are any Solr deployments out t

[jira] [Updated] (SOLR-16203) Using SPI lookups of analysis components results in factories that don't get ResourceLoaderAware.inform called on them (When using ClassicIndexSchemaFactory)

2024-01-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-16203: --- Fix Version/s: 9.5 > Using SPI lookups of analysis components results in factories that don't get >

[jira] [Resolved] (SOLR-16203) Using SPI lookups of analysis components results in factories that don't get ResourceLoaderAware.inform called on them (When using ClassicIndexSchemaFactory)

2024-01-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-16203. Resolution: Fixed Fixed in 9.5, considering backport to 9.4.1 in https://github.com/apache/solr/pu

[jira] [Commented] (SOLR-16203) Using SPI lookups of analysis components results in factories that don't get ResourceLoaderAware.inform called on them (When using ClassicIndexSchemaFactory)

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803700#comment-17803700 ] ASF subversion and git services commented on SOLR-16203: Commit 6

[jira] [Commented] (SOLR-16203) Using SPI lookups of analysis components results in factories that don't get ResourceLoaderAware.inform called on them (When using ClassicIndexSchemaFactory)

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803692#comment-17803692 ] ASF subversion and git services commented on SOLR-16203: Commit 8

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
janhoy merged PR #2175: URL: https://github.com/apache/solr/pull/2175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[PR] SOLR-17089: Upgrade Jersey to 3.1.5 [solr]

2024-01-05 Thread via GitHub
gerlowskija opened a new pull request, #2178: URL: https://github.com/apache/solr/pull/2178 https://issues.apache.org/jira/browse/SOLR-17089 # Description Brings in a number of bug fixes and improvements, as well as fixing some irritating stacktraces that Jersey 2.x was

[jira] [Commented] (SOLR-17036) Lazy create VersionBucket in the update log to free memory.

2024-01-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803655#comment-17803655 ] David Smiley commented on SOLR-17036: - [~broustant] can you please add an item in CHA

Re: [PR] add "test history where?" to dev-docs/FAQ.adoc [solr]

2024-01-05 Thread via GitHub
dsmiley commented on code in PR #2171: URL: https://github.com/apache/solr/pull/2171#discussion_r1443022935 ## dev-docs/FAQ.adoc: ## @@ -91,3 +91,9 @@ If you don't yet have an account, you have to ask for one in the 'users' or 'dev 1. Please do not delete older files that you

[jira] [Created] (SOLR-17111) Standardize system property naming

2024-01-05 Thread Jira
Jan Høydahl created SOLR-17111: -- Summary: Standardize system property naming Key: SOLR-17111 URL: https://issues.apache.org/jira/browse/SOLR-17111 Project: Solr Issue Type: Improvement Sec

[jira] [Resolved] (SOLR-15960) Unified use of system properties and environment variables

2024-01-05 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-15960. Fix Version/s: 9.5 Resolution: Resolved Thanks everyone for the support and review. Feel fre

[jira] [Commented] (SOLR-15960) Unified use of system properties and environment variables

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803559#comment-17803559 ] ASF subversion and git services commented on SOLR-15960: Commit 1

[jira] [Commented] (SOLR-15960) Unified use of system properties and environment variables

2024-01-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803558#comment-17803558 ] ASF subversion and git services commented on SOLR-15960: Commit 1

Re: [PR] SOLR-15960 Unified use of system properties and environment variables [solr]

2024-01-05 Thread via GitHub
janhoy merged PR #1935: URL: https://github.com/apache/solr/pull/1935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
janhoy commented on PR #2175: URL: https://github.com/apache/solr/pull/2175#issuecomment-1878786136 Thanks for nice proposals @uschindler , the method is now private and code cleaner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
janhoy commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442961491 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrException(E

Re: [PR] SOLR-16397: Modify v2 'REQUESTSTATUS' API to be more REST-ful [solr]

2024-01-05 Thread via GitHub
gerlowskija commented on code in PR #2144: URL: https://github.com/apache/solr/pull/2144#discussion_r1442929054 ## solr/api/src/java/org/apache/solr/client/api/endpoint/RequestCoreCommandStatusApi.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] SOLR-17066: Only apply default collection to collection requests [solr]

2024-01-05 Thread via GitHub
gerlowskija commented on code in PR #2177: URL: https://github.com/apache/solr/pull/2177#discussion_r1442905887 ## solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java: ## @@ -175,6 +175,19 @@ public void setQueryParams(Set queryParams) { public abstract SolrPa

Re: [PR] Update org.apache.lucene:* to v9.9.1 [solr]

2024-01-05 Thread via GitHub
solrbot commented on PR #2168: URL: https://github.com/apache/solr/pull/2168#issuecomment-1878438859 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update (`9.9.1`). You will get a PR once a newer version is released. To ignore t

Re: [PR] Update org.apache.lucene:* to v9.9.1 [solr]

2024-01-05 Thread via GitHub
cpoerschke commented on PR #2168: URL: https://github.com/apache/solr/pull/2168#issuecomment-1878403247 closing in favour of #2176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Update org.apache.lucene:* to v9.9.1 [solr]

2024-01-05 Thread via GitHub
cpoerschke closed pull request #2168: Update org.apache.lucene:* to v9.9.1 URL: https://github.com/apache/solr/pull/2168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Update dependency org.carrot2:carrot2-core to v4.5.3 [solr]

2024-01-05 Thread via GitHub
cpoerschke commented on PR #2130: URL: https://github.com/apache/solr/pull/2130#issuecomment-1878394157 https://carrot2.github.io/release/4.5.3/doc/v4.5.x/#v4.5.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] add "test history where?" to dev-docs/FAQ.adoc [solr]

2024-01-05 Thread via GitHub
cpoerschke commented on code in PR #2171: URL: https://github.com/apache/solr/pull/2171#discussion_r1442665225 ## dev-docs/FAQ.adoc: ## @@ -91,3 +91,9 @@ If you don't yet have an account, you have to ask for one in the 'users' or 'dev 1. Please do not delete older files that y

[jira] [Comment Edited] (SOLR-17060) CoreContainer#create may deadlock with concurrent requests for metrics

2024-01-05 Thread Andreas Hubold (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786811#comment-17786811 ] Andreas Hubold edited comment on SOLR-17060 at 1/5/24 8:39 AM:

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442595590 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -652,6 +657,7 @@ protected void readSchema(ConfigSetService.ConfigResource is) { loadCopyFi

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442593581 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti

Re: [PR] SOLR-16203: Initialize schema plugins loaded by SPI name [solr]

2024-01-05 Thread via GitHub
uschindler commented on code in PR #2175: URL: https://github.com/apache/solr/pull/2175#discussion_r1442590015 ## solr/core/src/java/org/apache/solr/schema/IndexSchema.java: ## @@ -1991,6 +1997,37 @@ public IndexSchema deleteCopyFields(Map> copyFields) throw new SolrExcepti