dsmiley commented on PR #1926:
URL: https://github.com/apache/solr/pull/1926#issuecomment-2008667195
For all the AI fanciness of that bot, some good old fashioned static
analysis is all we would have liked to point out that we are adding methods
that are not used (leading to test flapper an
[
https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828602#comment-17828602
]
ASF subversion and git services commented on SOLR-16403:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828600#comment-17828600
]
ASF subversion and git services commented on SOLR-16403:
Commit f
dsmiley merged PR #2359:
URL: https://github.com/apache/solr/pull/2359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
risdenk merged PR #2136:
URL: https://github.com/apache/solr/pull/2136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
[
https://issues.apache.org/jira/browse/SOLR-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828552#comment-17828552
]
Kevin Risden commented on SOLR-17207:
-
[~hossman] looks good to me. I checked the his
[
https://issues.apache.org/jira/browse/SOLR-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-17207:
--
Attachment: SOLR-17207.patch
Status: Open (was: Open)
Attached path removes {{
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828546#comment-17828546
]
Jan Høydahl commented on SOLR-17202:
Less change is better, for sure.
Question about
[
https://issues.apache.org/jira/browse/SOLR-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828543#comment-17828543
]
ASF subversion and git services commented on SOLR-17207:
Commit 4
[
https://issues.apache.org/jira/browse/SOLR-17207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828535#comment-17828535
]
ASF subversion and git services commented on SOLR-17207:
Commit 2
Jason Gerlowski created SOLR-17208:
--
Summary: Restore should fetch index files in parallel
Key: SOLR-17208
URL: https://issues.apache.org/jira/browse/SOLR-17208
Project: Solr
Issue Type: Imp
pjmcarthur opened a new pull request, #2359:
URL: https://github.com/apache/solr/pull/2359
https://issues.apache.org/jira/browse/SOLR-16403
# Description
#1926 introduced unreliability into the DeleteShardTest by inadvertently
removing the wait on observing the new Shar
Chris M. Hostetter created SOLR-17207:
-
Summary: remove LocaleTest, cleanup test detection of MiniKdc
incompatible Locales
Key: SOLR-17207
URL: https://issues.apache.org/jira/browse/SOLR-17207
Pro
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828519#comment-17828519
]
David Smiley commented on SOLR-17202:
-
Either both the group and artifact ID stay the
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828488#comment-17828488
]
Chris M. Hostetter edited comment on SOLR-17157 at 3/19/24 7:30 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-17157.
---
Fix Version/s: main (10.0)
9.6.0
Resolution: Fixed
> upgrad
hossman closed pull request #2352: SOLR-17157: Upgrade to Lucene 9.10.0
URL: https://github.com/apache/solr/pull/2352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828498#comment-17828498
]
ASF subversion and git services commented on SOLR-17157:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828488#comment-17828488
]
ASF subversion and git services commented on SOLR-17157:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828489#comment-17828489
]
ASF subversion and git services commented on SOLR-17097:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828487#comment-17828487
]
Chris M. Hostetter edited comment on SOLR-17097 at 3/19/24 6:49 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-17097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828487#comment-17828487
]
ASF subversion and git services commented on SOLR-17097:
Commit 0
AndreyBozhko commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007853365
Thanks for the review @epugh, please feel free to merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Paul McArthur created SOLR-17206:
Summary: Update requests to SolrCloud can return status value of -1
Key: SOLR-17206
URL: https://issues.apache.org/jira/browse/SOLR-17206
Project: Solr
Issue
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530850952
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpellCheck
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530738178
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530737343
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpe
alessandrobenedetti commented on PR #2348:
URL: https://github.com/apache/solr/pull/2348#issuecomment-2007629216
Thanks @cpoerschke for your feedback!
I'll push a commit soon with changes accordingly to your suggestions.
In terms of documentation I am inclined to add a line in the Learn
alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530706021
##
solr/core/src/java/org/apache/solr/search/IncompleteRerankingException.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530704747
##
solr/core/src/java/org/apache/solr/search/ReRankCollector.java:
##
@@ -128,22 +128,26 @@ public TopDocs topDocs(int start, int howMany) {
}
alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530701074
##
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##
@@ -234,6 +236,13 @@ protected static boolean scoreSingleHit(
scorer.getDocInfo().
alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530697990
##
solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRQParserPlugin.java:
##
@@ -137,4 +140,63 @@ public void ltrNoResultsTest() throws Exception {
quer
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007595741
Tests pass!, let me know if you are ready for this to be merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
alessandrobenedetti opened a new pull request, #2358:
URL: https://github.com/apache/solr/pull/2358
https://issues.apache.org/jira/browse/SOLR-17018
# Description
Learning To Rank was ignoring any queryLimit parameter (such as timeAllowed)
during the reranking phase.
This me
[
https://issues.apache.org/jira/browse/SOLR-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gus Heck resolved SOLR-17203.
-
Fix Version/s: main (10.0)
9.6.0
Resolution: Fixed
> CPU not calculated correct
[
https://issues.apache.org/jira/browse/SOLR-17203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828420#comment-17828420
]
ASF subversion and git services commented on SOLR-17203:
Commit b
gus-asf merged PR #2357:
URL: https://github.com/apache/solr/pull/2357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
gus-asf opened a new pull request, #2357:
URL: https://github.com/apache/solr/pull/2357
https://issues.apache.org/jira/browse/SOLR-17203
SOLR-16986 is not back-ported, so changes to RequestHandlerBase were
omitted, but it's just a method name change and a couple IDE nits so that
shou
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530600667
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=true&spe
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530599052
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpellCheck
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530571928
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530571928
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007367282
I'd love to review a PR that rationalizes the string/floats..We would
probably need to make the string version deprecated in 9x with a warning, and
then require just the float in 10x...
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530500951
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -25,26 +25,34 @@ The basis for these suggestions can be terms in a field in
Solr, externally cre
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530503936
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpe
AndreyBozhko opened a new pull request, #2356:
URL: https://github.com/apache/solr/pull/2356
https://issues.apache.org/jira/browse/SOLR-12089
# Description
Updated the Ref Guide about Spell Checking.
Also, I noticed some inconsistencies with how different spel
[
https://issues.apache.org/jira/browse/SOLR-16982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828354#comment-17828354
]
Jan Høydahl commented on SOLR-16982:
We forgot to update Ref.Guide for this change. I
janhoy commented on PR #2345:
URL: https://github.com/apache/solr/pull/2345#issuecomment-2007278990
Thanks for review. Will merge tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
[
https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17161:
---
Summary: Separate out a solrj-jetty artifact (10.0) (was: Separate out a
solrj-jetty package / artif
[
https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828350#comment-17828350
]
Jan Høydahl commented on SOLR-17161:
I think we need to delay this refactoring until
pvcnt commented on PR #2354:
URL: https://github.com/apache/solr/pull/2354#issuecomment-2007249997
I have observed it in production (running on 8.6, granted).
SolrServerException sure has a constructor that takes no cause, and is used at
several places in Http2SolrClient, HttpSolrClient and
janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530416388
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for co
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828337#comment-17828337
]
David Smiley commented on SOLR-17202:
-
In a major version number, users can expect th
dsmiley commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530372883
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for c
epugh commented on PR #2354:
URL: https://github.com/apache/solr/pull/2354#issuecomment-2007182701
I'm hoping someone else with more experience can weigh inHowever,
isn't the bug here that you can have a `SolrServerException` that doesn't have
a cause? Shouldn't we just make sure
iamsanjay commented on PR #2276:
URL: https://github.com/apache/solr/pull/2276#issuecomment-2007163874
IndexFetcher getStream fails, seen it multiple times now. Blocker!
> ERROR
(recoveryExecutor-452-thread-1-processing-unloadcollection_shard1_replica4
null-484 core_node5 127.0.0.1:4
janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530311257
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for co
janhoy commented on PR #2345:
URL: https://github.com/apache/solr/pull/2345#issuecomment-2007053399
> Both Krb5HttpClientBuilder and PreemptiveBasicAuthClientBuilderFactory
ought to lose their deprecated status. You marked them as such but these
classes support Apache HttpClient & Jetty Htt
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530249778
##
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##
@@ -233,7 +235,14 @@ protected static boolean scoreSingleHit(
boolean logHit = false;
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530238242
##
solr/core/src/java/org/apache/solr/search/IncompleteRerankingException.java:
##
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
janhoy commented on code in PR #2345:
URL: https://github.com/apache/solr/pull/2345#discussion_r1530237610
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java:
##
@@ -19,10 +19,7 @@
import java.io.Closeable;
/**
- * Factory interface for co
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530235435
##
solr/core/src/java/org/apache/solr/search/ReRankCollector.java:
##
@@ -128,22 +128,26 @@ public TopDocs topDocs(int start, int howMany) {
}
ScoreDoc[
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530221741
##
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##
@@ -234,6 +236,13 @@ protected static boolean scoreSingleHit(
scorer.getDocInfo().setOrigin
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530221741
##
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##
@@ -234,6 +236,13 @@ protected static boolean scoreSingleHit(
scorer.getDocInfo().setOrigin
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530210274
##
solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRQParserPlugin.java:
##
@@ -137,4 +140,63 @@ public void ltrNoResultsTest() throws Exception {
query.add("rq
cpoerschke commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530206643
##
solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRQParserPlugin.java:
##
@@ -137,4 +140,63 @@ public void ltrNoResultsTest() throws Exception {
query.add("rq
[
https://issues.apache.org/jira/browse/SOLR-17157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Christine Poerschke reassigned SOLR-17157:
--
Assignee: Chris M. Hostetter
> upgrade to Lucene 9.10.0
>
[
https://issues.apache.org/jira/browse/SOLR-17205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828283#comment-17828283
]
Jan Høydahl commented on SOLR-17205:
Is this as simple as setting targetCompatibility
Jan Høydahl created SOLR-17205:
--
Summary: Let SolrJ require JRE17 in Solr10
Key: SOLR-17205
URL: https://issues.apache.org/jira/browse/SOLR-17205
Project: Solr
Issue Type: Task
Security Le
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828276#comment-17828276
]
Jan Høydahl commented on SOLR-17202:
I updated the description.
The original reason
alessandrobenedetti commented on code in PR #2348:
URL: https://github.com/apache/solr/pull/2348#discussion_r1530156988
##
solr/modules/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java:
##
@@ -233,7 +235,14 @@ protected static boolean scoreSingleHit(
boolean logHit = false
pvcnt opened a new pull request, #2354:
URL: https://github.com/apache/solr/pull/2354
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Plea
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17202:
---
Description:
Today SolrJ uses the same groupID as Solr itself, {{{}org.apache.solr{}}}.
In SOLR-1607
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17202:
---
Description:
Today SolrJ uses the same groupID as Solr itself, {{{}org.apache.solr{}}}.
In Starting
[
https://issues.apache.org/jira/browse/SOLR-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17828243#comment-17828243
]
Jan Høydahl commented on SOLR-16078:
Regarding the change of maven coordinates for so
[
https://issues.apache.org/jira/browse/SOLR-17202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-17202:
---
Description:
Today SolrJ uses the same groupID as Solr itself, {{{}org.apache.solr{}}}.
Starting wit
pvcnt commented on code in PR #2353:
URL: https://github.com/apache/solr/pull/2353#discussion_r1529928198
##
solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java:
##
@@ -60,19 +60,19 @@ public void call(ClusterState state, ZkNodeProps message,
NamedList
pvcnt opened a new pull request, #2353:
URL: https://github.com/apache/solr/pull/2353
https://issues.apache.org/jira/browse/SOLR-17204
# Description
The REPLACENODE command explicitly does not support the source node not
being live, and fails at the beginning if it
Vincent Primault created SOLR-17204:
---
Summary: REPLACENODE command does not support source not being live
Key: SOLR-17204
URL: https://issues.apache.org/jira/browse/SOLR-17204
Project: Solr
79 matches
Mail list logo
