[PR] Update GC logging options for Zookeeper [solr]

2024-03-21 Thread via GitHub
radu-gheorghe opened a new pull request, #2364: URL: https://github.com/apache/solr/pull/2364 So they work for Java 9+, given that we require Java 11+. Existing ones are for Java 8. Manually tested these options (which are stolen from Solr's own GC logging options) on a 9.5 installat

Re: [PR] SOLR-15857: Add AWS Secret Manager support for ZK ACL credentials [solr]

2024-03-21 Thread via GitHub
laminelam commented on code in PR #1994: URL: https://github.com/apache/solr/pull/1994#discussion_r1534863816 ## solr/server/scripts/cloud-scripts/zkcli.sh: ## @@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml" solr_home="$sdir/../../solr" +# Ge

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-03-21 Thread via GitHub
aparnasuresh85 commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2014026536 > I'm glad to see the logic that was in V2HttpCall made more common (move to base class) as it should not have been specific to V2. Perhaps my oversight 6 years ago. > > Updati

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-03-21 Thread via GitHub
aparnasuresh85 commented on PR #2363: URL: https://github.com/apache/solr/pull/2363#issuecomment-2013499876 > I'm glad to see the logic that was in V2HttpCall made more common (move to base class) as it should not have been specific to V2. Perhaps my oversight 6 years ago. > > Updati

Re: [PR] SOLR-17018: add QueryLimits support to Learning To Rank rescoring [solr]

2024-03-21 Thread via GitHub
cpoerschke commented on code in PR #2348: URL: https://github.com/apache/solr/pull/2348#discussion_r1534377191 ## solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTRQParserPlugin.java: ## @@ -137,4 +140,92 @@ public void ltrNoResultsTest() throws Exception { query.add("rq

Re: [PR] SOLR-16866: Deleting a non-existent directory should not fail [solr]

2024-03-21 Thread via GitHub
magibney commented on PR #2336: URL: https://github.com/apache/solr/pull/2336#issuecomment-2012621142 Any thoughts on #2349 ? This issue creates a lot of log noise 😓 >>Maybe the error occurs while it's deleting a child tree, and the rest of the files arent' deleted? >Yeah I ex

Re: [PR] SOLR-17153: CloudSolrClient should not throw "Collection not found" with an out-dated ClusterState [solr]

2024-03-21 Thread via GitHub
dsmiley commented on code in PR #2363: URL: https://github.com/apache/solr/pull/2363#discussion_r1534052101 ## solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java: ## @@ -345,6 +348,41 @@ protected void init() throws Exception { action = PASSTHROUGH; } + /**

Re: [PR] SOLR-16982 Reference guide change for sharded request and circuit breaker [solr]

2024-03-21 Thread via GitHub
janhoy merged PR #2355: URL: https://github.com/apache/solr/pull/2355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[PR] CloudSolrClient should not throw "Collection not found" with an outda… [solr]

2024-03-21 Thread via GitHub
aparnasuresh85 opened a new pull request, #2363: URL: https://github.com/apache/solr/pull/2363 …ted cluster state https://issues.apache.org/jira/browse/SOLR-17153 # Description At present, when CloudSolrClient is instructed to send a request to a collection i

Re: [PR] HttpJdkSolrClient: Close the underlying http client, if it is supported (java 21+) [solr]

2024-03-21 Thread via GitHub
jdyer1 merged PR #2362: URL: https://github.com/apache/solr/pull/2362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-12089: FileBasedSpellChecker docs have some missing params [solr]

2024-03-21 Thread via GitHub
epugh commented on PR #2356: URL: https://github.com/apache/solr/pull/2356#issuecomment-2012293378 Thanks for this. I'm actually a little surprised we don't have a well defined approach for sharing deprecation messages in logs.. -- This is an automated message from the Apache Git Ser

Re: [PR] SOLR-17205 De-couple SolrJ Java version from server Java version [solr]

2024-03-21 Thread via GitHub
janhoy commented on PR #2360: URL: https://github.com/apache/solr/pull/2360#issuecomment-2011685238 I implemented your proposals @uschindler. I kept the definition of default and solrj java versions in main `build.gradle` for better visibility (needed to move it above the sourcing of `globa