dsmiley commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2016364187
Proposed CHANGES.txt under 9.6 Bug Fix:
> CloudSolrClient and Solr could in rare circumstances report that a
collection does not exist right after it was actually just created (an
eventua
dsmiley commented on PR #2327:
URL: https://github.com/apache/solr/pull/2327#issuecomment-2016361123
Okay. For simplicity, let's just remap each whitespace to the first
non-whitespace in the chosen block. Or maybe even simpler -- the letter 'X'
(hey why not?). Or maybe you might recommen
dsmiley commented on PR #2273:
URL: https://github.com/apache/solr/pull/2273#issuecomment-2016355523
Thanks again for contributing @ejn ; that took too long for us to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dsmiley merged PR #2273:
URL: https://github.com/apache/solr/pull/2273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.or
dsmiley commented on PR #2315:
URL: https://github.com/apache/solr/pull/2315#issuecomment-2016352747
I think small internal refactors like this don't need a CHANGES.txt entry; I
don't want contributors to feel there is an extra burden on them to do more
digital paperwork.
--
This is an a
dsmiley commented on PR #2221:
URL: https://github.com/apache/solr/pull/2221#issuecomment-2016351884
There is great work here; looking forward to it making 9.6 :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
janhoy commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2016244199
I have been thinking about adding a deprecation-feature to commons-cli, such
that you could construct an Option:
```java
Option o =
Option.builder("n").longOpt("new-long").deprecatedOp
pjmcarthur opened a new pull request, #2368:
URL: https://github.com/apache/solr/pull/2368
https://issues.apache.org/jira/browse/SOLR-17206
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
aparnasuresh85 commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1536189971
##
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java:
##
@@ -99,17 +99,6 @@ public void testProperties() throws Exception {
CollectionAdminReq
epugh commented on PR #2366:
URL: https://github.com/apache/solr/pull/2366#issuecomment-2015788854
I will leave it till monday and then merge. maybe @cpoerschke wants to
review too!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dsmiley commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1536097875
##
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java:
##
@@ -99,17 +99,6 @@ public void testProperties() throws Exception {
CollectionAdminRequest.cr
AndreyBozhko commented on PR #2366:
URL: https://github.com/apache/solr/pull/2366#issuecomment-2015676454
@epugh Thanks for the review - I'm done with my changes for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
AndreyBozhko opened a new pull request, #2367:
URL: https://github.com/apache/solr/pull/2367
https://issues.apache.org/jira/browse/SOLR-17110
# Description
Fix JacksonJsonWriter to properly quote uuid values in json query response
# Tests
Added a test t
dsmiley commented on PR #2354:
URL: https://github.com/apache/solr/pull/2354#issuecomment-2015534241
It'd be wonderful for you to; thanks Eric. Separately, I'm trying to combat
the need for JIRAs; I hated asking for one here. Stay tuned.
--
This is an automated message from the Apache G
epugh commented on PR #2354:
URL: https://github.com/apache/solr/pull/2354#issuecomment-2015421063
@dsmiley do you want to shepherd this one? If not, I will, just let me
know ;-). And thanks for explaining about the exceptions!
--
This is an automated message from the Apache Git Servi
epugh commented on code in PR #2366:
URL: https://github.com/apache/solr/pull/2366#discussion_r1535791256
##
solr/solr-ref-guide/modules/getting-started/pages/tutorial-aws.adoc:
##
Review Comment:
I did not TEST the command, but the edits look great.
--
This is an autom
AndreyBozhko opened a new pull request, #2366:
URL: https://github.com/apache/solr/pull/2366
# Description
Made a few updates to the tutorial docs - mostly, to the "SolrCloud on AWS
EC2" tutorial.
# Checklist
Please review the following and check all that app
aparnasuresh85 commented on PR #2363:
URL: https://github.com/apache/solr/pull/2363#issuecomment-2015349982
> > The reason I did not make the logic consistent across both providers is
because BaseHttpClusterStateProvider, where the logic for getState() is
implemented for the http version, c
AndreyBozhko commented on code in PR #2365:
URL: https://github.com/apache/solr/pull/2365#discussion_r1535761393
##
solr/CHANGES.txt:
##
@@ -56,6 +56,8 @@ Deprecation Removals
end in "/solr"). Users may still specify a default collection through use
of the `withDefaultColle
AndreyBozhko commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2015325094
Sure @epugh - here's the PR: https://github.com/apache/solr/pull/2365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
AndreyBozhko opened a new pull request, #2365:
URL: https://github.com/apache/solr/pull/2365
https://issues.apache.org/jira/browse/SOLR-12089
# Description
`main` branch only: remove `breakSugestionTieBreaker` parameter from
WordBreakSolrSpellChecker
# Checkl
James Dyer created SOLR-17211:
-
Summary: HttpJdkSolrClient: Support Async
Key: SOLR-17211
URL: https://issues.apache.org/jira/browse/SOLR-17211
Project: Solr
Issue Type: Improvement
Securi
epugh commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2015226105
> My ideal world is everywhere that we remained -x to -y we add -y to 9.x
and log a warning on usage of -x. Similar to what gradle does.
>
> But I can appreciate that that’s a ton of wor
madrob commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2015186966
My ideal world is everywhere that we remained -x to -y we add -y to 9.x and
log a warning on usage of -x. Similar to what gradle does.
But I can appreciate that that’s a ton of work, so
epugh commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2015165209
> Is it possible to back port the non-conflicting ones to 9.x? And also log
deprecation warnings on anything that's going away?
I was sort of hoping not too...I *guess* that I could
epugh commented on PR #1768:
URL: https://github.com/apache/solr/pull/1768#issuecomment-2015157267
> Is it possible to back port the non-conflicting ones to 9.x? And also log
deprecation warnings on anything that's going awa
--
This is an automated message from the Apache Git Service.
To
epugh opened a new pull request, #1768:
URL: https://github.com/apache/solr/pull/1768
https://issues.apache.org/jira/browse/SOLR-16824
# Description
This moves us towards using `--help` style instead of the `-h` and `-help`
mishmash that we have. This also lines up with how Co
epugh closed pull request #1768: SOLR-16824: Adopt Linux Command line tool
pattern of -- for long option commands
URL: https://github.com/apache/solr/pull/1768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dsmiley commented on code in PR #2363:
URL: https://github.com/apache/solr/pull/2363#discussion_r1535589661
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/ClusterStateProvider.java:
##
@@ -52,8 +52,7 @@ static ClusterStateProvider newZkClusterStateProvider(
/**
pvcnt commented on code in PR #2313:
URL: https://github.com/apache/solr/pull/2313#discussion_r1535540950
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -1278,6 +1287,15 @@ public Builder withMaxConnectionsPerHost(int max) {
return th
epugh commented on code in PR #1994:
URL: https://github.com/apache/solr/pull/1994#discussion_r1535512663
##
solr/server/scripts/cloud-scripts/zkcli.sh:
##
@@ -13,6 +13,21 @@ log4j_config="file:$sdir/../../resources/log4j2-console.xml"
solr_home="$sdir/../../solr"
+# Get so
janhoy merged PR #2361:
URL: https://github.com/apache/solr/pull/2361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-12089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-12089:
-
Component/s: spellchecker
> FileBasedSpellChecker docs have some missing params
> ---
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2014943816
This is really great @AndreyBozhko. Would you be interested in doing the
follow up PR to remove the deprecated code from 10x? And add an entry into
the major changes for 10x release notes?
[
https://issues.apache.org/jira/browse/SOLR-12089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-12089.
--
Fix Version/s: 9.6.0
Resolution: Fixed
Great improvement!
> FileBasedSpellChecker docs have som
epugh merged PR #2356:
URL: https://github.com/apache/solr/pull/2356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
[
https://issues.apache.org/jira/browse/SOLR-12089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh reassigned SOLR-12089:
Assignee: Eric Pugh
> FileBasedSpellChecker docs have some missing params
> --
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2014932225
> Thanks for this. I'm actually a little surprised we don't have a well
defined approach for sharing deprecation messages in logs..
I poked about and yeah, some things have helpers, but
[
https://issues.apache.org/jira/browse/SOLR-17210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl resolved SOLR-17210.
Resolution: Information Provided
Hi, thanks for providing this information. This sounds more like a
NAGARAJAN S created SOLR-17210:
--
Summary: Index Fetch Failed Issue in Solr
Key: SOLR-17210
URL: https://issues.apache.org/jira/browse/SOLR-17210
Project: Solr
Issue Type: Bug
Security Lev
40 matches
Mail list logo
