Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-16 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1568088624 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -215,8 +215,9 @@ public NamedList request(SolrRequest request, String coreName)

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-16 Thread via GitHub
rseitz commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1568077123 ## solr/core/src/test/org/apache/solr/response/transform/TestSubQueryTransformerDistrib.java: ## @@ -61,22 +75,51 @@ public static void setupCluster() throws Exception {

Re: [PR] SOLR-17023: Use Modern NLP Models via ONNX and Apache OpenNLP with Solr [solr]

2024-04-16 Thread via GitHub
github-actions[bot] commented on PR #1999: URL: https://github.com/apache/solr/pull/1999#issuecomment-2060090828 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-16 Thread via GitHub
epugh commented on code in PR #2404: URL: https://github.com/apache/solr/pull/2404#discussion_r1568013748 ## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ## @@ -215,8 +215,9 @@ public NamedList request(SolrRequest request, String coreName)

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-04-16 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837906#comment-17837906 ] Rudi Seitz commented on SOLR-12813: --- Here's a PR: https://github.com/apache/solr/pull/2404 > SolrCloud

[PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-16 Thread via GitHub
rseitz opened a new pull request, #2404: URL: https://github.com/apache/solr/pull/2404 https://issues.apache.org/jira/browse/SOLR-12813 # Description This PR fixes an issue where subqueries don't work when basic auth is enabled. The problem surfaces when 2 or more shards are

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-04-16 Thread via GitHub
dsmiley commented on code in PR #2395: URL: https://github.com/apache/solr/pull/2395#discussion_r1567989670 ## solr/core/src/java/org/apache/solr/update/processor/NumFieldLimitingUpdateRequestProcessor.java: ## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (SOLR-17106) LBSolrClient: Make it configurable to remove zombie ping checks

2024-04-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837877#comment-17837877 ] David Smiley commented on SOLR-17106: - Just want to mention that we should probably have these

[jira] [Created] (SOLR-17234) LBHttp2SolrClient does not skip "zombie" endpoints

2024-04-16 Thread James Dyer (Jira)
James Dyer created SOLR-17234: - Summary: LBHttp2SolrClient does not skip "zombie" endpoints Key: SOLR-17234 URL: https://issues.apache.org/jira/browse/SOLR-17234 Project: Solr Issue Type: Bug

[jira] [Commented] (SOLR-17066) Deprecate and remove core URLs in HttpSolrClient and friends

2024-04-16 Thread James Dyer (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837819#comment-17837819 ] James Dyer commented on SOLR-17066: --- [~gerlowskija] Can this ticket be closed? > Deprecate and remove

[jira] [Commented] (SOLR-14763) SolrJ Client Async HTTP/2 Requests

2024-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837818#comment-17837818 ] ASF subversion and git services commented on SOLR-14763: Commit

[jira] [Commented] (SOLR-14763) SolrJ Client Async HTTP/2 Requests

2024-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837816#comment-17837816 ] ASF subversion and git services commented on SOLR-14763: Commit

[jira] [Updated] (SOLR-16594) improve eDismax strategy for generating a term-centric query

2024-04-16 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rudi Seitz updated SOLR-16594: -- Description: When parsing a multi-term query that spans multiple fields, edismax sometimes switches

[jira] [Commented] (SOLR-12813) SolrCloud + 2 shards + subquery + auth = 401 Exception

2024-04-16 Thread Rudi Seitz (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837803#comment-17837803 ] Rudi Seitz commented on SOLR-12813: --- I have begun implementing a fix here:

Re: [PR] SOLR-17192: Add "field-limiting" URP to catch ill-designed schemas [solr]

2024-04-16 Thread via GitHub
gerlowskija commented on PR #2395: URL: https://github.com/apache/solr/pull/2395#issuecomment-2059268487 > I don't like the complexity in this URP relating to tolerance of where the URP is placed in the chain; I'd feel better if the URP were simplified from that concern and we expect the

[jira] [Commented] (SOLR-14763) SolrJ Client Async HTTP/2 Requests

2024-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837736#comment-17837736 ] ASF subversion and git services commented on SOLR-14763: Commit

Re: [PR] SOLR-14763 SolrJ HTTP/2 Async API using CompletableFuture (update for 2024) [solr]

2024-04-16 Thread via GitHub
jdyer1 merged PR #2402: URL: https://github.com/apache/solr/pull/2402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SOLR-17204: REPLACENODE supports the source node not being live [solr]

2024-04-16 Thread via GitHub
HoustonPutman commented on PR #2353: URL: https://github.com/apache/solr/pull/2353#issuecomment-2059215053 +1 from me, sorry that I missed this. Should we do the same thing for `MigrateReplicasCmd`? Seems like a good idea to keep parity there. -- This is an automated message from

Re: [PR] Add correct exception logging in the ExecutorUtil [solr]

2024-04-16 Thread via GitHub
HoustonPutman merged PR #2384: URL: https://github.com/apache/solr/pull/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (SOLR-15735) SolrJ should fully support Solr's v2 API

2024-04-16 Thread Yohann Callea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837723#comment-17837723 ] Yohann Callea edited comment on SOLR-15735 at 4/16/24 1:51 PM: --- If it can

[jira] [Commented] (SOLR-15735) SolrJ should fully support Solr's v2 API

2024-04-16 Thread Yohann Callea (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837723#comment-17837723 ] Yohann Callea commented on SOLR-15735: -- If it can root for the need to support v2 APIs in SolrJ, it

[jira] [Commented] (SOLR-17233) The parameters of q.op are recommended to be trim()

2024-04-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837700#comment-17837700 ] Eric Pugh commented on SOLR-17233: -- I'd be happy to review a PR for fixing this   I wonder if we

Re: [PR] SOLR-17151 - stop processing components once we have exceeded a query limit [solr]

2024-04-16 Thread via GitHub
sigram commented on code in PR #2403: URL: https://github.com/apache/solr/pull/2403#discussion_r1567093594 ## solr/core/src/java/org/apache/solr/search/QueryLimits.java: ## @@ -108,12 +110,21 @@ public String formatExceptionMessage(String label) { * @throws

Re: [PR] SOLR-16505: Switch UpdateShardHandler.getRecoveryOnlyHttpClient to Jetty HTTP2 [solr]

2024-04-16 Thread via GitHub
iamsanjay commented on PR #2276: URL: https://github.com/apache/solr/pull/2276#issuecomment-2058715129 ### Can we remove the Legacy Auth mechanism? No In User managed cluster, the only communication, IMO, happening is downloading of index from one node to another. The

Re: [PR] SOLR-17151 - stop processing components once we have exceeded a query limit [solr]

2024-04-16 Thread via GitHub
sigram commented on code in PR #2403: URL: https://github.com/apache/solr/pull/2403#discussion_r1567091001 ## solr/core/src/java/org/apache/solr/search/QueryLimits.java: ## @@ -108,22 +110,31 @@ public String formatExceptionMessage(String label) { * @throws

[jira] [Commented] (SOLR-16441) Upgrade Jetty to 11.x

2024-04-16 Thread Henrik (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837588#comment-17837588 ] Henrik commented on SOLR-16441: --- Maybe close this issue in favour of  SOLR-17069 ? > Upgrade Jetty to 11.x

[jira] [Created] (SOLR-17233) The parameters of q.op are recommended to be trim()

2024-04-16 Thread ichar (Jira)
ichar created SOLR-17233: Summary: The parameters of q.op are recommended to be trim() Key: SOLR-17233 URL: https://issues.apache.org/jira/browse/SOLR-17233 Project: Solr Issue Type: Improvement