[jira] [Comment Edited] (SOLR-13502) Investigate using something other than ZooKeeper's "4 letter words" for the admin UI status

2024-04-29 Thread John Durham (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842199#comment-17842199 ] John Durham edited comment on SOLR-13502 at 4/30/24 2:11 AM: -

[jira] [Comment Edited] (SOLR-13502) Investigate using something other than ZooKeeper's "4 letter words" for the admin UI status

2024-04-29 Thread John Durham (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842199#comment-17842199 ] John Durham edited comment on SOLR-13502 at 4/30/24 12:33 AM: -

[jira] [Commented] (SOLR-13502) Investigate using something other than ZooKeeper's "4 letter words" for the admin UI status

2024-04-29 Thread John Durham (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842199#comment-17842199 ] John Durham commented on SOLR-13502: I think having it be in addition to 4lw makes se

Re: [PR] SOLR-6572 Trim whitespace for shards.tolerant and leaderUrl [solr]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #2311: URL: https://github.com/apache/solr/pull/2311#issuecomment-2083897068 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] [SOLR-10059] Handle appended fq params with macros in distributed requests [solr]

2024-04-29 Thread via GitHub
github-actions[bot] commented on PR #2303: URL: https://github.com/apache/solr/pull/2303#issuecomment-2083897095 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify t

Re: [PR] SOLR-17244 - initial cut at an orientation for prospective release managers [solr]

2024-04-29 Thread via GitHub
janhoy commented on code in PR #2415: URL: https://github.com/apache/solr/pull/2415#discussion_r1583877903 ## dev-docs/releasing.adoc: ## @@ -0,0 +1,73 @@ + += Releasing Solr +:toc: left + +== Motivated? +So you're of the opinion that there are unreleased features or bugfixes c

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2083782067 I think we should split the pure refactor out from the class loader stuff…. On Mon, Apr 29, 2024 at 6:15 PM David Smiley ***@***.***> wrote: > ***@***. commented on this pul

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583843217 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583820695 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583820695 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583820695 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583820695 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-14115: Remove deprecated zkcli script. [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2427: URL: https://github.com/apache/solr/pull/2427#issuecomment-2083664163 Waiting on https://github.com/apache/solr/pull/2428 to be completed first... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-29 Thread via GitHub
rseitz commented on PR #2404: URL: https://github.com/apache/solr/pull/2404#issuecomment-2083646456 I opened a separate PR here: https://github.com/apache/solr/pull/2429 Basically, it's a one-line change that updates another `_parser.buildRequestFrom()` call inside `EmbeddedSolrServer.req

[jira] [Commented] (SOLR-16577) Core load issues are not always logged

2024-04-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842156#comment-17842156 ] David Smiley commented on SOLR-16577: - What a surprise that is; sorry to hear that!

Re: [PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-04-29 Thread via GitHub
rseitz commented on PR #2429: URL: https://github.com/apache/solr/pull/2429#issuecomment-2083640463 Tagging @epugh and @dsmiley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] SOLR-12813 followup -- preserve user Principal in alternate codepath in EmbeddedSolrServer [solr]

2024-04-29 Thread via GitHub
rseitz opened a new pull request, #2429: URL: https://github.com/apache/solr/pull/2429 https://issues.apache.org/jira/browse/SOLR-12813 # Description This is a followup to a previous [PR](https://github.com/apache/solr/pull/2404) that fixed SOLR-12813. This current chan

Re: [PR] SOLR-16796: introduce org.cyclonedx.bom gradle plugin [solr]

2024-04-29 Thread via GitHub
janhoy commented on PR #1203: URL: https://github.com/apache/solr/pull/1203#issuecomment-2083639846 I'm positive to including this as a first step and then proceeding with publishing SBOM as a release artifact as proposed. -- This is an automated message from the Apache Git Service. To re

[jira] [Commented] (SOLR-16577) Core load issues are not always logged

2024-04-29 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842151#comment-17842151 ] Houston Putman commented on SOLR-16577: --- [~dsmiley] I'm pretty sure we ran into iss

[jira] [Assigned] (SOLR-16577) Core load issues are not always logged

2024-04-29 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman reassigned SOLR-16577: - Assignee: David Smiley > Core load issues are not always logged > --

Re: [PR] Support running embedded-zk in "ensemble" mode [solr]

2024-04-29 Thread via GitHub
janhoy commented on PR #2391: URL: https://github.com/apache/solr/pull/2391#issuecomment-2083599034 Great work. I think we should rip out the existing embedded ZK, which is a hack. Do you want to proceed in a PR or perhaps in a central feature branch? -- This is an automated messag

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583658873 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583620967 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -379,7 +387,7 @@ public CloudLegacySolrClient build() { "Both zkH

Re: [PR] Shard split supports encryption. [solr-sandbox]

2024-04-29 Thread via GitHub
dsmiley commented on PR #103: URL: https://github.com/apache/solr-sandbox/pull/103#issuecomment-2083458789 1. communicate (in the description) what this is about. 2. two day standard waiting period before merge. Another's +1 may accelerate this. -- This is an automated message from t

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583499845 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -379,7 +387,7 @@ public CloudLegacySolrClient build() { "Both z

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
laminelam commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583497184 ## solr/core/src/java/org/apache/solr/cli/SolrCLI.java: ## @@ -607,6 +611,46 @@ public static String getZkHost(CommandLine cli) throws Exception { return zkHost;

Re: [PR] SOLR-14115: Update the docs to reference to the bin/solr equivalent of the zkcli.sh [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2428: URL: https://github.com/apache/solr/pull/2428#issuecomment-2083134993 I plan on backporting this to `branch_9x`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] SOLR-14115: Update the docs to reference to the bin/solr equivalent of the zkcli.sh [solr]

2024-04-29 Thread via GitHub
epugh opened a new pull request, #2428: URL: https://github.com/apache/solr/pull/2428 https://issues.apache.org/jira/browse/SOLR-14115 # Description Update the Ref Guide to not refer to zkcli.sh # Solution I did the lightest version of updating the Ref Guide to

[jira] [Commented] (SOLR-17244) Create a dev-doc to orient prospective release managers

2024-04-29 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842054#comment-17842054 ] Gus Heck commented on SOLR-17244: - So I just pushed the last changes I want to add, but I

Re: [PR] Shard split supports encryption. [solr-sandbox]

2024-04-29 Thread via GitHub
anshumg commented on PR #103: URL: https://github.com/apache/solr-sandbox/pull/103#issuecomment-2083098182 @dsmiley - that wasn't the intent, but I see that it was a one off. I guess everyone is on the same page :) Let's respect this repository almost as much as the main one so it's easier

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2404: URL: https://github.com/apache/solr/pull/2404#issuecomment-2082948170 I think open a seperate PR, just to keep the one that was merged and committed seperate from a new one. I'd love to see the suggested PR... Do we also need a test there? -- This is an au

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-29 Thread via GitHub
rseitz commented on PR #2404: URL: https://github.com/apache/solr/pull/2404#issuecomment-2082885569 Thanks @epugh and @dsmiley for the feedback and support for this fix. I'll open a separate ticket for the security.json refactor and tag Eric. There is a minor followup I would like to

Re: [PR] SOLR-16833: Add blog to Solr website [solr-site]

2024-04-29 Thread via GitHub
gerlowskija merged PR #97: URL: https://github.com/apache/solr-site/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apac

Re: [PR] SOLR-4587: integrate lucene-monitor into solr [solr]

2024-04-29 Thread via GitHub
kotman12 commented on PR #2382: URL: https://github.com/apache/solr/pull/2382#issuecomment-2082729041 @cpoerschke I was reading your last comment more carefully and I want to stress that the presearcher, once constructed, should be completely _stateless_ in the current proposal. The whole p

Re: [PR] Parses CHANGES.txt to identify contributors [solr]

2024-04-29 Thread via GitHub
dsmiley commented on code in PR #2424: URL: https://github.com/apache/solr/pull/2424#discussion_r1583066046 ## dev-tools/scripts/parseContributorsFromChanges.py: ## @@ -0,0 +1,63 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license ag

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
dsmiley commented on code in PR #2417: URL: https://github.com/apache/solr/pull/2417#discussion_r1583046307 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java: ## @@ -379,7 +387,7 @@ public CloudLegacySolrClient build() { "Both zkH

[PR] SOLR-14115: Remove deprecated zkcli script. [solr]

2024-04-29 Thread via GitHub
epugh opened a new pull request, #2427: URL: https://github.com/apache/solr/pull/2427 https://issues.apache.org/jira/browse/SOLR-14115 # Description Removing zkcli.sh from `main` # Solution We have left zkcli.sh in the `branch_9x` of Solr to not create too much ch

[jira] [Resolved] (SOLR-14115) Deprecate zkcli.sh

2024-04-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-14115. -- Fix Version/s: 9.7 Resolution: Fixed > Deprecate zkcli.sh > -- > >

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841966#comment-17841966 ] ASF subversion and git services commented on SOLR-14115: Commit b

Re: [PR] SOLR-14115: Allow bin/solr zk commands to have parity with zkcli.sh commands. [solr]

2024-04-29 Thread via GitHub
epugh merged PR #2298: URL: https://github.com/apache/solr/pull/2298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

[jira] [Commented] (SOLR-14115) Deprecate zkcli.sh

2024-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841963#comment-17841963 ] ASF subversion and git services commented on SOLR-14115: Commit 9

[jira] [Resolved] (SOLR-16921) Use -solrUrl to derive the zk host connection for bin/solr zk subcommands

2024-04-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh resolved SOLR-16921. -- Fix Version/s: 9.7 Resolution: Fixed > Use -solrUrl to derive the zk host connection for bin/sol

[jira] [Updated] (SOLR-16921) Use -solrUrl to derive the zk host connection for bin/solr zk subcommands

2024-04-29 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Pugh updated SOLR-16921: - Summary: Use -solrUrl to derive the zk host connection for bin/solr zk subcommands (was: bin/solr upconf

[jira] [Commented] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!

2024-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841947#comment-17841947 ] ASF subversion and git services commented on SOLR-16921: Commit 9

[jira] [Commented] (SOLR-16921) bin/solr upconfig and downconfig reference solrUrl but don't list it as option!

2024-04-29 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841945#comment-17841945 ] ASF subversion and git services commented on SOLR-16921: Commit f

Re: [PR] SOLR-16921: use -solrUrl to derive the zk host connection for bin/solr zk subcommands [solr]

2024-04-29 Thread via GitHub
epugh merged PR #2370: URL: https://github.com/apache/solr/pull/2370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17248: Refactor ZK related SolrCli tools to separate SolrZkClient and CloudSolrClient instantiation/usage [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2082391283 Gentle ping @dsmiley @laminelam did we get to a decision? Rename the ticket and move forward? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] SOLR-12813: subqueries should respect basic auth [solr]

2024-04-29 Thread via GitHub
epugh commented on PR #2404: URL: https://github.com/apache/solr/pull/2404#issuecomment-2082388354 Thanks @rseitz for the contribution. Tag me on the `security.json` refactor please! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Resolved] (SOLR-17237) JSON Writer appears to return invalid JSON when binary fields are used

2024-04-29 Thread Mikhail Khludnev (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Khludnev resolved SOLR-17237. - Fix Version/s: 9.6.0 Resolution: Fixed > JSON Writer appears to return invalid JSO

[jira] [Updated] (SOLR-17237) JSON Writer appears to return invalid JSON when binary fields are used

2024-04-29 Thread Karl Stoney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Stoney updated SOLR-17237: --- Attachment: Screenshot 2024-04-29 at 08.54.30.png > JSON Writer appears to return invalid JSON when b

[jira] [Commented] (SOLR-17237) JSON Writer appears to return invalid JSON when binary fields are used

2024-04-29 Thread Karl Stoney (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841887#comment-17841887 ] Karl Stoney commented on SOLR-17237: Hello! Sorry for the delay in getting back to yo