[jira] [Created] (SOLR-17345) Should bin/solr allow short/long opts consistently?

2024-06-24 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17345: -- Summary: Should bin/solr allow short/long opts consistently? Key: SOLR-17345 URL: https://issues.apache.org/jira/browse/SOLR-17345 Project: Solr Issue Ty

[jira] [Created] (SOLR-17344) Randomize short/long opts usage in Java-based CLI tests

2024-06-24 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-17344: -- Summary: Randomize short/long opts usage in Java-based CLI tests Key: SOLR-17344 URL: https://issues.apache.org/jira/browse/SOLR-17344 Project: Solr Issu

[PR] Review org.apache.solr.client.solrj.io.stream and responding to some warnings. [solr]

2024-06-24 Thread via GitHub
epugh opened a new pull request, #2530: URL: https://github.com/apache/solr/pull/2530 Typos, methods not used, return values not used, that sort of thing. Flagged by IntelliJ. Refactoring, so no CHANGES.txt or JIRA. -- This is an automated message from the Apache Git Service. To

Re: [PR] SOLR-16824: Adopt Linux Command line tool pattern of -- for long option commands [solr]

2024-06-24 Thread via GitHub
gerlowskija commented on code in PR #1768: URL: https://github.com/apache/solr/pull/1768#discussion_r1651013286 ## solr/bin/solr: ## @@ -420,14 +420,14 @@ function print_usage() { echo " you could pass: -j \"--include-jetty-dir=/etc/jetty/custom/se

[PR] Add KmsKeySupplier that calls a KmsClient to decrypt encryption keys. [solr-sandbox]

2024-06-24 Thread via GitHub
bruno-roustant opened a new pull request, #108: URL: https://github.com/apache/solr-sandbox/pull/108 Added a new section in ENCRYPTION.md, here is an extract for the description: If you have a Key Management System to manage the encryption key lifecycle, then you can use the `org.apac

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-24 Thread via GitHub
cpoerschke commented on PR #2526: URL: https://github.com/apache/solr/pull/2526#issuecomment-2186391578 > I added a simple resolution test. Testing the distributed behaviour would mean adding a new test Solr configuration ... The config APIs could be used instead of having another tes

Re: [PR] SOLR-17337: Show proper distributed stage id [solr]

2024-06-24 Thread via GitHub
cpoerschke commented on code in PR #2526: URL: https://github.com/apache/solr/pull/2526#discussion_r1650892906 ## solr/core/src/java/org/apache/solr/handler/component/DebugComponent.java: ## @@ -181,16 +183,28 @@ public void modifyRequest(ResponseBuilder rb, SearchComponent who

Re: [PR] SOLR-15582: Remove deprecated APIs in solrj Tuple class. [solr]

2024-06-24 Thread via GitHub
epugh commented on PR #257: URL: https://github.com/apache/solr/pull/257#issuecomment-2186377972 That makes sense!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Blog post [solr-site]

2024-06-24 Thread via GitHub
janhoy commented on PR #106: URL: https://github.com/apache/solr-site/pull/106#issuecomment-2186363140 > hi @janhoy when are we supposed to see the changes online? I took a look this morning and it's not there yet? https://solr.apache.org/blog.html -- This is an automated message f

Re: [PR] example/films: README.md and vectors tweaks [solr]

2024-06-24 Thread via GitHub
cpoerschke merged PR #2238: URL: https://github.com/apache/solr/pull/2238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

Re: [PR] SOLR-15582: Remove deprecated APIs in solrj Tuple class. [solr]

2024-06-24 Thread via GitHub
cpoerschke commented on code in PR #257: URL: https://github.com/apache/solr/pull/257#discussion_r1650867445 ## solr/CHANGES.txt: ## @@ -100,6 +100,8 @@ Other Changes * SOLR-17279: Introduce SecurityJson.java file to Test Framework to consolidate setting up authentication in

Re: [PR] SOLR-17333: Various rate limiting fixes [solr]

2024-06-24 Thread via GitHub
noblepaul commented on code in PR #2522: URL: https://github.com/apache/solr/pull/2522#discussion_r1650864722 ## solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java: ## @@ -282,4 +289,130 @@ public RateLimitManager build() { return rateLimitManager;

Re: [PR] SOLR-17333: Various rate limiting fixes [solr]

2024-06-24 Thread via GitHub
noblepaul commented on PR #2522: URL: https://github.com/apache/solr/pull/2522#issuecomment-2186338905 The following are not supported today or they don't have any effect whatsoever.I think we should just get rid of them and make the feauture simpler. ``` "guaranteedSlots":5, "sl

Re: [PR] Blog post [solr-site]

2024-06-24 Thread via GitHub
alessandrobenedetti commented on PR #106: URL: https://github.com/apache/solr-site/pull/106#issuecomment-2186079078 hi @janhoy when are we supposed to see the changes online? I took a look this morning and it's not there yet? -- This is an automated message from the Apache Git Service.