Re: [PR] SOLR-10255 Add support for docValues to solr.BinaryField [solr]

2024-07-10 Thread via GitHub
serba commented on code in PR #2536: URL: https://github.com/apache/solr/pull/2536#discussion_r1673451696 ## solr/core/src/test-files/solr/collection1/conf/bad-schema-unsupported-docValues.xml: ## Review Comment: I think this test is not testing binary doc values per say, b

Re: [PR] SOLR-10255 Add support for docValues to solr.BinaryField [solr]

2024-07-10 Thread via GitHub
serba commented on code in PR #2536: URL: https://github.com/apache/solr/pull/2536#discussion_r1673447557 ## solr/core/src/java/org/apache/solr/schema/BinaryField.java: ## @@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field, Object val) { len = buf.l

[PR] docker-test.yml: Upgrade GitHub Actions [solr]

2024-07-10 Thread via GitHub
cclauss opened a new pull request, #2552: URL: https://github.com/apache/solr/pull/2552 * https://github.com/actions/checkout/releases * https://github.com/actions/setup-java/releases * https://github.com/actions/cache/releases https://issues.apache.org/jira/browse/SOLR-X

[jira] [Updated] (SOLR-17366) Backup/Restore API locations should be relative to the default repository location

2024-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17366: -- Fix Version/s: main (10.0) > Backup/Restore API locations should be relative to the default rep

[jira] [Updated] (SOLR-17366) Backup/Restore API locations should be relative to the default repository location

2024-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Houston Putman updated SOLR-17366: -- Issue Type: Improvement (was: Bug) > Backup/Restore API locations should be relative to the de

[jira] [Created] (SOLR-17366) Backup/Restore API locations should be relative to the default repository location

2024-07-10 Thread Houston Putman (Jira)
Houston Putman created SOLR-17366: - Summary: Backup/Restore API locations should be relative to the default repository location Key: SOLR-17366 URL: https://issues.apache.org/jira/browse/SOLR-17366 Pr

[jira] [Commented] (SOLR-17105) Require a location for LocalFileSystemRepository Backups

2024-07-10 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864762#comment-17864762 ] Houston Putman commented on SOLR-17105: --- One part of this is that the location para

Re: [PR] SOLR-17321: Fix TestSolrCoreSnapshots.testBackupRestore [solr]

2024-07-10 Thread via GitHub
epugh commented on PR #2539: URL: https://github.com/apache/solr/pull/2539#issuecomment-2221062297 > > LGTM. Is the URIBuilder something that we should be using in more places? > > > > I certainly think so How do we get these tasks actually tracked and moved forward? Wo

[jira] [Commented] (SOLR-17321) Bump minimum required Java version to 21

2024-07-10 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864731#comment-17864731 ] ASF subversion and git services commented on SOLR-17321: Commit 2

Re: [PR] SOLR-17321: Fix TestSolrCoreSnapshots.testBackupRestore [solr]

2024-07-10 Thread via GitHub
HoustonPutman merged PR #2539: URL: https://github.com/apache/solr/pull/2539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apa

Re: [PR] SOLR-17321: Fix TestSolrCoreSnapshots.testBackupRestore [solr]

2024-07-10 Thread via GitHub
HoustonPutman commented on PR #2539: URL: https://github.com/apache/solr/pull/2539#issuecomment-2220953778 > LGTM. Is the URIBuilder something that we should be using in more places? I certainly think so -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] SOLR-17353: Fix for golang version 1.18 [solr]

2024-07-10 Thread via GitHub
HoustonPutman commented on code in PR #2542: URL: https://github.com/apache/solr/pull/2542#discussion_r1672610162 ## solr/docker/templates/Dockerfile.body.template: ## @@ -72,6 +72,8 @@ RUN set -ex; \ RUN set -ex; \ apt-get update; \ apt-get -y --no-install-recommends

Re: [PR] add build and Gradle dashboard badges to README.md [solr]

2024-07-10 Thread via GitHub
HoustonPutman commented on PR #2546: URL: https://github.com/apache/solr/pull/2546#issuecomment-2220949563 Thank you! Curious why you chose the `artifact` build over the `check` build though. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] SOLR-16198: Introduce tabbed blocks again [solr]

2024-07-10 Thread via GitHub
HoustonPutman commented on PR #2550: URL: https://github.com/apache/solr/pull/2550#issuecomment-2220946846 > It sounds like this pr is good to go, hopefully @HoustonPutman will create the jira for adding missing licenses! I just went through the long history of the Antora work and unf

[jira] [Created] (SOLR-17365) Not all of the Ref Guide antora UI bundle code has ASL headers

2024-07-10 Thread Houston Putman (Jira)
Houston Putman created SOLR-17365: - Summary: Not all of the Ref Guide antora UI bundle code has ASL headers Key: SOLR-17365 URL: https://issues.apache.org/jira/browse/SOLR-17365 Project: Solr

Re: [PR] SOLR-16198: Introduce tabbed blocks again [solr]

2024-07-10 Thread via GitHub
HoustonPutman commented on PR #2550: URL: https://github.com/apache/solr/pull/2550#issuecomment-2220924389 This should absolutely be credited in the changelog! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (SOLR-10654) Expose Metrics in Prometheus format DIRECTLY from Solr

2024-07-10 Thread Matthew Biscocho (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864665#comment-17864665 ] Matthew Biscocho commented on SOLR-10654: - These tests must be failing depending

[jira] [Resolved] (SOLR-17195) Minimum prefix-length soft limit

2024-07-10 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski resolved SOLR-17195. Fix Version/s: main (10.0) 9.7 Assignee: Jason Gerlowski

Re: [PR] SOLR-10255 Add support for docValues to solr.BinaryField [solr]

2024-07-10 Thread via GitHub
mkhludnev commented on code in PR #2536: URL: https://github.com/apache/solr/pull/2536#discussion_r1670638010 ## solr/core/src/java/org/apache/solr/schema/BinaryField.java: ## @@ -112,7 +125,31 @@ public IndexableField createField(SchemaField field, Object val) { len = b