iamsanjay commented on PR #2724:
URL: https://github.com/apache/solr/pull/2724#issuecomment-2381044293
As you must have seen now that we are doing the migration we are facing some
challenges relating to HttpSolrClient, in some cases It also exposed HttpClient
-- `SolrClientCloudManager`, `H
[
https://issues.apache.org/jira/browse/SOLR-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17442.
--
Fix Version/s: main (10.0)
9.8
Resolution: Fixed
> CLI: Resolve -v flag confl
[
https://issues.apache.org/jira/browse/SOLR-10189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-10189.
--
Fix Version/s: 9.7
Resolution: Fixed
This was completed when we deprecated and removed zkcli.
>
[
https://issues.apache.org/jira/browse/SOLR-17382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17382.
--
Fix Version/s: main (10.0)
9.8
Assignee: Eric Pugh
Resolution: Fixed
[
https://issues.apache.org/jira/browse/SOLR-17451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-17451.
--
Fix Version/s: main (10.0)
Resolution: Fixed
> Pull in refactorings and code cleanups from fix_c
[
https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh updated SOLR-17359:
-
Fix Version/s: 9.8
> Make SolrCLI handle arg parsing of zk sub commands
> ---
dsmiley commented on PR #2587:
URL: https://github.com/apache/solr/pull/2587#issuecomment-2381004621
Will merge as soon as Monday. I also plan to handle RemoteSolrException in
a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/SOLR-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885622#comment-17885622
]
ASF subversion and git services commented on SOLR-17442:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885623#comment-17885623
]
ASF subversion and git services commented on SOLR-17442:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-17442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885619#comment-17885619
]
ASF subversion and git services commented on SOLR-17442:
Commit e
epugh merged PR #2721:
URL: https://github.com/apache/solr/pull/2721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh opened a new pull request, #2726:
URL: https://github.com/apache/solr/pull/2726
Changes from PR#2710.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
dsmiley commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779756046
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collection
dsmiley commented on PR #2724:
URL: https://github.com/apache/solr/pull/2724#issuecomment-2380894586
IMO it's a questionable practice to add a method that will often throw
UnsupportedOperationException.
--
This is an automated message from the Apache Git Service.
To respond to the message
dsmiley commented on PR #2706:
URL: https://github.com/apache/solr/pull/2706#issuecomment-2380893395
I checked out this branch and did `gw assemble` then renamed
`solr/packaging/build/solr-10.0.0-SNAPSHOT/` to have an "-after" suffix. Then
I checked out a recent main (before cross-DC addit
epugh commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2380892859
This was committed into branch_9x in
#35ae5f7c55c27f463db048b975d06ec070fbbeef
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885616#comment-17885616
]
ASF subversion and git services commented on SOLR-17359:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885615#comment-17885615
]
ASF subversion and git services commented on SOLR-6962:
---
Commit 3d40
[
https://issues.apache.org/jira/browse/SOLR-17359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885618#comment-17885618
]
ASF subversion and git services commented on SOLR-17359:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885617#comment-17885617
]
ASF subversion and git services commented on SOLR-6962:
---
Commit 35ae
epugh merged PR #2710:
URL: https://github.com/apache/solr/pull/2710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
gus-asf commented on PR #2710:
URL: https://github.com/apache/solr/pull/2710#issuecomment-2380857581
Can we update the title of this? is it just about CLI stuff? hard to know
what this is about...
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
gerlowskija commented on code in PR #2714:
URL: https://github.com/apache/solr/pull/2714#discussion_r1779720899
##
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##
@@ -533,6 +535,47 @@ public NamedList request(SolrRequest
solrRequest, String collec
malliaridis commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1779652256
##
solr/core/src/java/org/apache/solr/cli/DeleteTool.java:
##
@@ -122,16 +124,36 @@ public List getOptions() {
.desc(
"Skip safety checks
malliaridis commented on code in PR #2710:
URL: https://github.com/apache/solr/pull/2710#discussion_r1779655317
##
solr/packaging/test/test_create.bats:
##
@@ -34,8 +34,31 @@ teardown() {
assert_output --partial "Created new core 'COLL_NAME'"
}
+@test "create_core works" {
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779548037
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,26 @@ protected PassageFormatter getFormatter(String fieldName) {
Seunghan-Jung commented on code in PR #2697:
URL: https://github.com/apache/solr/pull/2697#discussion_r1779530690
##
solr/core/src/java/org/apache/solr/highlight/UnifiedSolrHighlighter.java:
##
@@ -314,6 +343,24 @@ protected PassageFormatter getFormatter(String fieldName) {
Seunghan-Jung commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380669818
> It's somewhat unfortunate to have no Solr level test... but not strictly
necessary. You could probably add a query & assertion to a test method in
TestUnifiedSolrHighlighter. Just sh
Seunghan-Jung commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380663931
@dsmiley
> Just a thought -- is this enum actually buying us anything at all? It's a
bunch of lines of code but only ultimately used for a set lookup and nothing
else? If so, lets
malliaridis commented on code in PR #2725:
URL: https://github.com/apache/solr/pull/2725#discussion_r1779488758
##
solr/core/src/java/org/apache/solr/cli/Tool.java:
##
@@ -52,5 +53,7 @@ default String getFooter() {
List getOptions();
+ List getOptionGroups();
Review Com
dsmiley commented on PR #2697:
URL: https://github.com/apache/solr/pull/2697#issuecomment-2380643974
Just a thought -- is this enum actually buying us anything at all? It's a
bunch of lines of code but only ultimately used for a set lookup and nothing
else? If so, lets just have less line
[
https://issues.apache.org/jira/browse/SOLR-6962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885575#comment-17885575
]
ASF subversion and git services commented on SOLR-6962:
---
Commit 34f7
epugh merged PR #2671:
URL: https://github.com/apache/solr/pull/2671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
malliaridis commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380631255
> You still have to check for each it apepars!! If you find some code that
avoids that, let me know.
I see that you are using the `Option#getOpt()` and `Option#getLongOpt()`
when
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380625072
I was at the point of merging and the --debug syntax just bugged me. I am
backing it out and just keep --verbose which rings better for me, and still
accomplishs the goal of making -v no lon
epugh commented on code in PR #2721:
URL: https://github.com/apache/solr/pull/2721#discussion_r1779473538
##
solr/core/src/java/org/apache/solr/cli/AssertTool.java:
##
@@ -131,7 +131,9 @@ public List getOptions() {
@Override
public int runTool(CommandLine cli) throws Exc
epugh opened a new pull request, #2725:
URL: https://github.com/apache/solr/pull/2725
https://issues.apache.org/jira/browse/SOLR-X
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Plea
epugh commented on PR #2721:
URL: https://github.com/apache/solr/pull/2721#issuecomment-2380613513
@malliaridis I was able to integrate OptionGroup for the --debug and
--verbose options in this PR and it works. What I haven't been able to grok
is how to simplify the checking for the flags
38 matches
Mail list logo
