[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226903265 ## solr/core/src/java/org/apache/solr/cluster/placement/impl/BalancePlanFactoryImpl.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226897201 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226896752 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226892527 ## solr/core/src/java/org/apache/solr/cluster/placement/PlacementPlugin.java: ## @@ -85,5 +104,80 @@ List computePlacements( */ default void verifyAllowedModi

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226879953 ## solr/core/src/test/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactoryTest.java: ## @@ -1443,60 +1445,6 @@ private void testSpreadDomains(boolean

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226879328 ## solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java: ## @@ -451,6 +451,21 @@ List assign( SolrCloudManager solrCloudManager, List assign

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226878099 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226878640 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226875203 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/OrderedNodePlacementPlugin.java: ## @@ -0,0 +1,604 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1226874002 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/SimplePlacementFactory.java: ## @@ -53,118 +43,116 @@ public PlacementPlugin createPluginInstance() {

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224560199 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224420594 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224394581 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java: ## @@ -135,190 +100,35 @@ public void call(ClusterState state, ZkNodeProps message,

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224416272 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224399754 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java: ## @@ -135,190 +100,35 @@ public void call(ClusterState state, ZkNodeProps message,

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224394581 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplaceNodeCmd.java: ## @@ -135,190 +100,35 @@ public void call(ClusterState state, ZkNodeProps message,

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224381083 ## solr/core/src/java/org/apache/solr/cloud/api/collections/ReplicaMigrationUtils.java: ## @@ -0,0 +1,304 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [solr] HoustonPutman commented on a diff in pull request #1650: SOLR-16806: Create a BalanceReplicas API

HoustonPutman commented on code in PR #1650: URL: https://github.com/apache/solr/pull/1650#discussion_r1224379842 ## solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java: ## @@ -251,1006 +231,463 @@ private AffinityPlacementPlugin(