[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695996885 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3 for a key

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695989204 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695984569 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -73,48 +80,51 @@ // Error messages returned by S3 for a key

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695980775 ## File path: versions.props ## @@ -129,5 +129,6 @@ org.tallison:jmatio=1.5 org.threeten:threetenbp=1.3.3 org.tukaani:xz=1.8

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695972996 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -253,17 +256,20 @@ void deleteDirectory(String path) throws

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695971805 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -194,55 +204,48 @@ void deleteDirectory(String path) throws

[GitHub] [solr] athrog commented on a change in pull request #271: SOLR-15599: Upgrade aws sdk

2021-08-25 Thread GitBox
athrog commented on a change in pull request #271: URL: https://github.com/apache/solr/pull/271#discussion_r695965067 ## File path: solr/contrib/s3-repository/src/java/org/apache/solr/s3/S3StorageClient.java ## @@ -129,17 +139,17 @@ void createDirectory(String path) throws