athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-897206704
Yeah good idea. I tried adding this to my `_default` solrconfig.xml, and I
see the libs are added (from a logline), but still getting
ClassNotFoundExceptions when taking backups.
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-896383942
Okay, took my first shot at the ref guide -- let me know what you all think!
One thing that stood out to me while documenting all the params was our use
of the `blob.*` prefix (
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-896281413
Happy to take the other two documentation tasks. @gerlowskija already wrote
a short section in the ref guide for the GCS backup repo, so I can modify that
for S3 easily. Will try to h
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895489520
One more comment since I saw you updated the `versions.lock` file. I noticed
that the s3mock project pulls in a few new versions of libs that solr uses.
This seemed like a bad thing t
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-895462948
Thanks again @HoustonPutman for your time and energy on this PR.
> This is a major change, but I think a big improvement in terms of
usability. Is there a reason why you mandate
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-893590872
@gerlowskija My estimate at this point is that about 75-80% of comments have
been addressed? @HoustonPutman and I have been resolving comments that are now
fixed, so I'm mainly going
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-883624248
Both good points, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-883594327
I'll take a look at the async API issue you described. Most of my testing
lately (in the Solr 9 codebase) has been with the synchronous APIs, so that's a
good callout.
Regardin
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-883590462
Regarding minio, I saw this too in my testing (I tried to make it work
before moving to S3Mock). Their handling of "directory-like" structure is
pretty incompatible with this project.
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-878498749
@HoustonPutman yeah please go ahead! I made the fix for [1] locally and was
testing it out right now. It's the same code as you suggested, so I'm not
worried about merge conflicts or
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-877374795
> Some first thoughts:
>
> * Are y'all planning on renaming the contrib to s3 from blob? It seems
like a logical choice
Yes, renaming the module to `s3-repository` will b
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-876816844
Thank you @madrob for the review. I fixed some of the low hanging fruit,
will circle back later for the other comments (that will require testing after
changes)
--
This is an autom
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-876768134
Also, I'm not sure if it's a problem with my setup or maybe I missed some
gradle setting somewhere, but just doing a `./gradlew assemble` doesn't seem to
put our new `blob-repository`
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-876766387
Just pushed a merge commit @HoustonPutman, along with an update for our
README. Let me know if you have any trouble testing locally, I can add more
documentation if needed.
--
This
athrog commented on pull request #120:
URL: https://github.com/apache/solr/pull/120#issuecomment-857294030
@gerlowskija I'll address the cons list first, that seems to me the most
salient part to discuss:
> Classpath Bloat: Having all blob-store implementations in the same config
me
15 matches
Mail list logo
