[GitHub] [solr] cpoerschke commented on pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-26 Thread GitBox
cpoerschke commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-848950828 > ... I just had the time to look through your changes. ... Thanks @tomglk for taking a look! I've added one more small polish commit to workaround us not yet having

[GitHub] [solr] cpoerschke commented on pull request #123: SOLR-12697 Add pure DocValues support to FieldValueFeature

2021-05-24 Thread GitBox
cpoerschke commented on pull request #123: URL: https://github.com/apache/solr/pull/123#issuecomment-846994896 Hi @tomglk! > I am currently debugging some ltr stuff and stumbled upon this: ... Why don't we try to parse the string value as number? We do that for docValues, but not fo