[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1224298306 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException {

[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1224296895 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException {

[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1223608343 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException {

[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1223572086 ## solr/core/src/java/org/apache/solr/schema/DenseVectorField.java: ## @@ -193,12 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException {

[GitHub] [solr] dsmiley commented on a diff in pull request #1680: SOLR-16836: introduce support for high dimensional vectors

dsmiley commented on code in PR #1680: URL: https://github.com/apache/solr/pull/1680#discussion_r1214296464 ## solr/core/src/test/org/apache/solr/schema/DenseVectorFieldTest.java: ## @@ -456,6 +458,25 @@ public void indexing_correctDocument_shouldBeIndexed() throws Exception {