[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303806467 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303762238 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-23 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1303741279 ## solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java: ## @@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-21 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1300892286 ## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ## @@ -114,6 +115,26 @@ public void test() throws IOException, SolrServerEx

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-20 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299567945 ## solr/core/src/test/org/apache/solr/util/tracing/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299299408 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softw

[GitHub] [solr] dsmiley commented on a diff in pull request #1854: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-08-19 Thread via GitHub
dsmiley commented on code in PR #1854: URL: https://github.com/apache/solr/pull/1854#discussion_r1299243709 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/TestSimplePropagatorDistributedTracing.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Softw