dsmiley commented on code in PR #1854:
URL: https://github.com/apache/solr/pull/1854#discussion_r1303741279
##########
solr/test-framework/src/java/org/apache/solr/cloud/MiniSolrCloudCluster.java:
##########
@@ -1237,6 +1240,11 @@ public MiniSolrCloudCluster build() throws Exception {
"solr.distributedClusterStateUpdates",
Boolean.toString(useDistributedClusterStateUpdate));
+ // eager init to prevent OTEL init races caused by test setup
+ if (!disableTraceIdGeneration &&
TracerConfigurator.TRACE_ID_GEN_ENABLED) {
+ SimplePropagator.load();
+ }
+
Review Comment:
This part seems suspicious because you are adding this to
MiniSolrCloudCluster. Tracing isn't SolrCloud specific and isn't limited to
this utility. Maybe this should be in STCJ4 as there used to be something
which you removed (not sure why)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
