[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-10 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r894843621 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,71 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-10 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r894843028 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,71 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-08 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r892805323 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,71 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-06-02 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r888042243 ## solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java: ## @@ -278,48 +279,72 @@ private void parseError(SolrInputDocument lineRecord, String line, String trace)

[GitHub] [solr] dsmiley commented on a diff in pull request #882: SOLR-14699: Update Solr request logs to JSON format

2022-05-27 Thread GitBox
dsmiley commented on code in PR #882: URL: https://github.com/apache/solr/pull/882#discussion_r883947375 ## solr/core/src/java/org/apache/solr/response/SolrQueryResponse.java: ## @@ -217,17 +219,15 @@ public String getToLogAsString() { /** Returns a string of the form "pref