[GitHub] [solr] dsmiley commented on pull request #1827: SOLR-16916: JSON boolean queries when solrconfig defType is set to edismax

2023-08-23 Thread via GitHub
dsmiley commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1690680228 I switched the test to subclass SolrTestCaseJ4 (which 99% of Solr tests ultimately extend from) as there were mysterious cross-test side-effects when I didn't. I don't have time today to de

[GitHub] [solr] dsmiley commented on pull request #1827: SOLR-16916: JSON boolean queries when solrconfig defType is set to edismax

2023-08-21 Thread via GitHub
dsmiley commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1687328255 Instructions: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-m

[GitHub] [solr] dsmiley commented on pull request #1827: SOLR-16916: JSON boolean queries when solrconfig defType is set to edismax

2023-08-07 Thread via GitHub
dsmiley commented on PR #1827: URL: https://github.com/apache/solr/pull/1827#issuecomment-1667875122 I can anticipate a problem with my suggestion; may or may not be an issue. Sometimes tests use Solr home's and/or configSets _in-place_ (end up being in a build dir) in directories that we