[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-11-02 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958100164 I'll commit this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-11-02 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-958100164 I'll commit this tonight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-10-27 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-953442337 @joel-bernstein I know you've had some concerns about what sort of things happen without a JIRA so I request your opinion here. The point of this PR is to: * Downgrade many depen

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-10-22 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-950013908 I wasn't correct about Janino needing to be excluded... I hadn't noticed it's sha1 change in another change group in IntellliJ. I'm confused about `versions.props`. I thought

[GitHub] [solr] dsmiley commented on pull request #349: Dependency tune-up of solr-core

2021-10-21 Thread GitBox
dsmiley commented on pull request #349: URL: https://github.com/apache/solr/pull/349#issuecomment-949042358 I made further improvements, especially in SolrJ. There is one mystery to me. The license & sha1 check system told me to remove the ones for Janino but I didn't remove Janino;