[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334271795 ## solr/core/src/java/org/apache/solr/pkg/PackageAPI.java: ## @@ -58,7 +59,7 @@ /** This implements the public end points (/api/cluster/package) of package API. */ public

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334269887 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328984793 ## solr/core/src/resources/EnvToSyspropMappings.properties: ## Review Comment: I ❤️ this file!Now imagine if you could find all the possible system property setti

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328982621 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328981379 ## solr/bin/solr: ## @@ -1345,12 +1352,10 @@ if [ $# -gt 0 ]; then ;; -v) SOLR_LOG_LEVEL=DEBUG -PASS_TO_RUN_EXAMPLE+=("-Dsolr.log.

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328980855 ## solr/bin/solr: ## @@ -112,6 +112,13 @@ elif [ -r "$SOLR_INCLUDE" ]; then . "$SOLR_INCLUDE" fi +# Export all SOLR variables so they are visible to Solr sub-process +

[GitHub] [solr] epugh commented on a diff in pull request #1935: SOLR-15960 Unified use of system properties and environment variables

epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1328977642 ## solr/core/src/java/org/apache/solr/util/EnvUtils.java: ## @@ -0,0 +1,235 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic