epugh commented on code in PR #1935: URL: https://github.com/apache/solr/pull/1935#discussion_r1334269887
########## solr/core/src/resources/EnvToSyspropMappings.properties: ########## @@ -13,10 +15,15 @@ SOLR_TIMEZONE=user.timezone SOLR_TIP=solr.install.dir SOLR_TIP_SYM=solr.install.symDir SOLR_WAIT_FOR_ZK=waitForZk +ZK_CLIENT_TIMEOUT=zkClientTimeout +ZK_CREATE_CHROOT=createZkChroot +ZK_HOST=zkHost # These should not be mapped to system properties Review Comment: why should these not be mapped to system properties? wouldn't you want to be able to set some of these that way?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
