[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1276146141 I went ahead and looked at the other specific subclasses of `SolrClient` and `SolrCloudClient`...I think at THIS POINT, I am now done with this PR. I am running all the tests again, and a

[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1274436928 @dsmiley I think I am done! Only had to touch 105 files ;-). I have a list of improvements I'd like to make, but those can be for follow up PR's... -- This is an automated message from t

[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247936897 THanks for sharing those thoughts @dsmiley . I'm going to keep plugging away, and try and stay away from refactoring things in this PR! -- This is an automated message from the Apache

[GitHub] [solr] epugh commented on pull request #1012: SOLR-16368: Use SolrClient type instead of overly specific subclasses

epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247162304 One thing I've noticed is a lot of places where we cast to a specific client just to get the httpClient. We do it all over the place in the tests... ``` solrClient = getCloudSolrClie