epugh commented on PR #1012: URL: https://github.com/apache/solr/pull/1012#issuecomment-1247162304
One thing I've noticed is a lot of places where we cast to a specific client just to get the httpClient. We do it all over the place in the tests... ``` solrClient = getCloudSolrClient(cluster); httpClient = (CloseableHttpClient) ((CloudLegacySolrClient) solrClient).getHttpClient(); ``` Thoughts on introducing a `getHttp1Client` method in the base test class that would take a `SolrClient` and could interrogate it and return the httpClient? That would remove a ton of places where we refer to `CloudLegacySolrClient`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
