[GitHub] [solr] epugh commented on pull request #1728: SOLR-16845 BinaryResponseWriter should not attempt cast to Utf8CharSequence

epugh commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1634178280 Please do! I am out for the next week, so if you don't hear back in the upcoming week, then do ping me. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [solr] epugh commented on pull request #1728: SOLR-16845 BinaryResponseWriter should not attempt cast to Utf8CharSequence

epugh commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1613280937 Let's give it a day or two to see if anyone weighs in, and then happy to commit it! The perf numbers are nice ;-) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [solr] epugh commented on pull request #1728: SOLR-16845 BinaryResponseWriter should not attempt cast to Utf8CharSequence

epugh commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1611843076 Does the "beasting" technique help on building confidence on this? I *really* *really* want to click the "Squash and Merge" button ;-) -- This is an automated message from th

[GitHub] [solr] epugh commented on pull request #1728: SOLR-16845 BinaryResponseWriter should not attempt cast to Utf8CharSequence

epugh commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1611781274 For changes like this, I wish there was a way for me, as someone who hasn't really worked deeply in this code base to know that this is a positivie safe change.. When folks add features and