epugh commented on PR #1728: URL: https://github.com/apache/solr/pull/1728#issuecomment-1611781274
For changes like this, I wish there was a way for me, as someone who hasn't really worked deeply in this code base to know that this is a positivie safe change.. When folks add features and add new unit tests, those tests demonstrate that the change is safe and good... In this case, where you are refactoring/simplifying, how can we have general confidence in the change? <--- This is kind of a more general question.... For example, is there a set of tests you could run and attach some sort of data that shows that this change doesnt' have any side effects or performance issues? I know this is also a topic to bring up at our next Community meeting.... How to do performance testing ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
