gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1022628525
I think that's everyone's review comments, except for Eric's (totally
justified) finger-wagging about my incorrect import settings, which I'm still
wrestling with.
I'm go
gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1022613929
> Put the new ones inside, leave the old ones?
It wouldn't be my choice in a vacuum: I can live with giving up on my
long-term goal of reusing these payload classes, but i
gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1021504830
> There are 430 results for "Indexes", and honestly, the more I think on it,
I think that while "Indices" may be grammatically correct, "Indexes" is really
the word we use! At a
gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1021285346
> why not fix "indexes" spelling now?
Two "soft" reasons:
1. It's hard to imagine anyone caring about "indexes" in particular, but in
theory I could imagine someone
gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1021285346
> why not fix "indexes" spelling now?
Two "soft" reasons:
1. It's hard to imagine anyone caring about "indexes" in particular, but in
theory I could imagine someone
