[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295650436 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295650436 ## solr/modules/opentelemetry/src/test/org/apache/solr/opentelemetry/CustomTestOtelTracerConfigurator.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1295565981 ## solr/core/src/java/org/apache/solr/core/TracerConfigurator.java: ## @@ -17,83 +17,88 @@ package org.apache.solr.core; -import io.opentracing.Scope; -import io.opent

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294974887 ## solr/core/src/java/org/apache/solr/api/AnnotatedApi.java: ## @@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { } for (Comm

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294974887 ## solr/core/src/java/org/apache/solr/api/AnnotatedApi.java: ## @@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse rsp) { } for (Comm

[GitHub] [solr] janhoy commented on a diff in pull request #1841: SOLR-16536 Replace OpenTracing instrumentation with OpenTelemetry

janhoy commented on code in PR #1841: URL: https://github.com/apache/solr/pull/1841#discussion_r1294975785 ## solr/modules/opentelemetry/src/java/org/apache/solr/opentelemetry/OtelTracerConfigurator.java: ## @@ -16,38 +16,56 @@ */ package org.apache.solr.opentelemetry; -imp