janhoy commented on code in PR #1841:
URL: https://github.com/apache/solr/pull/1841#discussion_r1294974887
##########
solr/core/src/java/org/apache/solr/api/AnnotatedApi.java:
##########
@@ -215,7 +214,6 @@ public void call(SolrQueryRequest req, SolrQueryResponse
rsp) {
}
for (CommandOperation cmd : cmds) {
- TraceUtils.ifNotNoop(req.getSpan(), (span) -> span.log("Command: " +
cmd.name));
Review Comment:
From the
[docs](https://opentracing.io/docs/overview/tags-logs-baggage/#logs):
> Logs are key:value pairs that are useful for capturing timed log messages
and other debugging or informational output from the application itself. Logs
may be useful for documenting a specific moment or event within the span (in
contrast to tags which should apply to the span regardless of time).
The equivalent in OTEL seems to be "event", i.e. `mySpan.addEvent("foo")`.
Perhaps use that for this PR and then decide in followup PRs whether it is even
the right tool for the job - does not seem like correct use of `log()` in this
case imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
