janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1732134302
Camel case support is now better. `getProp("solr.fooBar")` now falls back to
`solr.foo.bar`. Also setting env `SOLR_FOO_BAR` will set both `solr.fooBar` due
to the unstandard mapping, and `so
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1731938763
I added some refguide docs and some examples in `solr.in.sh/cmd`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1731938302
> One question about your envVar exporting in bin/solr. Is that command
compatible across unix varieties?
Yea, both `compgen` and `export` are built-in commands of bash, and the
start
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1731382216
> This is all looking really great @janhoy ... If the process of getting
this done everywhere is a big job, make other jira's and maybe split them up by
area so others can help?
For su
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1725848926
Widening the review to get more perspectives.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1725127507
> Would then the preferred access mode for getting properties be via
`EnvUtils.getProp(SolrDispatchFilter.SOLR_DEFAULT_CONFDIR_ATTRIBUTE)` pattern?
I could imagine in a future ticket getting
janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1722898115
Tests pass, @epugh can you have a first quick review and tell if this helps
your CLI work? After your first feedback I can invite more reviewers.
I feel the principle is well proven by
