janhoy commented on PR #1935: URL: https://github.com/apache/solr/pull/1935#issuecomment-1725127507
> Would then the preferred access mode for getting properties be via `EnvUtils.getProp(SolrDispatchFilter.SOLR_DEFAULT_CONFDIR_ATTRIBUTE)` pattern? I could imagine in a future ticket getting rid of the System.getPRoperty and adding that to our list of disallowed methods ;-). One more thought, how did you build the list of nonstandard mappings? Such moves can be considered for sure. The `EnvUtils.getProp()` method does not bring much to the table, but the other variants such as `getPropAsList()` etc are helpful, but still a convenience on top of the props. I may have duplicated similar logic from other Solr Util classes, so happy to consolidate if you know of something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
