madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r706349788
##
File path: solr/solr-ref-guide/src/caches-warming.adoc
##
@@ -79,6 +79,9 @@ Reasonable values, depending on the query volume and
patterns, may lie somewhere
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r706347715
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -114,9 +126,12 @@ public Object init(Map args, Object
persistence, CacheRegene
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683771913
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -176,33 +193,92 @@ public V get(K key) {
return cache.getIfPresent(key);
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r683729013
##
File path: solr/core/src/java/org/apache/solr/search/CaffeineCache.java
##
@@ -190,73 +191,72 @@ public V get(K key) {
return cache.getIfPresent(key);
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r676967652
##
File path: solr/core/src/java/org/apache/solr/query/SolrRangeQuery.java
##
@@ -452,6 +455,7 @@ private SegState getSegState(LeafReaderContext context)
throw
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r676963773
##
File path: solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java
##
@@ -804,15 +807,29 @@ public BitDocSet getDocSetBits(Query q) throws
IOExcept
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r676963537
##
File path: solr/core/src/java/org/apache/solr/search/facet/UnInvertedField.java
##
@@ -605,80 +605,7 @@ public static UnInvertedField getUnInvertedField(Stri
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r675200608
##
File path: solr/core/src/java/org/apache/solr/search/facet/UnInvertedField.java
##
@@ -605,80 +605,14 @@ public static UnInvertedField getUnInvertedField(Str
madrob commented on a change in pull request #230:
URL: https://github.com/apache/solr/pull/230#discussion_r674457589
##
File path: solr/core/src/java/org/apache/solr/search/SolrCache.java
##
@@ -106,8 +107,23 @@
* @return existing or newly computed value, null if there was
